Gnus development mailing list
 help / color / mirror / Atom feed
* p0.57: MIMEish uuencoded image throws error
@ 1998-12-01  4:02 Karl Kleinpaste
  1998-12-01  4:42 ` Shenghuo ZHU
  0 siblings, 1 reply; 2+ messages in thread
From: Karl Kleinpaste @ 1998-12-01  4:02 UTC (permalink / raw)


A message containing nothing but a uuencoded .jpg throws this error
after requesting image display with `1 b':

Signaling: (wrong-type-argument consp nil)
  mm-get-image((#<buffer " *mm-uu*"> ("image/jpeg") uudecode-decode-region nil ("attachment" (filename . "OK.JPG")) "OK.JPG"))
  mm-inline-image((#<buffer " *mm-uu*"> ("image/jpeg") uudecode-decode-region nil ("attachment" (filename . "OK.JPG")) "OK.JPG"))
  mm-display-inline((#<buffer " *mm-uu*"> ("image/jpeg") uudecode-decode-region nil ("attachment" (filename . "OK.JPG")) "OK.JPG"))
  mm-display-part((#<buffer " *mm-uu*"> ("image/jpeg") uudecode-decode-region nil ("attachment" (filename . "OK.JPG")) "OK.JPG"))
  gnus-mm-display-part((#<buffer " *mm-uu*"> ("image/jpeg") uudecode-decode-region nil ("attachment" (filename . "OK.JPG")) "OK.JPG"))
  gnus-article-view-part(1)
  call-interactively(gnus-article-view-part)


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: p0.57: MIMEish uuencoded image throws error
  1998-12-01  4:02 p0.57: MIMEish uuencoded image throws error Karl Kleinpaste
@ 1998-12-01  4:42 ` Shenghuo ZHU
  0 siblings, 0 replies; 2+ messages in thread
From: Shenghuo ZHU @ 1998-12-01  4:42 UTC (permalink / raw)


>>>>> "KK" == Karl Kleinpaste <karl@justresearch.com> writes:

KK> A message containing nothing but a uuencoded .jpg throws this error
KK> after requesting image display with `1 b':

Fixed. 

ChangeLog:

Mon Nov 30 23:38:02 1998  Shenghuo ZHU  <zsh@cs.rochester.edu>

	* mm-uu.el (mm-uu-dissect): Use mm-make-handle.

-- 
Shenghuo

:- cut ------------------------------------------------------
--- mm-uu.el	1998/12/01 04:34:33	1.1
+++ mm-uu.el	1998/12/01 04:37:33
@@ -118,16 +118,16 @@
 			    (error nil))))
 	    (if (> start-char text-start)
 		(push
-		 (list (mm-uu-copy-to-buffer text-start start-char) 
-		       text-plain-type cte nil nil nil) 
+		 (mm-make-handle (mm-uu-copy-to-buffer text-start start-char) 
+		       text-plain-type cte) 
 		 result))
 	    (push 
 	     (cond
 	      ((eq type 'postscript)
-	       (list (mm-uu-copy-to-buffer start-char end-char) 
-		     '("application/postscript") nil nil nil nil))
+	       (mm-make-handle (mm-uu-copy-to-buffer start-char end-char) 
+		     '("application/postscript")))
 	      ((eq type 'uu)
-	       (list (mm-uu-copy-to-buffer start-char end-char) 
+	       (mm-make-handle (mm-uu-copy-to-buffer start-char end-char) 
 		     (list (or (and file-name
 				    (string-match "\\.[^\\.]+$" file-name) 
 				    (mailcap-extension-to-mime 
@@ -135,10 +135,9 @@
 			       "application/octet-stream"))
 		     mm-uu-decode-function nil 
 		     (if (and file-name (not (equal file-name "")))
-			 (list "attachment" (cons 'filename file-name)))
-		   file-name))
+			 (list "attachment" (cons 'filename file-name)))))
 	      ((eq type 'binhex)
-	       (list (mm-uu-copy-to-buffer start-char end-char) 
+	       (mm-make-handle (mm-uu-copy-to-buffer start-char end-char) 
 		     (list (or (and file-name
 				    (string-match "\\.[^\\.]+$" file-name) 
 				    (mailcap-extension-to-mime 
@@ -146,18 +145,17 @@
 			       "application/octet-stream"))
 		     mm-uu-binhex-decode-function nil 
 		     (if (and file-name (not (equal file-name "")))
-			 (list "attachment" (cons 'filename file-name)))
-		     file-name))
+			 (list "attachment" (cons 'filename file-name)))))
 	      ((eq type 'shar)
-	       (list (mm-uu-copy-to-buffer start-char end-char) 
-		     '("application/x-shar") nil nil nil nil))) 
+	       (mm-make-handle (mm-uu-copy-to-buffer start-char end-char) 
+		     '("application/x-shar")))) 
 	     result)
 	    (setq text-start end-char))))
       (when result
 	(if (> (point-max) (1+ text-start))
 	    (push
-	     (list (mm-uu-copy-to-buffer text-start (point-max)) 
-		   text-plain-type cte nil nil nil) 
+	     (mm-make-handle (mm-uu-copy-to-buffer text-start (point-max)) 
+		   text-plain-type cte) 
 	     result))
 	(setq result (cons "multipart/mixed" (nreverse result))))
       result)))


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~1998-12-01  4:42 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
1998-12-01  4:02 p0.57: MIMEish uuencoded image throws error Karl Kleinpaste
1998-12-01  4:42 ` Shenghuo ZHU

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).