From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/61186 Path: news.gmane.org!not-for-mail From: Bill Wohler Newsgroups: gmane.emacs.devel,gmane.emacs.gnus.general,gmane.mail.mh-e.devel Subject: Re: Sharing mail icons between MH-E and Gnus Date: Mon, 17 Oct 2005 08:32:28 -0700 Organization: Newt Software Message-ID: <30678.1129563148@olgas.newt.com> References: <28928.1129483226@olgas.newt.com> NNTP-Posting-Host: main.gmane.org X-Trace: sea.gmane.org 1129563358 18340 80.91.229.2 (17 Oct 2005 15:35:58 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 17 Oct 2005 15:35:58 +0000 (UTC) Cc: Ding List , mh-e-devel@lists.sourceforge.net, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Oct 17 17:35:54 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1ERWyg-0006Wd-H8 for ged-emacs-devel@m.gmane.org; Mon, 17 Oct 2005 17:32:42 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ERWyg-0004cb-0H for ged-emacs-devel@m.gmane.org; Mon, 17 Oct 2005 11:32:42 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1ERWyW-0004cW-0A for emacs-devel@gnu.org; Mon, 17 Oct 2005 11:32:32 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1ERWyV-0004cK-Hq for emacs-devel@gnu.org; Mon, 17 Oct 2005 11:32:31 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ERWyV-0004cH-Ey for emacs-devel@gnu.org; Mon, 17 Oct 2005 11:32:31 -0400 Original-Received: from [207.69.195.61] (helo=pop-gadwall.atl.sa.earthlink.net) by monty-python.gnu.org with esmtp (Exim 4.34) id 1ERWyV-0008WT-Hh for emacs-devel@gnu.org; Mon, 17 Oct 2005 11:32:31 -0400 Original-Received: from h-68-166-188-126.snvacaid.dynamic.covad.net ([68.166.188.126] helo=olgas.newt.com) by pop-gadwall.atl.sa.earthlink.net with esmtp (Exim 3.36 #10) id 1ERWyT-0003GL-00; Mon, 17 Oct 2005 11:32:29 -0400 Original-Received: by olgas.newt.com (Postfix, from userid 1000) id 0F42D16FE1; Mon, 17 Oct 2005 08:32:28 -0700 (PDT) Original-Received: from olgas.newt.com (localhost [127.0.0.1]) by olgas.newt.com (Postfix) with ESMTP id 0BE6116FD0; Mon, 17 Oct 2005 08:32:28 -0700 (PDT) Original-To: Reiner Steib Original-Newsgroups: gmane.mail.mh-e.devel In-Reply-To: Reiner Steib's message of Mon, 17 Oct 2005 15:27:18 +0200. X-Mailer: MH-E 7.85+cvs; nmh 1.1; GNU Emacs 21.4.1 X-Image-URL: http://www.newt.com/wohler/images/bill-diving.png X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:44189 gmane.emacs.gnus.general:61186 gmane.mail.mh-e.devel:10784 Archived-At: Reiner Steib wrote: > On Sun, Oct 16 2005, Bill Wohler wrote: > > > Also, the images can be shared by other applications (I hope that > > this will be the case with Gnus soon) so this naming would avoid > > having multiple copies of the same image. > > What do you think about my suggestions on using GNOME stock icons? > IMHO those look much nicer than the current Gnus icons and fit much > better into the rest of the Emacs icons. > > See > and . Reiner, Many of the Emacs icons came from Gnome back in 2000; I recently added a refresh icon from Gnome 2.10. It would be good to update them all. Perhaps someone more legally minded can speak to the license or copyright issues. Anyway, thanks for bringing this up. I had planned to send a note to the Gnus folks soon regarding the icons, but I may as well make it now. I am following the good example set by the Gnus folks and will soon (this afternoon?) check in a change into GNU Emacs that moves *all* of the images from lisp/toolbar to etc/images. In addition, Stallman wanted me to replace the underscore (_) in filenames with dashes (-) while I was at it so the names conform with Emacs policy. I also placed mail_compose and mail_send into mail/compose and mail/send. I updated gnus/message.el as a result of the former change. It would great if Gnus and MH-E could share images where it makes sense to do so. For example, would the Gnus folks mind using mail/reply instead of gnus/reply? The Debian (and other distributions) MH-E and Gnus maintainers might discuss creating a shared image package and having the MH-E and Gnus packages depend on that or Emacs 22. Another new policy is that images must be fully qualified relative to the etc/images directory. Instead of reply, mail/reply must be used. This removes the chance of name collisions. That means nnheader-find-etc-directory must not add gnus to the path element. A new feature of Emacs 22 is an image-load-path variable used by find-image. The image-load-path variable contains the symbol load-path for backwards compatibility. I wrote mh-image-load-path based upon your nnheader-find-etc-directory and another one I can't remember now to update image-load-path or load-path based upon the MH-E library. It would be good to generalize it so that we can share it. What do you think about my renaming it to something like generate-image-load-path, adding a PACKAGE argument, and adding it to image.el? Then we can define it with (if (not (fboundp 'generate-image-load-path ...))) in our code to work with Emacs 20 and 21. (defun mh-image-load-path () "Ensure that the MH-E images are accessible by `find-image'. Images for MH-E are found in ../../etc/images relative to the files in `lisp/mh-e'. If `image-load-path' exists (since Emacs 22), then the images directory is added to it if isn't already there. Otherwise, the images directory is added to the `load-path' if it isn't already there." (unless mh-image-load-path-called-flag (let (mh-library-name mh-image-load-path) ;; First, find mh-e in the load-path. (setq mh-library-name (locate-library "mh-e")) (if (not mh-library-name) (error "Can not find MH-E in load-path")) (setq mh-image-load-path (expand-file-name (concat (file-name-directory mh-library-name) "../../etc/images"))) (if (not (file-exists-p mh-image-load-path)) (error "Can not find image directory %s" mh-image-load-path)) (if (boundp 'image-load-path) (add-to-list 'image-load-path mh-image-load-path) (add-to-list 'load-path mh-image-load-path))) (setq mh-image-load-path-called-flag t))) -- Bill Wohler http://www.newt.com/wohler/ GnuPG ID:610BD9AD Maintainer of comp.mail.mh FAQ and MH-E. Vote Libertarian! If you're passed on the right, you're in the wrong lane.