From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/5606 Path: main.gmane.org!not-for-mail From: Roderick Schertler Newsgroups: gmane.emacs.gnus.general Subject: repeated headers from gnus-reply-to-function Date: Tue, 19 Mar 1996 16:52:47 -0500 Sender: roderick@ibcinc.com Message-ID: <3130.827272367@ibcinc.com> NNTP-Posting-Host: coloc-standby.netfonds.no X-Trace: main.gmane.org 1035146185 829 80.91.224.250 (20 Oct 2002 20:36:25 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Sun, 20 Oct 2002 20:36:25 +0000 (UTC) Return-Path: ding-request@ifi.uio.no Original-Received: from biggulp.callamer.com (root@biggulp.callamer.com [199.74.141.2]) by deanna.miranova.com (8.7.3/8.6.9) with ESMTP id PAA00186 for ; Tue, 19 Mar 1996 15:19:14 -0800 Original-Received: from ifi.uio.no (ifi.uio.no [129.240.64.2]) by biggulp.callamer.com (8.7.4/8.7.3) with SMTP id PAA26527 for ; Tue, 19 Mar 1996 15:05:09 -0800 (PST) Original-Received: from uu6.psi.com (uu6.psi.com [38.145.155.3]) by ifi.uio.no with SMTP (8.6.11/ifi2.4) id for ; Tue, 19 Mar 1996 23:21:58 +0100 Original-Received: by uu6.psi.com (5.65b/4.0.071791-PSI/PSINet) via UUCP; id AA17438 for ; Tue, 19 Mar 96 17:02:02 -0500 Original-Received: from david by junior.ibcinc.com (5.4R3.10/IBC-1.25) id AA29409; Tue, 19 Mar 1996 16:52:50 -0500 Original-Received: from localhost by david.ibcinc.com (5.4R3.10/IBC/s-1.5) id AA03131; Tue, 19 Mar 1996 16:52:48 -0500 Original-To: ding@ifi.uio.no Xref: main.gmane.org gmane.emacs.gnus.general:5606 X-Report-Spam: http://spam.gmane.org/gmane.emacs.gnus.general:5606 Here's a fix for a couple of problems with gnus-mail-reply, both related to gnus-reply-to-function. - The first problem is that gnus-mail-reply would lose when it tried to append a header in follow-to to an existing header of that name. Eg, given (setq gnus-followup-to-function (lambda (group) '(("cc" . "first-cc") ("cc" . "second-cc")))) I'd get a cc: header like cc:, second-ccfirst-cc (with the ", " inserted in the wrong place). - The second problem is that gnus-mh-mail-setup (and MH in general) creates empty headers without a trailing space. When gnus-mail-reply would try to add to such a header it wouldn't insert the missing space, leaving something like cc:address@home.org gnus-news-followup doesn't need either of these fixes because it doesn't try to integrate the follow-to headers with whatever already exists in the buffer, it just inserts a new header for each follow-to element. It might be better to change both of these functions to use mail-position-on-field or something like that. --- ChangeLog~ Sun Mar 17 10:46:18 1996 +++ ChangeLog Tue Mar 19 16:32:57 1996 @@ -1,3 +1,8 @@ +Tue Mar 19 16:26:13 1996 Roderick Schertler + + * gnus-msg.el (gnus-mail-reply): Would bug out given multiple + follow-to elements for the same header. + Sun Mar 17 13:17:26 1996 Lars Magne Ingebrigtsen * gnus.el (gnus-article-hide-pgp): Would hide one char too many. --- gnus-msg.el.~1~ Sun Mar 17 10:46:08 1996 +++ gnus-msg.el Tue Mar 19 16:06:14 1996 @@ -2023,12 +2023,16 @@ (while follow-to (goto-char (point-min)) (if (not (re-search-forward - (concat "^" (caar follow-to) ": *") nil t)) + (concat "^" (caar follow-to) ":") nil t)) (progn (goto-char beg) (insert (caar follow-to) ": " (cdar follow-to) "\n")) - (unless (eolp) - (insert ", ")) + (if (eolp) + (insert " ") + (skip-chars-forward " ") + (unless (eolp) + (end-of-line) + (insert ", "))) (insert (cdar follow-to))) (setq follow-to (cdr follow-to))) (widen))) -- Roderick Schertler roderick@gate.net