* nnrss broken on Emacs master?
@ 2017-02-18 5:29 Mike Kupfer
2017-02-21 0:39 ` Katsumi Yamaoka
0 siblings, 1 reply; 3+ messages in thread
From: Mike Kupfer @ 2017-02-18 5:29 UTC (permalink / raw)
To: ding
I have a few nnrss groups. When I read them with Emacs 21.5.91, the
postings appear as multipart/alternative with buttons, e.g.,
-----8<-----8<-----
Newsgroups: ACM Queue Blogroll
Subject: The Road to Debugging Success
From: blog dds
Date: Thu, 16 Feb 2017 13:55:44 GMT
MIME-Version: 1.0
Content-Type: multipart/alternative; boundary="=-=-="
Message-ID: <1738@ACM_Queue_Blogroll.nnrss>
1. (*) text/plain ( ) text/html
A colleague recently asked me how to debug a Linux embedded system
----->8----->8-----
(This is after invoking gnus-summary-toggle-header.)
When I read them with Emacs master (a83b6692), I get stuff that looks
like
-----8<-----8<-----
Newsgroups: ACM Queue Blogroll
Subject: The Road to Debugging Success
From: blog dds
Date: Thu, 16 Feb 2017 13:55:44 GMT
MIME-Version: 1.0
Content-Type: text/plain
Message-ID: <1738@ACM_Queue_Blogroll.nnrss>
<#multipart type=alternative>
<#part type="text/plain">
A colleague recently asked me how to debug a Linux embedded system
----->8----->8-----
Sometimes the text/plain version has HTML markup, which makes it hard to
read. With 25.1.91, I can click on the text/html button to make it
readable. With the current code in master, I seem to be out of luck.
Are nnrss groups working for anyone else?
mike
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: nnrss broken on Emacs master?
2017-02-18 5:29 nnrss broken on Emacs master? Mike Kupfer
@ 2017-02-21 0:39 ` Katsumi Yamaoka
2017-02-21 3:31 ` Mike Kupfer
0 siblings, 1 reply; 3+ messages in thread
From: Katsumi Yamaoka @ 2017-02-21 0:39 UTC (permalink / raw)
To: ding
[-- Attachment #1: Type: text/plain, Size: 1063 bytes --]
On Fri, 17 Feb 2017 21:29:43 -0800, Mike Kupfer wrote:
> I have a few nnrss groups. When I read them with Emacs 21.5.91, the
> postings appear as multipart/alternative with buttons, e.g.,
[...]
> When I read them with Emacs master (a83b6692), I get stuff that looks
> like
> -----8<-----8<-----
> Newsgroups: ACM Queue Blogroll
> Subject: The Road to Debugging Success
> From: blog dds
> Date: Thu, 16 Feb 2017 13:55:44 GMT
> MIME-Version: 1.0
> Content-Type: text/plain
> Message-ID: <1738@ACM_Queue_Blogroll.nnrss>
> <#multipart type=alternative>
> <#part type="text/plain">
> A colleague recently asked me how to debug a Linux embedded system
----->8----->8-----
> Sometimes the text/plain version has HTML markup, which makes it hard to
> read.
Fixed in master:
<http://lists.gnu.org/archive/html/emacs-diffs/2017-02/msg00271.html>
> Are nnrss groups working for anyone else?
I needed to tweak `url-insert-file-contents' temporarily as
follows to make nnrss work. It will probably cause some trouble
if the server is not working properly, though. :(
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 1468 bytes --]
--- lisp/url/url-hanrlers.el~ 2017-01-04 22:17:18 +0000
+++ lisp/url/url-hanrlers.el 2017-02-21 00:36:20 +0000
@@ -339,23 +339,6 @@
(defun url-insert-file-contents (url &optional visit beg end replace)
(let ((buffer (url-retrieve-synchronously url)))
(unless buffer (signal 'file-error (list url "No Data")))
- (with-current-buffer buffer
- ;; XXX: This is HTTP/S specific and should be moved to url-http
- ;; instead. See http://debbugs.gnu.org/17549.
- (when (bound-and-true-p url-http-response-status)
- ;; Don't signal an error if VISIT is non-nil, because
- ;; 'insert-file-contents' doesn't. This is required to
- ;; support, e.g., 'browse-url-emacs', which is a fancy way of
- ;; visiting the HTML source of a URL: in that case, we want to
- ;; display a file buffer even if the URL does not exist and
- ;; 'url-retrieve-synchronously' returns 404 or whatever.
- (unless (or visit
- (and (>= url-http-response-status 200)
- (< url-http-response-status 300)))
- (let ((desc (nth 2 (assq url-http-response-status url-http-codes))))
- (kill-buffer buffer)
- ;; Signal file-error per http://debbugs.gnu.org/16733.
- (signal 'file-error (list url desc))))))
(url-insert-buffer-contents buffer url visit beg end replace)))
(put 'insert-file-contents 'url-file-handlers 'url-insert-file-contents)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-02-21 3:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-18 5:29 nnrss broken on Emacs master? Mike Kupfer
2017-02-21 0:39 ` Katsumi Yamaoka
2017-02-21 3:31 ` Mike Kupfer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).