From: Bill Wohler <wohler@newt.com>
Cc: ding@gnus.org, mh-e-devel@lists.sourceforge.net
Subject: Re: New GNOME icons
Date: Mon, 13 Mar 2006 08:56:22 -0800 [thread overview]
Message-ID: <3861.1142268982@olgas.newt.com> (raw)
In-Reply-To: <b4mmzfuftnr.fsf@jpl.org>
[Taking emacs-devel off the cc list since they don't need to be bothered
by this. Or do they?]
Katsumi Yamaoka <yamaoka@jpl.org> wrote:
> >>>>> In <v9fylp4zwh.fsf@marauder.physik.uni-ulm.de>
> >>>>> Reiner Steib wrote:
>
> > [1] * gmm-utils.el (gmm-image-load-path-for-library): Return single
> > directory if path is t. Add no-error.
>
> Because of the `no-error' argument[1], I needed to modify the
> `gmm-defun-compat' macro as follows
Why? The arguments to *-defun-compat shouldn't make any difference. What
problems were you seeing?
> since I'm using Emacs 23.
What's that?
> It will become unnecessary soon (when the `emacs-unicode-2'
> branch is synch'd with the trunk), though.
Please document that.
Your patch is completely undecipherable to me. I'd like to see some
documentation regarding the motivation for it, as well as what it is
doing.
> --8<---------------cut here---------------start------------->8---
> --- gmm-utils.el~ 2006-03-07 22:01:08 +0000
> +++ gmm-utils.el 2006-03-13 11:51:18 +0000
> @@ -285,8 +285,19 @@
> "Create function NAME.
> If FUNCTION exists, then NAME becomes an alias for FUNCTION.
> Otherwise, create function NAME with ARG-LIST and BODY."
> - (let ((defined-p (fboundp function)))
> - (if defined-p
> + (let ((definition (and (fboundp function)
> + (symbol-function function))))
> + ;; FIXME: If a function which is not a byte compiled one might be
> + ;; given as FUNCTION, we'll have to use `ad-arglist' or equivalent.
> + (if (and definition
> + (or (not (byte-code-function-p definition))
> + (eq (length arg-list)
> + (ignore-errors
> + (length (if (fboundp 'compiled-function-arglist)
> + ;; XEmacs
> + (eval (list 'compiled-function-arglist
> + definition))
> + (aref definition 0)))))))
> `(defalias ',name ',function)
> `(defun ,name ,arg-list ,@body))))
>
> --8<---------------cut here---------------end--------------->8---
>
> [1] image-load-path-for-library is a compiled Lisp function in `image.el'.
> (image-load-path-for-library LIBRARY IMAGE &optional PATH)
>
>
> -------------------------------------------------------
> This SF.Net email is sponsored by xPML, a groundbreaking scripting language
> that extends applications into web and mobile media. Attend the live webcast
> and join the prime developer group breaking into this new coding territory!
> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
> _______________________________________________
> mh-e-devel mailing list
> mh-e-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/mh-e-devel
>
--
Bill Wohler <wohler@newt.com> http://www.newt.com/wohler/ GnuPG ID:610BD9AD
Maintainer of comp.mail.mh FAQ and MH-E. Vote Libertarian!
If you're passed on the right, you're in the wrong lane.
-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
next prev parent reply other threads:[~2006-03-13 16:56 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-07 0:18 Bill Wohler
2006-03-10 23:15 ` Bill Wohler
2006-03-10 23:56 ` Reiner Steib
2006-03-11 1:23 ` Bill Wohler
2006-03-11 1:29 ` Miles Bader
2006-03-11 12:48 ` Reiner Steib
2006-03-11 2:12 ` *image-load-path-for-library update Bill Wohler
2006-03-11 11:33 ` Reiner Steib
2006-03-11 22:53 ` Bill Wohler
2006-03-12 1:43 ` Bill Wohler
2006-03-12 2:00 ` Bill Wohler
2006-03-13 11:52 ` New GNOME icons Katsumi Yamaoka
2006-03-13 16:56 ` Bill Wohler [this message]
2006-03-14 5:32 ` Katsumi Yamaoka
2006-03-14 6:43 ` Bill Wohler
2006-03-14 11:57 ` Katsumi Yamaoka
2006-03-14 17:58 ` Bill Wohler
2006-03-15 1:49 ` Katsumi Yamaoka
2006-03-15 7:34 ` Katsumi Yamaoka
2006-03-15 7:58 ` Katsumi Yamaoka
2006-03-16 1:41 ` gmm-image-load-path-for-library redux (was: New GNOME icons) Bill Wohler
2006-03-16 2:04 ` gmm-image-load-path-for-library redux Katsumi Yamaoka
2006-03-16 7:24 ` Katsumi Yamaoka
2006-03-16 8:05 ` Bill Wohler
2006-03-16 17:41 ` Bill Wohler
2006-03-16 1:39 ` New GNOME icons Katsumi Yamaoka
2006-03-14 15:16 ` Reiner Steib
2006-03-14 19:29 ` Bill Wohler
2006-03-14 21:00 ` Reiner Steib
2006-03-14 21:35 ` Bill Wohler
2006-03-15 8:58 ` Reiner Steib
2006-03-15 12:10 ` Reiner Steib
2006-03-15 15:42 ` Bill Wohler
2006-03-15 16:40 ` defvars at compile time (was: New GNOME icons) Reiner Steib
2006-03-15 16:49 ` defvars at compile time Bill Wohler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3861.1142268982@olgas.newt.com \
--to=wohler@newt.com \
--cc=ding@gnus.org \
--cc=mh-e-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).