Re: New agent code

[Kevin Greiner <kgreiner@xpediantsolutions.com>]

Kai Großjohann wrote:

>Kevin Greiner <kgreiner@xpediantsolutions.com> writes:
>
>  
>
>>The intended behavior is as follows:
>>If an article was fetched into the agent's cache, then the article's
>>header will be removed from the overview at the same time as the
>>article is expired.
>>If an article was never fetched, then the article's header will be
>>removed from the overview if the article is marked as read but not
>>marked as ticked nor dormant.
>>If an article is in the overview, but not in the agentview, remove it
>>from the overview.
>>
>>The first rule is probably obvious.  The second rule exists because
>>gnus-agent doesn't currently keep a timestamp on when a header was
>>fetched.  As a result, I can't expire just a header using
>>gnus-agent-expire-days.  The third rule cleans up an overview that has
>>gotten out-of-sync with its agentview.
>>    
>>
>
>Does the rest of the expiry code go by the fetched date or by the
>article date?
>
>Normal (mail) expiry also confuses these two times (date header of
>message; timestamp of nnml file on disk; time when user hits E -- Kai
>can't cound).  So maybe it's not so bad when the agent does the
>same.
>
>But OTOH, if the articles are expired by elapsed time since
>fetching and the headers are expired by elapsed time since their
>date, that would be strange.
>
>Hm.
>
>  
>
Actually, there is no elapse time on the headers.  If you fetch an 
article then the article and header are expired after the elapse time 
since fetching.  If you have just the header, it can be expired as soon 
as it has been read.  My thoughts were that you would only expire a 
group when recovering disk space outweighed the deletion of read 
headers.  Of course, those headers could still be recovered by 
refetching the headers from the server.

I just took a look back at the gnus-agent-expire prior to my changes. 
 The code is rather convoluted.  It is quite possible that NOV entries 
were only expirable if you had first fetched the article. It appears 
that if you had fetched the article AND the expiration elapse time was 
reached, the NOV entries would be deleted when any of the following were 
true.

    1) the article ID preceded the current active range
    2) gnus-agent-expire-all is set
    3) The article is read and not marked as ticked or dormant.

I suspect that this behavior is probably close to being acceptable. 
 From what I've seen in the preceding posts, some people are seeing a 
different behavior.  One that is not intended.  I'm just going to need 
more information before I can nail down what is wrong.

BTW,  I'm going to be offline until the 30th or 31st so please be 
patient with me.

Kevin