From: "Jan Djärv" <jan.h.d@swipnet.se>
To: Reiner Steib <Reiner.Steib@gmx.de>
Cc: ding@gnus.org, emacs-devel@gnu.org
Subject: Re: Gtk+ stock tool bar icons
Date: Sat, 29 Sep 2007 18:29:56 +0200 [thread overview]
Message-ID: <46FE7D84.4000503@swipnet.se> (raw)
In-Reply-To: <v9ir5tk2jy.fsf@marauder.physik.uni-ulm.de>
Reiner Steib skrev:
> Hi,
Hi.
> What is better:
>
> (a) A consistent icons style within Emacs (like in Emacs 22.1)
>
> or
>
> (b) Consistent icons between the (Gnome) desktop environment and parts
> of (GTK-) Emacs and inconsistent icons within several tool bars in
> Emacs. See the screen shots on [4].
>
I prefer (b), but then I am often a Gnome user. An occational icon that isn't
from the proper theme happens with other Gnome applications as well, depending
on the theme used.
> Some related questions:
>
> - Is (setq x-gtk-stock-map nil) the recommended way to disable themed
> icons? Shouldn't we provide this as a custom option (also in Emacs
> trunk) and mention it in NEWS? (BTW, the custom version should read
> 22.2 if we keep it in EMACS_22_BASE, shouldn't it?)
The custom version should indeed be 22.2, I've fixed that. If you think we
need another customize option to disable this, please feel free to add it.
>
> - Is my patch [3] correct?
No, the files should be "images/mail/...".
>
> - For Gnus, we have at least two icons where no corresponding
> Gnome/GTK icon was (is) available. How can we should we deal with
> this? (Probably the same is relevant for prev-node, next-node and
> up-node?)
>
> mail/preview.xpm (combining stock_mail and stock_zoom)
> mail/save.xpm (combining stock_mail, stock_save and stock_convert)
There will always be icons that don't correspond to stock or theme icons.
There are themes out there that don't have a complete set of icons for all
purposes also.
>
> - How is possible to try different icon styles for non-Gnome user?
AFAIK, it isn't.
Jan D.
>
> Bye, Reiner.
>
> [1] Maybe I missed some discussion on emacs-devel as I was on vacation.
>
> [2] Info mode is only partially updated. Previous, Next and Up node
> have un-themed icons.
>
> [3]
> --8<---------------cut here---------------start------------->8---
> --- x-win.el 23 Sep 2007 18:33:46 +0200 1.210
> +++ x-win.el 29 Sep 2007 15:18:32 +0200
> @@ -2587,7 +2587,43 @@
> ("etc/images/jump-to" . "gtk-jump-to")
> ("etc/images/index" . "gtk-index")
> ("etc/images/search" . "gtk-find")
> - ("etc/images/exit" . "gtk-quit"))
> + ("etc/images/exit" . "gtk-quit")
> + ;; Used in MH-E and/or Gnus:
> + ("etc/images/attach.xpm" . "gtk-attach")
> + ("etc/images/connect.xpm" . "gtk-connect")
> + ("etc/images/contact.xpm" . "gtk-contact")
> + ("etc/images/delete.xpm" . "gtk-delete")
> + ("etc/images/describe.xpm" . "gtk-properties")
> + ("etc/images/disconnect.xpm" . "gtk-disconnect")
> + ;; ("etc/images/exit.xpm" . "gtk-exit")
> + ("etc/images/lock-broken.xpm" . "gtk-lock_broken")
> + ("etc/images/lock-ok.xpm" . "gtk-lock_ok")
> + ("etc/images/lock.xpm" . "gtk-lock")
> + ("etc/images/next-page.xpm" . "gtk-next-page")
> + ("etc/images/refresh.xpm" . "gtk-refresh")
> + ("etc/images/sort-ascending.xpm" . "gtk-sort-ascending")
> + ("etc/images/sort-column-ascending.xpm" . "gtk-sort-column-ascending")
> + ("etc/images/sort-criteria.xpm" . "gtk-sort-criteria")
> + ("etc/images/sort-descending.xpm" . "gtk-sort-descending")
> + ("etc/images/sort-row-ascending.xpm" . "gtk-sort-row-ascending")
> + ("etc/images/gnus/toggle-subscription.xpm" . "gtk-task-recurring")
> + ("etc/images/mail/compose.xpm" . "gtk-mail-compose")
> + ("etc/images/mail/copy.xpm" . "gtk-mail-copy")
> + ("etc/images/mail/forward.xpm" . "gtk-mail-forward")
> + ("etc/images/mail/inbox.xpm" . "gtk-inbox")
> + ("etc/images/mail/move.xpm" . "gtk-mail-move")
> + ("etc/images/mail/not-spam.xpm" . "gtk-not-spam")
> + ("etc/images/mail/outbox.xpm" . "gtk-outbox")
> + ("etc/images/mail/reply-all.xpm" . "gtk-mail-reply-to-all")
> + ("etc/images/mail/reply.xpm" . "gtk-mail-reply")
> + ("etc/images/mail/save-draft.xpm" . "gtk-mail-handling")
> + ("etc/images/mail/send.xpm" . "gtk-mail-send")
> + ("etc/images/mail/spam.xpm" . "gtk-spam")
> + ;; No themed versions available:
> + ;; mail/preview.xpm (combining stock_mail and stock_zoom)
> + ;; mail/save.xpm (combining stock_mail, stock_save and stock_convert)
> + ;;
> + )
> "How icons for tool bars are mapped to Gtk+ stock items.
> Emacs must be compiled with the Gtk+ toolkit for this to have any effect.
> A value that begins with n: denotes a named icon instead of a stock icon."
> --8<---------------cut here---------------end--------------->8---
>
> [4] Screen shots of Gnus on openSUSE 10.2 using fluxbox:
> <http://theotp1.physik.uni-ulm.de/~ste/comp/emacs/gnus/tool-bar/gtk-stock-map/>
>
> $ rpm -qa|grep -Ee '-icon|-theme'|sort
> gnome-icon-theme-2.16.0.1-12
> gnome-themes-2.16.1.1-21
> gtk2-themes-0.1-671
> tango-icon-theme-0.7.2-36
next prev parent reply other threads:[~2007-09-29 16:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-29 13:45 Reiner Steib
2007-09-29 16:29 ` Jan Djärv [this message]
2007-09-29 19:55 ` Reiner Steib
2007-09-30 9:40 ` Jan Djärv
2007-09-30 11:25 ` Reiner Steib
2007-09-30 3:04 ` Richard Stallman
2007-09-30 9:41 ` Jan Djärv
2007-09-30 10:48 ` Reiner Steib
2007-10-01 1:36 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46FE7D84.4000503@swipnet.se \
--to=jan.h.d@swipnet.se \
--cc=Reiner.Steib@gmx.de \
--cc=ding@gnus.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).