From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/65291 Path: news.gmane.org!not-for-mail From: =?ISO-8859-1?Q?Jan_Dj=E4rv?= Newsgroups: gmane.emacs.devel,gmane.emacs.gnus.general Subject: Re: Gtk+ stock tool bar icons Date: Sat, 29 Sep 2007 18:29:56 +0200 Message-ID: <46FE7D84.4000503@swipnet.se> References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1191083437 9492 80.91.229.12 (29 Sep 2007 16:30:37 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 29 Sep 2007 16:30:37 +0000 (UTC) Cc: ding@gnus.org, emacs-devel@gnu.org To: Reiner Steib Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Sep 29 18:30:32 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IbfD1-0006qD-UO for ged-emacs-devel@m.gmane.org; Sat, 29 Sep 2007 18:30:28 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IbfCy-0000se-3J for ged-emacs-devel@m.gmane.org; Sat, 29 Sep 2007 12:30:24 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IbfCv-0000sR-OZ for emacs-devel@gnu.org; Sat, 29 Sep 2007 12:30:21 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IbfCu-0000sF-Vr for emacs-devel@gnu.org; Sat, 29 Sep 2007 12:30:21 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IbfCu-0000sC-SS for emacs-devel@gnu.org; Sat, 29 Sep 2007 12:30:20 -0400 Original-Received: from av6-2-sn3.vrr.skanova.net ([81.228.9.180]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IbfCu-0000GG-EW for emacs-devel@gnu.org; Sat, 29 Sep 2007 12:30:20 -0400 Original-Received: by av6-2-sn3.vrr.skanova.net (Postfix, from userid 502) id 8586F37F43; Sat, 29 Sep 2007 18:30:19 +0200 (CEST) Original-Received: from smtp3-2-sn3.vrr.skanova.net (smtp3-2-sn3.vrr.skanova.net [81.228.9.102]) by av6-2-sn3.vrr.skanova.net (Postfix) with ESMTP id 6F00237E88; Sat, 29 Sep 2007 18:30:19 +0200 (CEST) Original-Received: from husetbladh.homeip.net (90-231-102-24-no59.tbcn.telia.com [90.231.102.24]) by smtp3-2-sn3.vrr.skanova.net (Postfix) with ESMTP id 3194337E47; Sat, 29 Sep 2007 18:30:19 +0200 (CEST) User-Agent: Thunderbird 2.0.0.6 (Macintosh/20070728) In-Reply-To: X-Detected-Kernel: Linux 2.4-2.6 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:80023 gmane.emacs.gnus.general:65291 Archived-At: Reiner Steib skrev: > Hi, Hi. > What is better: > > (a) A consistent icons style within Emacs (like in Emacs 22.1) > > or > > (b) Consistent icons between the (Gnome) desktop environment and parts > of (GTK-) Emacs and inconsistent icons within several tool bars in > Emacs. See the screen shots on [4]. > I prefer (b), but then I am often a Gnome user. An occational icon that isn't from the proper theme happens with other Gnome applications as well, depending on the theme used. > Some related questions: > > - Is (setq x-gtk-stock-map nil) the recommended way to disable themed > icons? Shouldn't we provide this as a custom option (also in Emacs > trunk) and mention it in NEWS? (BTW, the custom version should read > 22.2 if we keep it in EMACS_22_BASE, shouldn't it?) The custom version should indeed be 22.2, I've fixed that. If you think we need another customize option to disable this, please feel free to add it. > > - Is my patch [3] correct? No, the files should be "images/mail/...". > > - For Gnus, we have at least two icons where no corresponding > Gnome/GTK icon was (is) available. How can we should we deal with > this? (Probably the same is relevant for prev-node, next-node and > up-node?) > > mail/preview.xpm (combining stock_mail and stock_zoom) > mail/save.xpm (combining stock_mail, stock_save and stock_convert) There will always be icons that don't correspond to stock or theme icons. There are themes out there that don't have a complete set of icons for all purposes also. > > - How is possible to try different icon styles for non-Gnome user? AFAIK, it isn't. Jan D. > > Bye, Reiner. > > [1] Maybe I missed some discussion on emacs-devel as I was on vacation. > > [2] Info mode is only partially updated. Previous, Next and Up node > have un-themed icons. > > [3] > --8<---------------cut here---------------start------------->8--- > --- x-win.el 23 Sep 2007 18:33:46 +0200 1.210 > +++ x-win.el 29 Sep 2007 15:18:32 +0200 > @@ -2587,7 +2587,43 @@ > ("etc/images/jump-to" . "gtk-jump-to") > ("etc/images/index" . "gtk-index") > ("etc/images/search" . "gtk-find") > - ("etc/images/exit" . "gtk-quit")) > + ("etc/images/exit" . "gtk-quit") > + ;; Used in MH-E and/or Gnus: > + ("etc/images/attach.xpm" . "gtk-attach") > + ("etc/images/connect.xpm" . "gtk-connect") > + ("etc/images/contact.xpm" . "gtk-contact") > + ("etc/images/delete.xpm" . "gtk-delete") > + ("etc/images/describe.xpm" . "gtk-properties") > + ("etc/images/disconnect.xpm" . "gtk-disconnect") > + ;; ("etc/images/exit.xpm" . "gtk-exit") > + ("etc/images/lock-broken.xpm" . "gtk-lock_broken") > + ("etc/images/lock-ok.xpm" . "gtk-lock_ok") > + ("etc/images/lock.xpm" . "gtk-lock") > + ("etc/images/next-page.xpm" . "gtk-next-page") > + ("etc/images/refresh.xpm" . "gtk-refresh") > + ("etc/images/sort-ascending.xpm" . "gtk-sort-ascending") > + ("etc/images/sort-column-ascending.xpm" . "gtk-sort-column-ascending") > + ("etc/images/sort-criteria.xpm" . "gtk-sort-criteria") > + ("etc/images/sort-descending.xpm" . "gtk-sort-descending") > + ("etc/images/sort-row-ascending.xpm" . "gtk-sort-row-ascending") > + ("etc/images/gnus/toggle-subscription.xpm" . "gtk-task-recurring") > + ("etc/images/mail/compose.xpm" . "gtk-mail-compose") > + ("etc/images/mail/copy.xpm" . "gtk-mail-copy") > + ("etc/images/mail/forward.xpm" . "gtk-mail-forward") > + ("etc/images/mail/inbox.xpm" . "gtk-inbox") > + ("etc/images/mail/move.xpm" . "gtk-mail-move") > + ("etc/images/mail/not-spam.xpm" . "gtk-not-spam") > + ("etc/images/mail/outbox.xpm" . "gtk-outbox") > + ("etc/images/mail/reply-all.xpm" . "gtk-mail-reply-to-all") > + ("etc/images/mail/reply.xpm" . "gtk-mail-reply") > + ("etc/images/mail/save-draft.xpm" . "gtk-mail-handling") > + ("etc/images/mail/send.xpm" . "gtk-mail-send") > + ("etc/images/mail/spam.xpm" . "gtk-spam") > + ;; No themed versions available: > + ;; mail/preview.xpm (combining stock_mail and stock_zoom) > + ;; mail/save.xpm (combining stock_mail, stock_save and stock_convert) > + ;; > + ) > "How icons for tool bars are mapped to Gtk+ stock items. > Emacs must be compiled with the Gtk+ toolkit for this to have any effect. > A value that begins with n: denotes a named icon instead of a stock icon." > --8<---------------cut here---------------end--------------->8--- > > [4] Screen shots of Gnus on openSUSE 10.2 using fluxbox: > > > $ rpm -qa|grep -Ee '-icon|-theme'|sort > gnome-icon-theme-2.16.0.1-12 > gnome-themes-2.16.1.1-21 > gtk2-themes-0.1-671 > tango-icon-theme-0.7.2-36