From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/65296 Path: news.gmane.org!not-for-mail From: =?ISO-8859-1?Q?Jan_Dj=E4rv?= Newsgroups: gmane.emacs.devel,gmane.emacs.gnus.general Subject: Re: Gtk+ stock tool bar icons Date: Sun, 30 Sep 2007 11:40:19 +0200 Message-ID: <46FF6F03.1080509@swipnet.se> References: <46FE7D84.4000503@swipnet.se> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable X-Trace: sea.gmane.org 1191145300 14621 80.91.229.12 (30 Sep 2007 09:41:40 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 30 Sep 2007 09:41:40 +0000 (UTC) To: =?ISO-8859-1?Q?Jan_Dj=E4rv?= , ding@gnus.org, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Sep 30 11:41:37 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IbvIv-0002Uf-1P for ged-emacs-devel@m.gmane.org; Sun, 30 Sep 2007 11:41:37 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IbvIr-0008N9-6C for ged-emacs-devel@m.gmane.org; Sun, 30 Sep 2007 05:41:33 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IbvIb-00087T-Cn for emacs-devel@gnu.org; Sun, 30 Sep 2007 05:41:17 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IbvIZ-000865-3z for emacs-devel@gnu.org; Sun, 30 Sep 2007 05:41:16 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IbvIY-00085p-To for emacs-devel@gnu.org; Sun, 30 Sep 2007 05:41:14 -0400 Original-Received: from av10-2-sn2.hy.skanova.net ([81.228.8.182]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IbvIY-0005Z1-CU for emacs-devel@gnu.org; Sun, 30 Sep 2007 05:41:14 -0400 Original-Received: by av10-2-sn2.hy.skanova.net (Postfix, from userid 502) id 3469E37F5F; Sun, 30 Sep 2007 11:41:13 +0200 (CEST) Original-Received: from smtp4-1-sn2.hy.skanova.net (smtp4-1-sn2.hy.skanova.net [81.228.8.92]) by av10-2-sn2.hy.skanova.net (Postfix) with ESMTP id F18E937F5F; Sun, 30 Sep 2007 11:41:12 +0200 (CEST) Original-Received: from husetbladh.homeip.net (90-231-102-24-no59.tbcn.telia.com [90.231.102.24]) by smtp4-1-sn2.hy.skanova.net (Postfix) with ESMTP id BAC9137E43; Sun, 30 Sep 2007 11:41:12 +0200 (CEST) User-Agent: Thunderbird 2.0.0.6 (Macintosh/20070728) In-Reply-To: X-Detected-Kernel: Linux 2.4-2.6 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:80044 gmane.emacs.gnus.general:65296 Archived-At: Reiner Steib skrev: > On Sat, Sep 29 2007, Jan Dj=E4rv wrote: >=20 >> Reiner Steib skrev: >>> - Is (setq x-gtk-stock-map nil) the recommended way to disable themed >>> icons? Shouldn't we provide this as a custom option (also in Emacs >>> trunk) and mention it in NEWS? (BTW, the custom version should rea= d >>> 22.2 if we keep it in EMACS_22_BASE, shouldn't it?) >> The custom version should indeed be 22.2, I've fixed that. If you thi= nk we >> need another customize option to disable this, please feel free to add= it. >=20 > On a second thought: Maybe `icon-map-list' seems more suitable to > disable it. How about making it `icon-map-list' customizable and > improving the custom type of `x-gtk-stock-map' as follows? Ok with me. >=20 >>> - Is my patch [3] correct? >> No, the files should be "images/mail/...". >=20 > Are you saying without "etc/"? I did it exactly like the present > elements: Yes I know. But the document string says "file names without extension a= nd=20 with two directory components". The reason for this is to avoid having t= o=20 search the image path first and then do the translation. Also, two is en= ough=20 to distinguish the default setup. >=20 > ("etc/images/search" . "gtk-find") > - ("etc/images/exit" . "gtk-quit")) > + ("etc/images/exit" . "gtk-quit") > + ;; Used in MH-E and/or Gnus: > + ("etc/images/attach.xpm" . "gtk-attach") > + ("etc/images/connect.xpm" . "gtk-connect") >=20 > BTW, wouldn't it be better to strip "etc/images/" in the icon names > for consistency with the specification of the icons e.g. in > `tool-bar-add-item-from-menu' (cf. `image-load-path')? >=20 I guess that would work also. I'll fix that. Jan D.