Possible SpamAssassin node info documentation error.

Possible SpamAssassin node info documentation error.

[Rob Browning]

In the current info pages (for 5.10.2), in the "SpamAssassin, Vipul's
Razor, DCC, etc" node, it suggests:

     (defun kevin-spamassassin ()
       (save-excursion
         (let ((buf (or (get-buffer " *nnmail incoming*")
                        (get-buffer " *nnml move*"))))
           (if (not buf)
               (progn (message "Oops, cannot find message buffer") nil)
             (set-buffer buf)
             (if (eq 1 (call-process-region (point-min) (point-max)
                                            "spamc" nil nil nil "-c"))
                 "spam")))))

but my experience is that this doesn't actually work because the
buffer (at least during a "B q") is narrowed to the headers.  For this
to work as advertized, you need to add a (widen) after setting the
buffer, perhaps like this (also happen to be using spamassassin in
this example rather than spamc):

     (defun kevin-spamassassin ()
       (save-excursion
         (let ((buf (or (get-buffer " *nnmail incoming*")
                        (get-buffer " *nnml move*")
                        ;; probably just respooling or tracing...
                        (set-buffer gnus-original-article-buffer))))
           (if (not buf)
               (progn (message "Oops, cannot find message buffer") nil)
             (set-buffer buf)
             (widen)
             (if (zerop (call-process-region (point-min) (point-max)
                                             "spamassassin" nil nil nil "-e"))
                 nil
               "spam")))))

Hope this helps.
-- 
Rob Browning
rlb @defaultvalue.org and @debian.org; previously @cs.utexas.edu
GPG starting 2002-11-03 = 14DD 432F AE39 534D B592  F9A0 25C8 D377 8C7E 73A4

Re: Possible SpamAssassin node info documentation error.

[Rob Browning]

Rob Browning <rlb@defaultvalue.org> writes:

> but my experience is that this doesn't actually work because the
> buffer (at least during a "B q") is narrowed to the headers.  For this
> to work as advertized, you need to add a (widen) after setting the
> buffer, perhaps like this (also happen to be using spamassassin in
> this example rather than spamc):
>
>      (defun kevin-spamassassin ()
>        (save-excursion

Oops.

NOTE: don't use that function -- that widen is probably *wrong* --
seemed to cause gnus to grab the whole mailbox in one message.

I'm guessing you want something that just widens to include the body
of the current message, whatever that would be.

-- 
Rob Browning
rlb @defaultvalue.org and @debian.org; previously @cs.utexas.edu
GPG starting 2002-11-03 = 14DD 432F AE39 534D B592  F9A0 25C8 D377 8C7E 73A4

Re: Possible SpamAssassin node info documentation error.

[Lars Magne Ingebrigtsen]

Rob Browning <rlb@defaultvalue.org> writes:

> In the current info pages (for 5.10.2), in the "SpamAssassin, Vipul's
> Razor, DCC, etc" node, it suggests:
>
>      (defun kevin-spamassassin ()
>        (save-excursion
>          (let ((buf (or (get-buffer " *nnmail incoming*")
>                         (get-buffer " *nnml move*"))))

In CVS Gnus, it reads:

(defun kevin-spamassassin ()
  (save-excursion
    (widen)
    (if (eq 1 (call-process-region (point-min) (point-max)
				   "spamc" nil nil nil "-c"))
	"spam")))

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: Possible SpamAssassin node info documentation error.

[Ted Zlatanov]

On Wed, 15 Oct 2003, rlb@defaultvalue.org wrote:

> In the current info pages (for 5.10.2), in the "SpamAssassin,
> Vipul's Razor, DCC, etc" node, it suggests:
> 
>      (defun kevin-spamassassin ()
>        (save-excursion
>          (let ((buf (or (get-buffer " *nnmail incoming*")
>                         (get-buffer " *nnml move*"))))
>            (if (not buf)
>                (progn (message "Oops, cannot find message buffer")
>                nil)
>              (set-buffer buf)
>              (if (eq 1 (call-process-region (point-min) (point-max)
>                                             "spamc" nil nil nil
>                                             "-c"))
>                  "spam")))))
> 
> but my experience is that this doesn't actually work because the
> buffer (at least during a "B q") is narrowed to the headers.  For
> this to work as advertized, you need to add a (widen) after setting
> the buffer, perhaps like this (also happen to be using spamassassin
> in this example rather than spamc):
> 
>      (defun kevin-spamassassin ()
>        (save-excursion
>          (let ((buf (or (get-buffer " *nnmail incoming*")
>                         (get-buffer " *nnml move*")
>                         ;; probably just respooling or tracing...
>                         (set-buffer gnus-original-article-buffer))))
>            (if (not buf)
>                (progn (message "Oops, cannot find message buffer")
>                nil)
>              (set-buffer buf)
>              (widen)
>              (if (zerop (call-process-region (point-min) (point-max)
>                                              "spamassassin" nil nil
>                                              nil "-e"))
>                  nil
>                "spam")))))
> 
> Hope this helps.

This was already fixed in the CVS manual.

Thanks
Ted

Re: Possible SpamAssassin node info documentation error.

[Ted Zlatanov]

On Wed, 15 Oct 2003, rlb@defaultvalue.org wrote:

> Rob Browning <rlb@defaultvalue.org> writes:
> 
>> but my experience is that this doesn't actually work because the
>> buffer (at least during a "B q") is narrowed to the headers.  For
>> this to work as advertized, you need to add a (widen) after setting
>> the buffer, perhaps like this (also happen to be using spamassassin
>> in this example rather than spamc):
>>
>>      (defun kevin-spamassassin ()
>>        (save-excursion
> 
> Oops.
> 
> NOTE: don't use that function -- that widen is probably *wrong* --
> seemed to cause gnus to grab the whole mailbox in one message.
> 
> I'm guessing you want something that just widens to include the body
> of the current message, whatever that would be.

(widen) in an incoming message is supposed to just widen to the
message, so this could be a bug.  Can you please submit a bug (it will
tell us your mail backend and other useful information)?  Make sure
you look at the example in the CVS manual, not the one in the 5.10.2
manual.

Thanks
Ted

Re: Possible SpamAssassin node info documentation error.

[Kevin Ryde]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:
>
> (defun kevin-spamassassin ()
>   (save-excursion
>     (widen)

Should there be a save-restriction too, or does gnus not care about
that once it gets to the splitting stage?

Re: Possible SpamAssassin node info documentation error.

[Ted Zlatanov]

On Thu, 04 Dec 2003, user42@zip.com.au wrote:

> Lars Magne Ingebrigtsen <larsi@gnus.org> writes:
>>
>> (defun kevin-spamassassin ()
>>   (save-excursion
>>     (widen)
> 
> Should there be a save-restriction too, or does gnus not care about
> that once it gets to the splitting stage?

I added save-restriction in this example and the other one (in Fancy
Mail Splitting).  Thanks!

Ted