Gnus development mailing list
 help / color / mirror / Atom feed
From: "Ted Zlatanov" <tzz@lifelogs.com>
Cc: ding@gnus.org
Subject: Re: Gnus SPAM support, and email based reporting.
Date: 24 May 2004 09:44:28 -0400	[thread overview]
Message-ID: <4naczyj5xf.fsf@lifelogs.com> (raw)
In-Reply-To: <87d64uaxpg.fsf@enki.rimspace.net> (Daniel Pittman's message of "Mon, 24 May 2004 21:09:15 +1000")

On Mon, 24 May 2004, daniel@rimspace.net wrote:

On 19 May 2004, Ted Zlatanov wrote:

>> I'm planning to do a major overhaul (version 3 of spam.el, so to
>> speak) where a lot of the unnecessary complexity is at least only
>> done once.  Probably by the end of the year.
> 
> It struck me that there was an awful lot of writing of wrapper functions
> around what is, at heart, pipe to command A to learn as spam, or command
> B to learn as ham.
> 
> OTOH, I don't really understand your code so well and I am probably
> missing the reason why a bunch of this complexity exists.

The complexity is necessary to accomodate all the spam detection and
training backends.  BBDB, for instance, is VERY different from
Bogofilter.  Some backends don't detect incoming spam (the reporters),
others don't learn (spam-use-blackholes).  Like I said, I'll try to
simplify it, but the code will have to remain very abstract to handle
all the possible backends.  There will probably be
spam-register-backend which will handle all the various types of
backends.

>> With spam.el, you just make (spam spam-use-resend) the exit
>> processor of the group.  All spam articles will be processed
>> through it.
> 
> That didn't work.  I needed to add to the group parameters:
> 
>     (spam-process (gnus-group-spam-exit-processor-report-resend))
> 
> The other one didn't trigger, for some reason.

Looks like a bug in my code, because
gnus-group-spam-exit-processor-report-resend is supposed to be no
longer necessary.  I'll look today.

> Er, and finally, I think that it would be better to set `defcustom
> spam-report-resend-to' to `nil' by default.
> 
> Then, in the report function we could test that address and if it was
> `nil', display an error to the user and instruct spam.el to mark the
> article as "not processed"
> 
> That seems more user-friendly to me.  Alternately, we could actually
> prompt for the destination and save that with custom, but I don't know
> how to do that - custom is still a mysterious (and probably explosive)
> black box to me. :)

The resend-to address should be a Gnus group/topic variable that
overrides the default spam-report-resend-to, I think.  What do you think?

I applied your bug fix, thanks!

Ted



  parent reply	other threads:[~2004-05-24 13:44 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-04-17 12:40 Daniel Pittman
2004-04-17 15:20 ` Derrell.Lipman
2004-04-21 15:44   ` Ted Zlatanov
2004-04-22  9:10     ` Steinar Bang
     [not found]       ` <87fzawgyxq.fsf-1rLz5CwDoL8@public.gmane.org>
2004-04-22 16:23         ` Jochen Küpper
2004-04-22 20:11           ` Ted Zlatanov
     [not found]             ` <4n1xmfept2.fsf-mIZUurteI1BWk0Htik3J/w@public.gmane.org>
2004-04-22 21:32               ` Jochen Küpper
2004-04-23 16:15                 ` Ted Zlatanov
2004-04-22 18:35       ` Ted Zlatanov
2004-04-23  5:34         ` Steinar Bang
2004-04-23  7:45           ` Daniel Pittman
2004-04-23 16:17           ` Ted Zlatanov
2004-05-15 13:27     ` Daniel Pittman
2004-05-18 20:08       ` Ted Zlatanov
2004-05-24 11:09         ` Daniel Pittman
2004-05-24 11:39           ` Kai Grossjohann
2004-05-24 14:07             ` Daniel Pittman
2004-05-24 14:12               ` Kai Grossjohann
2004-05-26 19:00                 ` Michael Schierl
2004-05-24 13:44           ` Ted Zlatanov [this message]
2004-05-24 14:18             ` Daniel Pittman
2004-05-24 17:40               ` Ted Zlatanov
2004-05-24 18:07                 ` Daniel Pittman
2004-05-24 18:50                   ` Ted Zlatanov
2004-05-24 18:52             ` spam.el processor code refactored (was: Gnus SPAM support, and email based reporting.) Ted Zlatanov
     [not found] ` <87isfy7p6a.fsf-kiwxAyAbAnkGAYDEi5AF0l6hYfS7NtTn@public.gmane.org>
2004-04-18 22:05   ` Gnus SPAM support, and email based reporting Jochen Küpper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4naczyj5xf.fsf@lifelogs.com \
    --to=tzz@lifelogs.com \
    --cc=ding@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).