* Bad defcustom ?
@ 2003-12-04 22:24 Xavier Maillard
2003-12-09 22:54 ` Ted Zlatanov
0 siblings, 1 reply; 5+ messages in thread
From: Xavier Maillard @ 2003-12-04 22:24 UTC (permalink / raw)
[-- Attachment #1: Type: text/plain, Size: 592 bytes --]
Hi,
Dunno If I am right, but look into the code of spam.el revealed this to
me :
(defcustom spam-bogofilter-database-directory nil
"Directory path of the Bogofilter databases."
:type '(choice (directory
:tag "Location of the Bogofilter database directory")
(const :tag "Use the default"))
:group 'spam-ifile)
^^^^^^^^^^
Correct me if I am wrong but I think it would be better to have it in
the right customization group aka 'spam-bogofilter', no ?
If yes, then here is a small patch (my 1st contribution for Gnus :))
Cheers,
zeDek
[-- Attachment #2: Patch --]
[-- Type: application/octet-stream, Size: 366 bytes --]
--- spam.el.orig 2003-12-04 23:22:29.000000000 +0100
+++ spam.el 2003-12-04 23:22:50.000000000 +0100
@@ -374,7 +374,7 @@
:type '(choice (directory
:tag "Location of the Bogofilter database directory")
(const :tag "Use the default"))
- :group 'spam-ifile)
+ :group 'spam-bogofilter)
(defgroup spam-spamoracle nil
"Spam spamoracle configuration."
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Bad defcustom ?
2003-12-04 22:24 Bad defcustom ? Xavier Maillard
@ 2003-12-09 22:54 ` Ted Zlatanov
2003-12-10 0:08 ` Xavier Maillard
2003-12-10 1:03 ` Xavier Maillard
0 siblings, 2 replies; 5+ messages in thread
From: Ted Zlatanov @ 2003-12-09 22:54 UTC (permalink / raw)
On Thu, 04 Dec 2003, zedek@gnu-rox.org wrote:
> (defcustom spam-bogofilter-database-directory nil
[...]
> :group 'spam-ifile)
> ^^^^^^^^^^
>
> Correct me if I am wrong but I think it would be better to have it
> in the right customization group aka 'spam-bogofilter', no ?
Fix committed, thank you.
For future patches (over 10 lines or so), you need to have papers with
the FSF.
Thanks
Ted
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Bad defcustom ?
2003-12-09 22:54 ` Ted Zlatanov
@ 2003-12-10 0:08 ` Xavier Maillard
2003-12-10 1:03 ` Xavier Maillard
1 sibling, 0 replies; 5+ messages in thread
From: Xavier Maillard @ 2003-12-10 0:08 UTC (permalink / raw)
Ted Zlatanov <tzz@lifelogs.com> disait récemment que :
> On Thu, 04 Dec 2003, zedek@gnu-rox.org wrote:
>
>> (defcustom spam-bogofilter-database-directory nil
> [...]
>> :group 'spam-ifile)
>> ^^^^^^^^^^
>>
>> Correct me if I am wrong but I think it would be better to have it
>> in the right customization group aka 'spam-bogofilter', no ?
>
> Fix committed, thank you.
>
> For future patches (over 10 lines or so), you need to have papers with
> the FSF.
Maybe one day... :p
zeDek
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Bad defcustom ?
2003-12-09 22:54 ` Ted Zlatanov
2003-12-10 0:08 ` Xavier Maillard
@ 2003-12-10 1:03 ` Xavier Maillard
2003-12-10 20:07 ` Ted Zlatanov
1 sibling, 1 reply; 5+ messages in thread
From: Xavier Maillard @ 2003-12-10 1:03 UTC (permalink / raw)
Ted Zlatanov <tzz@lifelogs.com> disait récemment que :
> On Thu, 04 Dec 2003, zedek@gnu-rox.org wrote:
>
>> (defcustom spam-bogofilter-database-directory nil
> [...]
>> :group 'spam-ifile)
>> ^^^^^^^^^^
>>
>> Correct me if I am wrong but I think it would be better to have it
>> in the right customization group aka 'spam-bogofilter', no ?
>
> Fix committed, thank you.
>
> For future patches (over 10 lines or so), you need to have papers with
> the FSF.
Hmm, just in case I need it one day, can you tell me how can I
"receive" the famous FSF papers ?
Thank you
zeDek
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Bad defcustom ?
2003-12-10 1:03 ` Xavier Maillard
@ 2003-12-10 20:07 ` Ted Zlatanov
0 siblings, 0 replies; 5+ messages in thread
From: Ted Zlatanov @ 2003-12-10 20:07 UTC (permalink / raw)
On Wed, 10 Dec 2003, zedek@gnu-rox.org wrote:
> Hmm, just in case I need it one day, can you tell me how can I
> "receive" the famous FSF papers ?
Generally, package maintainers deal with that. Either Lars or Kai
sent me the assignment papers years ago. You can also try
assign@gnu.org but I'm not sure if they are the right place.
Ted
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2003-12-10 20:07 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-12-04 22:24 Bad defcustom ? Xavier Maillard
2003-12-09 22:54 ` Ted Zlatanov
2003-12-10 0:08 ` Xavier Maillard
2003-12-10 1:03 ` Xavier Maillard
2003-12-10 20:07 ` Ted Zlatanov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).