[PATCH] spam-stat-save and font-locking

[PATCH] spam-stat-save and font-locking

[Karl Pflästerer]

Hi,
as the wordlist generated with `spam-stat-process-.*' grows I noticed
that the saved file gets font-locked while saving. Not very nice as this
needs some seconds. So I wrote this little patch that sets locally
`font-lock-maximum-size' to 0. So no font-locking happens.

Also I know that we have a feature freeze I send that patch now as I
regard that behaviour as a bug.


Gnus ChangeLog patch:
Diff command:   cvs -q diff -U 0
Files affected: ChangeLog

Index: ChangeLog
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/ChangeLog,v
retrieving revision 6.2289
diff -u -U0 -r6.2289 ChangeLog
--- ChangeLog	27 Apr 2003 12:07:43 -0000	6.2289
+++ ChangeLog	29 Apr 2003 14:56:22 -0000
@@ -0,0 +1,5 @@
+2003-04-29  Karl Pflästerer  <sigurd@12move.de>
+
+	* spam-stat.el (spam-stat-save): No longer font-locks the file
+	when saving
+

Gnus source patch:
Diff command:   cvs -q diff
Files affected: spam-stat.el

Index: spam-stat.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/spam-stat.el,v
retrieving revision 6.9
diff -u -r6.9 spam-stat.el
--- spam-stat.el	8 Feb 2003 21:20:53 -0000	6.9
+++ spam-stat.el	29 Apr 2003 14:54:26 -0000
@@ -398,7 +398,8 @@
   "Save the `spam-stat' hash table as lisp file."
   (interactive)
   (with-temp-buffer
-    (let ((standard-output (current-buffer)))
+    (let ((standard-output (current-buffer))
+	  (font-lock-maximum-size 0))
       (insert "(setq spam-stat-ngood "
               (number-to-string spam-stat-ngood)
               " spam-stat-nbad "
@@ -409,8 +410,8 @@
 			      (spam-stat-good entry)
 			      (spam-stat-bad entry))))
 	       spam-stat)
-      (insert ")))"))
-    (write-file spam-stat-file)))
+      (insert ")))")
+    (write-file spam-stat-file))))
 
 (defun spam-stat-load ()
   "Read the `spam-stat' hash table from disk."


bye
   KP

-- 
"But it has nothing to do with what a _value_ is.  This has to do with
whether you pass whatever-a-value-is or wherever-whatever-is-a-value-is
whenever you pass an argument to a function.  (Call it the Shakira
theory. :)"       [Erik Naggum in cll über call-by-value und call-by-reference]

Re: [PATCH] spam-stat-save and font-locking

[Ted Zlatanov]

On Tue, 29 Apr 2003, sigurd@12move.de wrote:
> Hi, as the wordlist generated with `spam-stat-process-.*' grows I
> noticed that the saved file gets font-locked while saving. Not very
> nice as this needs some seconds. So I wrote this little patch that
> sets locally `font-lock-maximum-size' to 0. So no font-locking
> happens.
> 
> Also I know that we have a feature freeze I send that patch now as I
> regard that behaviour as a bug.

Committed.  This is small enough that you don't need to have papers on
file with the FSF, I believe.

Thanks
Ted

Re: [PATCH] spam-stat-save and font-locking

[Alex Schroeder]

Ted Zlatanov <tzz@lifelogs.com> writes:

>> Also I know that we have a feature freeze I send that patch now as I
>> regard that behaviour as a bug.
>
> Committed.  This is small enough that you don't need to have papers on
> file with the FSF, I believe.

I faintly remember RMS saying that in such cases, a little indication
in the ChangeLog.  For a recent patch I received I added "(tiny
change)" after the email address of the author, using
emacs/lisp/ChangeLog as a model.  Not sure whether Gnus is supposed
to follow suite.

Alex.
-- 
http://www.emacswiki.org/cgi-bin/alex.pl

Re: [PATCH] spam-stat-save and font-locking

[Reiner Steib]

On Fri, May 02 2003, Alex Schroeder wrote:

> Ted Zlatanov <tzz@lifelogs.com> writes:
>> Committed.  This is small enough that you don't need to have papers on
>> file with the FSF, I believe.
>
> I faintly remember RMS saying that in such cases, a little indication
> in the ChangeLog.  For a recent patch I received I added "(tiny
> change)" after the email address of the author, using
> emacs/lisp/ChangeLog as a model.  Not sure whether Gnus is supposed
> to follow suite.

As Gnus is part of Emacs, I guess we should.

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo--- PGP key available via WWW   http://rsteib.home.pages.de/

Re: [PATCH] spam-stat-save and font-locking

[Lars Magne Ingebrigtsen]

Reiner Steib <4.uce.03.r.s@nurfuerspam.de> writes:

> As Gnus is part of Emacs, I guess we should.

Yup.

-- 
(domestic pets only, the antidote for overdose, milk.)
   larsi@gnus.org * Lars Magne Ingebrigtsen