Gnus development mailing list
 help / color / mirror / Atom feed
From: "Ted Zlatanov" <tzz@lifelogs.com>
Subject: Re: spam.el/spam-report.el: Gmane spam reporting broken in No Gnus
Date: 20 Sep 2005 12:38:24 -0400	[thread overview]
Message-ID: <4nek7jk83j.fsf@lifelogs.com> (raw)
In-Reply-To: <v9mzmn61j3.fsf@marauder.physik.uni-ulm.de> (Reiner Steib's message of "Thu, 08 Sep 2005 17:07:44 +0200")

On Thu, 08 Sep 2005, reinersteib+gmane@imap.cc wrote:

> spam reporting for gmane.* groups is broken in the trunk.  Here's a
> minimal setup:
> 
> --8<---------------cut here---------------start------------->8---
> (setq
>  spam-report-gmane-use-article-number nil
>  spam-report-url-ping-function 'spam-report-url-to-file)
>  gnus-parameters '(("^gmane\\."
> 		    (spam-process
> 		     (gnus-group-spam-exit-processor-report-gmane)))))
> (spam-initialize)
> --8<---------------cut here---------------end--------------->8---

Again, sorry for the late response.

Can you try to use (spam spam-use-gmane) instead of
gnus-group-spam-exit-processor-report-gmane?

> To reproduce:
> 
> Enter gmane.emacs.bugs, find a spam article, mark it with `S x', quit
> the group with `q'.
> 
> Expected behavior (*Messages* buffer):
> 
> ,----[ v5-10 branch ]
>| Exiting summary buffer and applying spam rules
>| Registering 1 articles with classification spam, check spam-use-gmane
>| Reporting spam article 3981 to spam.gmane.org...
>| Reporting spam through URL http://spam.gmane.org/gmane.emacs.bugs/12939...
> `----
> 
> Current behavior (*Messages* buffer):
> 
> ,----[ No Gnus ]
>| Exiting summary buffer and applying spam rules
>| Registering 1 specific articles as spam using backend spam-use-move
>| 1 spam messages were registered by backend spam-use-move.
> `----
> 
> It's an NNTP group, so "move" makes no sense.  

By default we do spam-use-move (to move spam out of the group, if
there are spam-process-destinations) and it knows that if a group is
read-only, a copy should be done instead.

> No report URL is put into `spam-report-requests-file'.  The function
> `spam-report-gmane' is not called at all.
> 
> I guess the problem is related to the changes WRT
> `spam-summary-exit-behavior' and `spam-group-processor-p'.  But I
> don't grok how it's supposed to work.
> 
> I found out, that the Gmane entry has been removed from
> `spam-list-of-processors' ("The OBSOLETE `spam-list-of-processors'
> list."), but re-adding it didn't help:
> 
> --8<---------------cut here---------------start------------->8---
> --- spam.el	26 Aug 2005 14:10:04 +0200	7.72
> +++ spam.el	08 Sep 2005 16:13:37 +0200	
> @@ -1237,7 +1237,8 @@
>  
>  (defvar spam-list-of-processors
>    ;; note the nil processors are not defined in gnus.el
> - '((gnus-group-spam-exit-processor-bogofilter spam spam-use-bogofilter)
> +  '((gnus-group-spam-exit-processor-report-gmane spam spam-use-gmane)
> +    (gnus-group-spam-exit-processor-bogofilter   spam spam-use-bogofilter)
>      (gnus-group-spam-exit-processor-bsfilter	 spam spam-use-bsfilter)
>      (gnus-group-spam-exit-processor-blacklist    spam spam-use-blacklist)
>      (gnus-group-spam-exit-processor-ifile        spam spam-use-ifile)
> --8<---------------cut here---------------end--------------->8---

If you can test as I showed above, that would help me determine if the
bug is in the Gmane reporting or just the backwards compatibility.

Thanks
Ted



  reply	other threads:[~2005-09-20 16:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-09-08 15:07 Reiner Steib
2005-09-20 16:38 ` Ted Zlatanov [this message]
2005-09-20 18:19   ` Reiner Steib
2005-09-21 14:45     ` Ted Zlatanov
2005-09-21 16:51       ` Reiner Steib
2005-09-22 12:20         ` Reiner Steib
2005-10-04 18:18           ` Ted Zlatanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4nek7jk83j.fsf@lifelogs.com \
    --to=tzz@lifelogs.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).