Re: spam.el not moving ham message from spam group

[Ted Zlatanov <tzz@lifelogs.com>]

On Mon, 27 Jan 2003, gnus@myrkr.in-berlin.de wrote:
> Niklas Morberg <niklas.morberg@axis.com> writes:
> 
> [...]
> 
>> It's very easy to reproduce:
>>
>> Move any ham message to the spam group
>> Go to the spam group, mark the message as read
>> Exit spam group
>> Ham message has not been moved.
> 
> Yesterday I reported a bug regarding the same problem.  Here is the
> patch I included:
> 
> --- /home/torsten/CVS/gnus/lisp/spam.el 2003-01-24
>     18:47:41.000000000 +0100
> +++ lisp/spam.el        2003-01-26 12:46:55.000000000 +0100
> @@ -408,7 +408,7 @@
>  
>      (while articles
>        (setq article (pop articles))
> -      (when (and (memq mark ham-mark-values)
> +      (when (and (memq (gnus-summary-article-mark article)
> +      ham-mark-values)
>                  (stringp group))
>           (let ((gnus-current-article article))
>             (gnus-summary-move-article nil group))))))
> 
> The function patched is spam-ham-move-routine.

I was just testing that (thanks for the patch!).  There's one more bug
here I want to resolve before committing.

Now, the *first* article is processed OK, but the others are left
behind.  Very strange.  This is the current spam-ham-move-routine:

(defun spam-ham-move-routine (&optional group)
  (let ((articles gnus-newsgroup-articles)
	article ham-mark-values mark)

    (dolist (mark spam-ham-marks)
      (push (symbol-value mark) ham-mark-values))
    
    (dolist (article articles)
      (when (and (memq (gnus-summary-article-mark article) ham-mark-values)
		 (stringp group))
	(let ((gnus-current-article article))
	  (gnus-summary-move-article nil group))))))

Using debug statements shows nothing wrong.  Doing the
gnus-summary-move-article on each article in turn works OK.  But when
the function is run on its own, it only processes the first article in
the articles list.

I'm very puzzled.

Ted