From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/49677 Path: main.gmane.org!not-for-mail From: Ted Zlatanov Newsgroups: gmane.emacs.gnus.general Subject: Re: spam.el not moving ham message from spam group Date: Mon, 27 Jan 2003 14:37:03 -0500 Organization: =?koi8-r?q?=F4=C5=CF=C4=CF=D2=20=FA=CC=C1=D4=C1=CE=CF=D7?= @ Cienfuegos Sender: owner-ding@hpc.uh.edu Message-ID: <4nel6yv0yo.fsf@lockgroove.bwh.harvard.edu> References: <4nadhq1mzq.fsf@lockgroove.bwh.harvard.edu> <87r8aywgpy.fsf@myrkr.in-berlin.de> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: main.gmane.org 1043696188 12927 80.91.224.249 (27 Jan 2003 19:36:28 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Mon, 27 Jan 2003 19:36:28 +0000 (UTC) Cc: ding@gnus.org Return-path: Original-Received: from malifon.math.uh.edu ([129.7.128.13]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 18dF3R-0003M3-00 for ; Mon, 27 Jan 2003 20:36:26 +0100 Original-Received: from sina.hpc.uh.edu ([129.7.128.10] ident=lists) by malifon.math.uh.edu with esmtp (Exim 3.20 #1) id 18dF4P-0006Cj-00; Mon, 27 Jan 2003 13:37:25 -0600 Original-Received: by sina.hpc.uh.edu (TLB v0.09a (1.20 tibbs 1996/10/09 22:03:07)); Mon, 27 Jan 2003 13:38:22 -0600 (CST) Original-Received: from sclp3.sclp.com (sclp3.sclp.com [66.230.238.2]) by sina.hpc.uh.edu (8.9.3/8.9.3) with SMTP id NAA13831 for ; Mon, 27 Jan 2003 13:38:09 -0600 (CST) Original-Received: (qmail 5823 invoked by alias); 27 Jan 2003 19:37:07 -0000 Original-Received: (qmail 5818 invoked from network); 27 Jan 2003 19:37:07 -0000 Original-Received: from clifford.bwh.harvard.edu (134.174.9.41) by 66.230.238.6 with SMTP; 27 Jan 2003 19:37:07 -0000 Original-Received: from lockgroove.bwh.harvard.edu (lockgroove [134.174.9.133]) by clifford.bwh.harvard.edu (8.10.2+Sun/8.11.0) with ESMTP id h0RJb5W15917; Mon, 27 Jan 2003 14:37:05 -0500 (EST) Original-Received: (from tzz@localhost) by lockgroove.bwh.harvard.edu (8.11.6+Sun/8.11.0) id h0RJb3U27020; Mon, 27 Jan 2003 14:37:03 -0500 (EST) Original-To: Torsten Hilbrich X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6;d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Mail-Followup-To: Torsten Hilbrich , ding@gnus.org In-Reply-To: <87r8aywgpy.fsf@myrkr.in-berlin.de> (Torsten Hilbrich's message of "Mon, 27 Jan 2003 20:11:21 +0100") User-Agent: Gnus/5.090015 (Oort Gnus v0.15) Emacs/21.2 (sparc-sun-solaris2.8) Precedence: list X-Majordomo: 1.94.jlt7 Xref: main.gmane.org gmane.emacs.gnus.general:49677 X-Report-Spam: http://spam.gmane.org/gmane.emacs.gnus.general:49677 On Mon, 27 Jan 2003, gnus@myrkr.in-berlin.de wrote: > Niklas Morberg writes: > > [...] > >> It's very easy to reproduce: >> >> Move any ham message to the spam group >> Go to the spam group, mark the message as read >> Exit spam group >> Ham message has not been moved. > > Yesterday I reported a bug regarding the same problem. Here is the > patch I included: > > --- /home/torsten/CVS/gnus/lisp/spam.el 2003-01-24 > 18:47:41.000000000 +0100 > +++ lisp/spam.el 2003-01-26 12:46:55.000000000 +0100 > @@ -408,7 +408,7 @@ > > (while articles > (setq article (pop articles)) > - (when (and (memq mark ham-mark-values) > + (when (and (memq (gnus-summary-article-mark article) > + ham-mark-values) > (stringp group)) > (let ((gnus-current-article article)) > (gnus-summary-move-article nil group)))))) > > The function patched is spam-ham-move-routine. I was just testing that (thanks for the patch!). There's one more bug here I want to resolve before committing. Now, the *first* article is processed OK, but the others are left behind. Very strange. This is the current spam-ham-move-routine: (defun spam-ham-move-routine (&optional group) (let ((articles gnus-newsgroup-articles) article ham-mark-values mark) (dolist (mark spam-ham-marks) (push (symbol-value mark) ham-mark-values)) (dolist (article articles) (when (and (memq (gnus-summary-article-mark article) ham-mark-values) (stringp group)) (let ((gnus-current-article article)) (gnus-summary-move-article nil group)))))) Using debug statements shows nothing wrong. Doing the gnus-summary-move-article on each article in turn works OK. But when the function is run on its own, it only processes the first article in the articles list. I'm very puzzled. Ted