From: Ted Zlatanov <tzz@lifelogs.com>
Subject: Re: spam.el mega patch
Date: Tue, 25 Nov 2003 13:26:30 -0500 [thread overview]
Message-ID: <4nn0ak5mp5.fsf@lockgroove.bwh.harvard.edu> (raw)
In-Reply-To: <v9zneksflb.fsf@marauder.physik.uni-ulm.de> (Reiner Steib's message of "Tue, 25 Nov 2003 15:11:28 +0100")
On Tue, 25 Nov 2003, 4.uce.03.r.s@nurfuerspam.de wrote:
On Mon, Nov 24 2003, Ted Zlatanov wrote:
>
>> ;;;; Spam-report glue
>> -(defun spam-report-gmane-register-routine ()
>> - (spam-generic-register-routine
>> - 'spam-report-gmane
>> - nil))
>> +(defun spam-report-gmane-register-routine (articles)
>> + (apply 'spam-report-gmane articles))
>
> `apply' fails here when `articles' is nil:
> I don't know what's better: Calling `spam-report-gmane' only if
> `articles' is non-nil[1], making `articles' in `spam-report-gmane'
> optional[2] or use something else (what?) instead of `apply'.
I don't call apply if articles is nil - that's the most sensible
approach. Thanks.
Since the mega-patch has been stable, I'll commit it to CVS. Thanks
for your help with debugging it.
Ted
prev parent reply other threads:[~2003-11-25 18:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-11-23 6:04 Ted Zlatanov
2003-11-23 13:38 ` Ted Zlatanov
2003-11-24 12:46 ` Reiner Steib
2003-11-24 16:12 ` Ted Zlatanov
2003-11-25 14:11 ` Reiner Steib
2003-11-25 18:26 ` Ted Zlatanov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4nn0ak5mp5.fsf@lockgroove.bwh.harvard.edu \
--to=tzz@lifelogs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).