From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/54943 Path: main.gmane.org!not-for-mail From: Ted Zlatanov Newsgroups: gmane.emacs.gnus.general Subject: Re: spam.el mega patch Date: Tue, 25 Nov 2003 13:26:30 -0500 Organization: =?koi8-r?q?=F4=C5=CF=C4=CF=D2=20=FA=CC=C1=D4=C1=CE=CF=D7?= @ Cienfuegos Sender: ding-owner@lists.math.uh.edu Message-ID: <4nn0ak5mp5.fsf@lockgroove.bwh.harvard.edu> References: <4n7k1rsjry.fsf@lockgroove.bwh.harvard.edu> <4n3ccfryr4.fsf@lockgroove.bwh.harvard.edu> <4nr7zxeoeg.fsf@lockgroove.bwh.harvard.edu> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1069784907 20952 80.91.224.253 (25 Nov 2003 18:28:27 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 25 Nov 2003 18:28:27 +0000 (UTC) Original-X-From: ding-owner+M3483@lists.math.uh.edu Tue Nov 25 19:28:24 2003 Return-path: Original-Received: from malifon.math.uh.edu ([129.7.128.13]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1AOhvE-0003t9-00 for ; Tue, 25 Nov 2003 19:28:24 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by malifon.math.uh.edu with smtp (Exim 3.20 #1) id 1AOhug-0007kZ-00; Tue, 25 Nov 2003 12:27:50 -0600 Original-Received: from justine.libertine.org ([66.139.78.221] ident=postfix) by malifon.math.uh.edu with esmtp (Exim 3.20 #1) id 1AOhub-0007kU-00 for ding@lists.math.uh.edu; Tue, 25 Nov 2003 12:27:45 -0600 Original-Received: from clifford.bwh.harvard.edu (clifford.bwh.harvard.edu [134.174.9.41]) by justine.libertine.org (Postfix) with ESMTP id B8E0D3A0068 for ; Tue, 25 Nov 2003 12:27:44 -0600 (CST) Original-Received: from lockgroove.bwh.harvard.edu (lockgroove [134.174.9.133]) by clifford.bwh.harvard.edu (8.10.2+Sun/8.11.0) with ESMTP id hAPIR1700893 for ; Tue, 25 Nov 2003 13:27:02 -0500 (EST) Original-Received: (from tzz@localhost) by lockgroove.bwh.harvard.edu (8.11.6+Sun/8.11.0) id hAPIQUY10604; Tue, 25 Nov 2003 13:26:30 -0500 (EST) Original-To: ding@gnus.org X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6;d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Mail-Followup-To: ding@gnus.org In-Reply-To: (Reiner Steib's message of "Tue, 25 Nov 2003 15:11:28 +0100") User-Agent: Gnus/5.1003 (Gnus v5.10.3) Emacs/21.3.50 (usg-unix-v) Precedence: bulk Xref: main.gmane.org gmane.emacs.gnus.general:54943 X-Report-Spam: http://spam.gmane.org/gmane.emacs.gnus.general:54943 On Tue, 25 Nov 2003, 4.uce.03.r.s@nurfuerspam.de wrote: On Mon, Nov 24 2003, Ted Zlatanov wrote: > >> ;;;; Spam-report glue >> -(defun spam-report-gmane-register-routine () >> - (spam-generic-register-routine >> - 'spam-report-gmane >> - nil)) >> +(defun spam-report-gmane-register-routine (articles) >> + (apply 'spam-report-gmane articles)) > > `apply' fails here when `articles' is nil: > I don't know what's better: Calling `spam-report-gmane' only if > `articles' is non-nil[1], making `articles' in `spam-report-gmane' > optional[2] or use something else (what?) instead of `apply'. I don't call apply if articles is nil - that's the most sensible approach. Thanks. Since the mega-patch has been stable, I'll commit it to CVS. Thanks for your help with debugging it. Ted