Bad defcustom ?

Bad defcustom ?

[Xavier Maillard]

[-- Attachment #1: Type: text/plain, Size: 592 bytes --]

Hi,

Dunno If I am right, but look into the code of spam.el revealed this to
me :

(defcustom spam-bogofilter-database-directory nil
  "Directory path of the Bogofilter databases."
  :type '(choice (directory 
                  :tag "Location of the Bogofilter database directory")
                 (const :tag "Use the default"))
  :group 'spam-ifile)
            ^^^^^^^^^^

Correct me if I am wrong but I think it would be better to have it in
the right customization group aka 'spam-bogofilter', no ?

If yes, then here is a small patch (my 1st contribution for Gnus :))

Cheers,

zeDek


[-- Attachment #2: Patch --]
[-- Type: application/octet-stream, Size: 366 bytes --]

--- spam.el.orig	2003-12-04 23:22:29.000000000 +0100
+++ spam.el	2003-12-04 23:22:50.000000000 +0100
@@ -374,7 +374,7 @@
   :type '(choice (directory 
 		  :tag "Location of the Bogofilter database directory")
 		 (const :tag "Use the default"))
-  :group 'spam-ifile)
+  :group 'spam-bogofilter)
 
 (defgroup spam-spamoracle nil
   "Spam spamoracle configuration."

Re: Bad defcustom ?

[Ted Zlatanov]

On Thu, 04 Dec 2003, zedek@gnu-rox.org wrote:

> (defcustom spam-bogofilter-database-directory nil
[...]
>   :group 'spam-ifile)
>             ^^^^^^^^^^
> 
> Correct me if I am wrong but I think it would be better to have it
> in the right customization group aka 'spam-bogofilter', no ?

Fix committed, thank you.

For future patches (over 10 lines or so), you need to have papers with
the FSF.

Thanks
Ted

Re: Bad defcustom ?

[Xavier Maillard]

Ted Zlatanov <tzz@lifelogs.com> disait récemment que :

> On Thu, 04 Dec 2003, zedek@gnu-rox.org wrote:
>
>> (defcustom spam-bogofilter-database-directory nil
> [...]
>>   :group 'spam-ifile)
>>             ^^^^^^^^^^
>> 
>> Correct me if I am wrong but I think it would be better to have it
>> in the right customization group aka 'spam-bogofilter', no ?
>
> Fix committed, thank you.
>
> For future patches (over 10 lines or so), you need to have papers with
> the FSF.

Maybe one day... :p

zeDek

Re: Bad defcustom ?

[Xavier Maillard]

Ted Zlatanov <tzz@lifelogs.com> disait récemment que :

> On Thu, 04 Dec 2003, zedek@gnu-rox.org wrote:
>
>> (defcustom spam-bogofilter-database-directory nil
> [...]
>>   :group 'spam-ifile)
>>             ^^^^^^^^^^
>> 
>> Correct me if I am wrong but I think it would be better to have it
>> in the right customization group aka 'spam-bogofilter', no ?
>
> Fix committed, thank you.
>
> For future patches (over 10 lines or so), you need to have papers with
> the FSF.

Hmm, just in case I need it one day, can you tell me how can I
"receive" the famous FSF papers ?

Thank you

zeDek

Re: Bad defcustom ?

[Ted Zlatanov]

On Wed, 10 Dec 2003, zedek@gnu-rox.org wrote:

> Hmm, just in case I need it one day, can you tell me how can I
> "receive" the famous FSF papers ?

Generally, package maintainers deal with that.  Either Lars or Kai
sent me the assignment papers years ago.  You can also try
assign@gnu.org but I'm not sure if they are the right place.

Ted