problems with gnus-newsgroup-unseen and gnus-newsgroup-data

problems with gnus-newsgroup-unseen and gnus-newsgroup-data

[Ted Zlatanov]

(latest CVS)

Perhaps I'm missing something obvious, but I've observed on an NNTP
backend (news.gmane.org) that gnus-newsgroup-unseen returns a list of
articles that is not all in gnus-newsgroup-data.  The articles are in
the group, and can be retrieved with `j', but they don't show up when
the summary is entered, which is when spam.el needs the data.

Could someone please clue me in as to how to fill in the missing data
in gnus-newsgroup-data, or tell me why gnus-newsgroup-unseen is
returning invalid article numbers?

Thanks
Ted

Re: problems with gnus-newsgroup-unseen and gnus-newsgroup-data

[Lars Magne Ingebrigtsen]

Ted Zlatanov <tzz@lifelogs.com> writes:

> Could someone please clue me in as to how to fill in the missing data
> in gnus-newsgroup-data, or tell me why gnus-newsgroup-unseen is
> returning invalid article numbers?

Hm...  that list is computed as follows:

    (setq gnus-newsgroup-unseen
	  (gnus-inverse-list-range-intersection
	   gnus-newsgroup-articles gnus-newsgroup-seen))))

Those should be all valid article numbers, I'd have thought.            

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: problems with gnus-newsgroup-unseen and gnus-newsgroup-data

[Ted Zlatanov]

On Sun, 16 May 2004, larsi@gnus.org wrote:

> Ted Zlatanov <tzz@lifelogs.com> writes:
> 
>> Could someone please clue me in as to how to fill in the missing
>> data in gnus-newsgroup-data, or tell me why gnus-newsgroup-unseen
>> is returning invalid article numbers?
> 
> Hm...  that list is computed as follows:
> 
>     (setq gnus-newsgroup-unseen
> 	  (gnus-inverse-list-range-intersection
> 	   gnus-newsgroup-articles gnus-newsgroup-seen))))
> 
> Those should be all valid article numbers, I'd have thought.

Correction: they are *valid* numbers, but the *data* in
gnus-newsgroup-data for them is nil.

I use this version of spam-fetch-article-header now, which fixes
that problem:

(defun spam-fetch-article-header (article)
  (save-excursion
    (set-buffer gnus-summary-buffer)
    (gnus-read-header article)
    (nth 3 (assq article gnus-newsgroup-data))))

I hope this is the right approach.

Ted

Re: problems with gnus-newsgroup-unseen and gnus-newsgroup-data

[Lars Magne Ingebrigtsen]

"Ted Zlatanov" <tzz@lifelogs.com> writes:

> I use this version of spam-fetch-article-header now, which fixes
> that problem:
>
> (defun spam-fetch-article-header (article)
>   (save-excursion
>     (set-buffer gnus-summary-buffer)
>     (gnus-read-header article)
>     (nth 3 (assq article gnus-newsgroup-data))))
>
> I hope this is the right approach.

Hm.  If the header is present in the summary buffer, then it should
also be present in `gnus-newsgroup-data'...

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: problems with gnus-newsgroup-unseen and gnus-newsgroup-data

[Ted Zlatanov]

On Mon, 17 May 2004, larsi@gnus.org wrote:

> "Ted Zlatanov" <tzz@lifelogs.com> writes:
> 
>> I use this version of spam-fetch-article-header now, which fixes
>> that problem:
>>
>> (defun spam-fetch-article-header (article)
>>   (save-excursion
>>     (set-buffer gnus-summary-buffer)
>>     (gnus-read-header article)
>>     (nth 3 (assq article gnus-newsgroup-data))))
>>
>> I hope this is the right approach.
> 
> Hm.  If the header is present in the summary buffer, then it should
> also be present in `gnus-newsgroup-data'...

I kept getting errors when I assumed that.  I'm not sure what's the
cause, but headers are often missing in the newsgroup-data.  It
doesn't show up often, maybe 5% of the time, and I couldn't find a
pattern to it (except that it was repeatable when you re-entered the
group).

Maybe it's threads-related?  I don't know.  Anyhow, if you need me to
show you examples of this problem I can, but I can't trace the root
cause of why the headers are nil.  I tried that and everything looked
OK last time.

Oh, there was a very recent fix for gnus-dup-unsuppress-article which
dealt with this also, because the mail header would be nil there too.

Ted

Re: problems with gnus-newsgroup-unseen and gnus-newsgroup-data

[Lars Magne Ingebrigtsen]

"Ted Zlatanov" <tzz@lifelogs.com> writes:

> I kept getting errors when I assumed that.  I'm not sure what's the
> cause, but headers are often missing in the newsgroup-data.  It
> doesn't show up often, maybe 5% of the time, and I couldn't find a
> pattern to it (except that it was repeatable when you re-entered the
> group).

Off the top of my head, the only think I can imagine causing this is
using sparse threading and the like...

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: problems with gnus-newsgroup-unseen and gnus-newsgroup-data

[Ted Zlatanov]

On Mon, 17 May 2004, larsi@gnus.org wrote:

> Off the top of my head, the only think I can imagine causing this is
> using sparse threading and the like...

Should we maybe put a check on group entry that looks for nil data
headers and fills them in?

Or at least a list of articles with nil data headers, so other code
can avoid or pre-fill them?

Ted

Re: problems with gnus-newsgroup-unseen and gnus-newsgroup-data

[Lars Magne Ingebrigtsen]

"Ted Zlatanov" <tzz@lifelogs.com> writes:

> Should we maybe put a check on group entry that looks for nil data
> headers and fills them in?
>
> Or at least a list of articles with nil data headers, so other code
> can avoid or pre-fill them?

Well, I think it would make more sense to find out why this is
happening.  :-)

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen