* Removing spam-group-ham-mark-p, spam-group-spam-mark-p (was: Changes to emacs/lisp/gnus/ChangeLog) [not found] <E1Evi6k-000363-G0@savannah.gnu.org> @ 2006-01-08 22:24 ` Reiner Steib 2006-02-03 19:39 ` Removing spam-group-ham-mark-p, spam-group-spam-mark-p Ted Zlatanov 0 siblings, 1 reply; 4+ messages in thread From: Reiner Steib @ 2006-01-08 22:24 UTC (permalink / raw) Cc: Gnus, emacs-devel Chong Yidong on emacs-diffs: > --- emacs/lisp/gnus/ChangeLog:1.414 Sat Dec 17 21:41:33 2005 > +++ emacs/lisp/gnus/ChangeLog Sun Jan 8 21:29:46 2006 > @@ -1,3 +1,10 @@ > +2006-01-08 Chong Yidong <cyd@stupidchicken.com> > + > + * spam.el (spam-group-ham-mark-p, spam-group-spam-mark-p) > + (spam-group-spam-marks): Delete functions. > + (spam-list-articles): Just call spam-group-ham-marks directly. > + (spam-group-ham-marks): Simplify. I'd appreciate if you would discuss non-trivial changes to Gnus on the Gnus developer list before committing. I intend to add functionality[1] in the current development version of Gnus that relies on the functions `spam-group-ham-mark-p' and `spam-group-spam-mark-p'. [1] Adding a tool bar button for `gnus-summary-mark-as-spam' depending on the result of `spam-group-ham-mark-p', along with improving the tool bar in general. Bye, Reiner. -- ,,, (o o) ---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/ ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Removing spam-group-ham-mark-p, spam-group-spam-mark-p 2006-01-08 22:24 ` Removing spam-group-ham-mark-p, spam-group-spam-mark-p (was: Changes to emacs/lisp/gnus/ChangeLog) Reiner Steib @ 2006-02-03 19:39 ` Ted Zlatanov 2006-02-04 23:09 ` Reiner Steib 0 siblings, 1 reply; 4+ messages in thread From: Ted Zlatanov @ 2006-02-03 19:39 UTC (permalink / raw) Cc: emacs-devel, Gnus On 8 Jan 2006, reinersteib+gmane@imap.cc wrote: > Chong Yidong on emacs-diffs: > >> --- emacs/lisp/gnus/ChangeLog:1.414 Sat Dec 17 21:41:33 2005 >> +++ emacs/lisp/gnus/ChangeLog Sun Jan 8 21:29:46 2006 >>>> -1,3 +1,10 @@ >> +2006-01-08 Chong Yidong <cyd@stupidchicken.com> >> + >> + * spam.el (spam-group-ham-mark-p, spam-group-spam-mark-p) >> + (spam-group-spam-marks): Delete functions. >> + (spam-list-articles): Just call spam-group-ham-marks directly. >> + (spam-group-ham-marks): Simplify. > > I'd appreciate if you would discuss non-trivial changes to Gnus on the > Gnus developer list before committing. Chong, was there a reason for deleting them? Are they slow? I'd like to keep them too. Ted p.s. sorry for the late reply, I just caught up with ding :) ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Removing spam-group-ham-mark-p, spam-group-spam-mark-p 2006-02-03 19:39 ` Removing spam-group-ham-mark-p, spam-group-spam-mark-p Ted Zlatanov @ 2006-02-04 23:09 ` Reiner Steib 2006-02-06 18:54 ` Ted Zlatanov 0 siblings, 1 reply; 4+ messages in thread From: Reiner Steib @ 2006-02-04 23:09 UTC (permalink / raw) Cc: emacs-devel, ding On Fri, Feb 03 2006, Ted Zlatanov wrote: >>> +2006-01-08 Chong Yidong <cyd@stupidchicken.com> >>> + >>> + * spam.el (spam-group-ham-mark-p, spam-group-spam-mark-p) >>> + (spam-group-spam-marks): Delete functions. >>> + (spam-list-articles): Just call spam-group-ham-marks directly. >>> + (spam-group-ham-marks): Simplify. [...] > Chong, was there a reason for deleting them? Are they slow? I'd like > to keep them too. We agreed to revert this change. I did this some weeks ago. Now (in the trunk) the functions are also used in `gnus-summary-tool-bar-gnome'. Bye, Reiner. -- ,,, (o o) ---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/ ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Removing spam-group-ham-mark-p, spam-group-spam-mark-p 2006-02-04 23:09 ` Reiner Steib @ 2006-02-06 18:54 ` Ted Zlatanov 0 siblings, 0 replies; 4+ messages in thread From: Ted Zlatanov @ 2006-02-06 18:54 UTC (permalink / raw) Cc: ding On 4 Feb 2006, reinersteib+gmane@imap.cc wrote: > We agreed to revert this change. I did this some weeks ago. > > Now (in the trunk) the functions are also used in > `gnus-summary-tool-bar-gnome'. Oh, I see. Sorry for the noise. Ted ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2006-02-06 18:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <E1Evi6k-000363-G0@savannah.gnu.org>
2006-01-08 22:24 ` Removing spam-group-ham-mark-p, spam-group-spam-mark-p (was: Changes to emacs/lisp/gnus/ChangeLog) Reiner Steib
2006-02-03 19:39 ` Removing spam-group-ham-mark-p, spam-group-spam-mark-p Ted Zlatanov
2006-02-04 23:09 ` Reiner Steib
2006-02-06 18:54 ` Ted Zlatanov
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).