Gnus development mailing list
 help / color / mirror / Atom feed
From: "Ted Zlatanov" <tzz@lifelogs.com>
Subject: Re: [spam.el] Misleading messages on group exit
Date: 17 May 2004 10:12:48 -0400	[thread overview]
Message-ID: <4nu0yfuopr.fsf@lifelogs.com> (raw)
In-Reply-To: <873c604b8n.fsf@namazu.org> (TSUCHIYA Masatoshi's message of "Mon, 17 May 2004 00:56:25 +0900")

On Mon, 17 May 2004, tsuchiya@namazu.org wrote:

>>> On 14 May 2004 15:23:44 -0400
>>> tzz@lifelogs.com ("Ted Zlatanov") said as follows:
> 
>> I think a fix I just comitted will fix this message, producing it
>> only when there's spam in the group.
> 
> Your fix is as insufficient as my proposal, I think.

Can you be specific as to why?  The logic seems OK to me.  Note I
generate the list of spam articles when the message is about to be
generated, not earlier.  I can put the actual numbers in the
message, but right now I'm trying to get the logic correct.

> I noticed that spam-summary-prepare-exit() has three misleading
> messages at least.  The first one is "Marking spam as expired and
> moving it to nnml:spam" at line 864, which is printed even if there
> is no spam article in the current group.  The second one is "Copying
> ham" at line 892, which is printed even if there is no ham article
> in the current group.  And, the last one is "Moving ham messages
> from spam group" at line 898, which is printed even if there is no
> ham article that should be moved from spam group.

I tried to fix those as well.  Fixes in CVS - let me know what you think.

Thanks
Ted



  reply	other threads:[~2004-05-17 14:12 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-05-06 12:08 Reiner Steib
2004-05-11  6:37 ` TSUCHIYA Masatoshi
2004-05-12  5:09   ` TSUCHIYA Masatoshi
2004-05-14 19:23     ` Ted Zlatanov
2004-05-16 15:56       ` TSUCHIYA Masatoshi
2004-05-17 14:12         ` Ted Zlatanov [this message]
2004-05-20  2:29           ` TSUCHIYA Masatoshi
2004-05-20 14:23             ` Ted Zlatanov
2004-05-20 16:48               ` TSUCHIYA Masatoshi
2004-05-20 17:42                 ` Ted Zlatanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4nu0yfuopr.fsf@lifelogs.com \
    --to=tzz@lifelogs.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).