From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/57417 Path: main.gmane.org!not-for-mail From: "Ted Zlatanov" Newsgroups: gmane.emacs.gnus.general Subject: Re: [spam.el] Misleading messages on group exit Date: 17 May 2004 10:12:48 -0400 Organization: =?koi8-r?q?=F4=C5=CF=C4=CF=D2=20=FA=CC=C1=D4=C1=CE=CF=D7?= @ Cienfuegos Sender: ding-owner@lists.math.uh.edu Message-ID: <4nu0yfuopr.fsf@lifelogs.com> References: <877jvjjwq9.fsf@namazu.org> <87r7tqs03q.fsf@namazu.org> <4nn04ake2n.fsf@lifelogs.com> <873c604b8n.fsf@namazu.org> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1084804185 20288 80.91.224.253 (17 May 2004 14:29:45 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 17 May 2004 14:29:45 +0000 (UTC) Original-X-From: ding-owner+M5957@lists.math.uh.edu Mon May 17 16:29:35 2004 Return-path: Original-Received: from malifon.math.uh.edu ([129.7.128.13]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1BPj7X-0006M4-00 for ; Mon, 17 May 2004 16:29:35 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by malifon.math.uh.edu with smtp (Exim 3.20 #1) id 1BPj7E-00044b-00; Mon, 17 May 2004 09:29:16 -0500 Original-Received: from util2.math.uh.edu ([129.7.128.23]) by malifon.math.uh.edu with esmtp (Exim 3.20 #1) id 1BPj7A-00044W-00 for ding@lists.math.uh.edu; Mon, 17 May 2004 09:29:12 -0500 Original-Received: from justine.libertine.org ([66.139.78.221] ident=postfix) by util2.math.uh.edu with esmtp (Exim 4.30) id 1BPj78-0007E2-NK for ding@lists.math.uh.edu; Mon, 17 May 2004 09:29:10 -0500 Original-Received: from mail.bwh.harvard.edu (sysblade0.bwh.harvard.edu [134.174.9.44]) by justine.libertine.org (Postfix) with ESMTP id 0EDA33A0050 for ; Mon, 17 May 2004 09:29:10 -0500 (CDT) Original-Received: (qmail 23689 invoked from network); 17 May 2004 14:23:39 -0000 Envelope-Sender: tzz@lifelogs.com Envelope-Recipients: ding@gnus.org, Original-Received: from asimov.bwh.harvard.edu (HELO asimov) ([134.174.9.63]) (envelope-sender ) by mail.bwh.harvard.edu (qmail-ldap-1.03) with SMTP for ; 17 May 2004 14:23:39 -0000 Mail-Followup-To: ding@gnus.org Original-To: ding@gnus.org X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6;d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" In-Reply-To: <873c604b8n.fsf@namazu.org> (TSUCHIYA Masatoshi's message of "Mon, 17 May 2004 00:56:25 +0900") User-Agent: Gnus/5.110003 (No Gnus v0.3) Emacs/21.3.50 (gnu/linux) Precedence: bulk Xref: main.gmane.org gmane.emacs.gnus.general:57417 X-Report-Spam: http://spam.gmane.org/gmane.emacs.gnus.general:57417 On Mon, 17 May 2004, tsuchiya@namazu.org wrote: >>> On 14 May 2004 15:23:44 -0400 >>> tzz@lifelogs.com ("Ted Zlatanov") said as follows: > >> I think a fix I just comitted will fix this message, producing it >> only when there's spam in the group. > > Your fix is as insufficient as my proposal, I think. Can you be specific as to why? The logic seems OK to me. Note I generate the list of spam articles when the message is about to be generated, not earlier. I can put the actual numbers in the message, but right now I'm trying to get the logic correct. > I noticed that spam-summary-prepare-exit() has three misleading > messages at least. The first one is "Marking spam as expired and > moving it to nnml:spam" at line 864, which is printed even if there > is no spam article in the current group. The second one is "Copying > ham" at line 892, which is printed even if there is no ham article > in the current group. And, the last one is "Moving ham messages > from spam group" at line 898, which is printed even if there is no > ham article that should be moved from spam group. I tried to fix those as well. Fixes in CVS - let me know what you think. Thanks Ted