Re: Problem with respooling

Re: Problem with respooling

[Ted Zlatanov]

(I forgot to cc the ding list - here goes)

On Fri, 07 Nov 2003, bouvin@daimi.au.dk wrote:
 
> Hi I have encountered a problem with the latest cvs version - when
> I try to B r an article, I get the following:
> 
> Debugger entered--Lisp error: (wrong-type-argument stringp nil)
>   string-match("^[^:]+:" nil) 
>   gnus-group-real-prefix(nil)
>   gnus-group-prefixed-p(nil)
>   gnus-group-guess-full-name-from-command-method(nil)
 [...]
 
The above is fixed in CVS.  I still get an error, however, with `B r':

Debugger entered--Lisp error: (error "Internal error, tag 2828 status BAD code nil text Missing required argument to APPEND")
  signal(error ("Internal error, tag 2828 status BAD code nil text Missing required argument to APPEND"))
  error("Internal error, tag %s status %s code %s text %s" 2828 BAD nil "Missing required argument to APPEND")
  imap-parse-response()
  imap-arrival-filter(#<process imap> "2828 BAD Missing required argument to APPEND\r\n")
  accept-process-output(#<process imap> 0 100)
  imap-wait-for-tag(2828 nil)
  imap-send-command-wait(("APPEND \"" nil "\" " #<buffer  *copy article*>))
  imap-message-append(nil #<buffer  *copy article*> nil nil " *nnimap* mail.lifelogs.com")
  nnimap-request-accept-article(nil "mail.lifelogs.com" t)
  gnus-request-accept-article(nil (nnimap "mail.lifelogs.com") t t)
  gnus-summary-move-article(nil nil (nnimap "mail.lifelogs.com") copy)
  gnus-summary-copy-article(nil nil (nnimap "mail.lifelogs.com"))
  gnus-summary-respool-article(nil (nnimap "mail.lifelogs.com"))
  call-interactively(gnus-summary-respool-article)

I'm not really sure why this is happening, as I don't understand
gnus-summary-respool-article well.  It seems to pass a nil group to
nnimap, but where does it get that nil group value?  If
gnus-registry-split-fancy-with-parent (which Niels and I are using)
is giving a nil, it should be passed over - a nil should never be
taken as the respool destination group, I would think.

If anyone has more clues, I would appreciate the help.

Ted

Re: Problem with respooling

[Simon Josefsson]

Ted Zlatanov <tzz@lifelogs.com> writes:

> (I forgot to cc the ding list - here goes)
>
> On Fri, 07 Nov 2003, bouvin@daimi.au.dk wrote:
>  
>> Hi I have encountered a problem with the latest cvs version - when
>> I try to B r an article, I get the following:
>> 
>> Debugger entered--Lisp error: (wrong-type-argument stringp nil)
>>   string-match("^[^:]+:" nil) 
>>   gnus-group-real-prefix(nil)
>>   gnus-group-prefixed-p(nil)
>>   gnus-group-guess-full-name-from-command-method(nil)
>  [...]
>  
> The above is fixed in CVS.  I still get an error, however, with `B r':
>
> Debugger entered--Lisp error: (error "Internal error, tag 2828 status BAD code nil text Missing required argument to APPEND")
>   signal(error ("Internal error, tag 2828 status BAD code nil text Missing required argument to APPEND"))
>   error("Internal error, tag %s status %s code %s text %s" 2828 BAD nil "Missing required argument to APPEND")
>   imap-parse-response()
>   imap-arrival-filter(#<process imap> "2828 BAD Missing required argument to APPEND\n")
>   accept-process-output(#<process imap> 0 100)
>   imap-wait-for-tag(2828 nil)
>   imap-send-command-wait(("APPEND \"" nil "\" " #<buffer  *copy article*>))
>   imap-message-append(nil #<buffer  *copy article*> nil nil " *nnimap* mail.lifelogs.com")
>   nnimap-request-accept-article(nil "mail.lifelogs.com" t)
>   gnus-request-accept-article(nil (nnimap "mail.lifelogs.com") t t)
>   gnus-summary-move-article(nil nil (nnimap "mail.lifelogs.com") copy)
>   gnus-summary-copy-article(nil nil (nnimap "mail.lifelogs.com"))
>   gnus-summary-respool-article(nil (nnimap "mail.lifelogs.com"))
>   call-interactively(gnus-summary-respool-article)
>
> I'm not really sure why this is happening, as I don't understand
> gnus-summary-respool-article well.  It seems to pass a nil group to
> nnimap, but where does it get that nil group value?  If
> gnus-registry-split-fancy-with-parent (which Niels and I are using)
> is giving a nil, it should be passed over - a nil should never be
> taken as the respool destination group, I would think.
>
> If anyone has more clues, I would appreciate the help.

Respooling is nnmail specific, if I recall correctly.  It assumes the
backend looks in nnmail-split-methods to decide the group name.  The
group=nil mode of operation is not documented, so I think that should
be fixed before any code is altered.  The error is because nnimap
tries to move the article into a group with a non-existent name.

Re: Problem with respooling

[Ted Zlatanov]

On Sat, 08 Nov 2003, jas@extundo.com wrote:

> Respooling is nnmail specific, if I recall correctly.  It assumes
> the backend looks in nnmail-split-methods to decide the group name.

OK, but is nnimap a nnmail backend?  If not, what should `B r' do in
nnimap groups?

> The group=nil mode of operation is not documented, so I think that
> should be fixed before any code is altered.  

Right, I have no idea where the nil group is coming from!  I tried to
trace the code but it does a lot of "make a string and call it as a
function name" acrobatics that, to me, are confusing.  Anyhow, if
nnimap groups shouldn't use `B r', that's fine, but it's not
documented or prevented right now - so I want to help do those things.

Thanks
Ted

Re: Problem with respooling

[Simon Josefsson]

Ted Zlatanov <tzz@lifelogs.com> writes:

> On Sat, 08 Nov 2003, jas@extundo.com wrote:
>
>> Respooling is nnmail specific, if I recall correctly.  It assumes
>> the backend looks in nnmail-split-methods to decide the group name.
>
> OK, but is nnimap a nnmail backend?

No.  (But it sometimes try to pretend to be one, by using nnmail
variables.)

> If not, what should `B r' do in nnimap groups?

Using `nnimap-split-rule' seems reasonable.

>> The group=nil mode of operation is not documented, so I think that
>> should be fixed before any code is altered.  
>
> Right, I have no idea where the nil group is coming from!  I tried to
> trace the code but it does a lot of "make a string and call it as a
> function name" acrobatics that, to me, are confusing.  Anyhow, if
> nnimap groups shouldn't use `B r', that's fine, but it's not
> documented or prevented right now - so I want to help do those things.

Right.  I think for Oort Gnus, the best is to document that respooling
only works on nnmail groups (and mention that nnimap isn't one), and
in No Gnus document the group=nil idiom and have nnimap support it by
matching the message against the normal nnimap split rules.

Re: Problem with respooling

[Ted Zlatanov]

On Sat, 08 Nov 2003, jas@extundo.com wrote:

> Right.  I think for Oort Gnus, the best is to document that
> respooling only works on nnmail groups (and mention that nnimap
> isn't one), and in No Gnus document the group=nil idiom and have
> nnimap support it by matching the message against the normal nnimap
> split rules.

I think it's more prudent to actually tell the user "you're respooling
in nnimap, and that won't work" and document it, instead of just
documenting that behavior.

Ted