Gnus development mailing list
 help / color / mirror / Atom feed
From: "Ted Zlatanov" <tzz@lifelogs.com>
Cc: "Ding Mailing List" <ding@gnus.org>
Subject: Re: spam-check-spamassassin-headers with spamassasin 3.0/3.1
Date: 13 Feb 2006 11:42:02 -0500	[thread overview]
Message-ID: <4nwtfzus6d.fsf@lifelogs.com> (raw)
In-Reply-To: <873biqwtf5.fsf@puyo.nijino.com> (ARISAWA Akihiro's message of "Sat, 11 Feb 2006 10:55:26 +0900")

On 10 Feb 2006, ari@mbf.ocn.ne.jp wrote:

> Hi,
>
> I am using spamassassin 3.1, and (setq spam-use-spamassassin-headers t).
> When I typed S t in Summary buffer, reported score is always 0.
>
> Spamassassin 3.0 or later, the default X-Spam-Status field is changed as:
>> X-Spam-Status: No, score=0.1 required=8.0 ...
> But, `spam-check-spamassassin-headers' checks only "hits=".
> cf. http://issues.apache.org/SpamAssassin/show_bug.cgi?id=1332
>
> When I changed spam.el as attached, the reported score is corrected.
>
> Regards,
> ARISAWA Akihiro
> 2006-02-11  ARISAWA Akihiro  <ari@mbf.ocn.ne.jp>
>
> 	* spam.el (spam-check-spamassassin-headers): Improved regexp
> 	for spamassassin 3.0 or later.
>
> Index: lisp/spam.el
> ===================================================================
> RCS file: /usr/local/cvsroot/gnus/lisp/spam.el,v
> retrieving revision 7.77
> diff -u -r7.77 spam.el
> --- lisp/spam.el	8 Feb 2006 04:17:15 -0000	7.77
> +++ lisp/spam.el	11 Feb 2006 01:35:11 -0000
> @@ -2614,8 +2614,8 @@
> (if score				; scoring mode
> (let ((header (message-fetch-field spam-spamassassin-spam-status-header)))
> 	(when header
> -	  (if (string-match "hits=\\(-?[0-9.]+\\)" header)
> -	      (match-string 1 header)
> + (if (string-match "\\(hits\\|score\\)=\\(-?[0-9.]+\\)" header)
> +	      (match-string 2 header)
> 	    "0")))
> ;; spam detection mode
> (let ((header (message-fetch-field spam-spamassassin-spam-flag-header)))

Thanks!  Can someone else on ding with SA 3.x test this patch please?
I'll commit it as soon as I get a confirmation.

Ted



       reply	other threads:[~2006-02-13 16:42 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <873biqwtf5.fsf@puyo.nijino.com>
2006-02-13 16:42 ` Ted Zlatanov [this message]
2006-02-14 15:01 ` Reiner Steib
2006-02-25  0:47   ` IRIE Tetsuya
2006-02-25 21:33     ` Reiner Steib
2006-02-26  2:45       ` IRIE Tetsuya
2006-02-28 13:44         ` Reiner Steib
2006-03-01 13:57           ` IRIE Tetsuya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4nwtfzus6d.fsf@lifelogs.com \
    --to=tzz@lifelogs.com \
    --cc=ding@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).