Re: CRM114 Mailfilter and spam.el

["Ted Zlatanov" <tzz@lifelogs.com>]

Adam,

I comitted your patch, assuming your papers are on file (it's been a
while since we discussed this).  The two spam.el hunks below didn't
belong in the patch, I think, and I didn't consider them carefully so
let me know if I should.  Also, I added a scoring function for CRM114
to spam-generic-score and fixed a few small problems.

Thanks
Ted

@@ -776,8 +838,8 @@
       (spam-ham-copy-routine
        (gnus-parameter-ham-process-destination gnus-newsgroup-name)))
 
-    ;; now move all ham articles out of spam groups
-    (when (spam-group-spam-contents-p gnus-newsgroup-name)
+    ;; now move all ham articles out of non-ham groups
+    (when (not (spam-group-ham-contents-p gnus-newsgroup-name))
       (gnus-message 5 "Moving ham messages from spam group")
       (spam-ham-move-routine
        (gnus-parameter-ham-process-destination gnus-newsgroup-name))))
@@ -859,7 +921,7 @@
 	 (gnus-check-backend-function
 	  'request-move-article gnus-newsgroup-name))
 	(respool-method (gnus-find-method-for-group gnus-newsgroup-name))
-	article mark todo deletep respool)
+	article mark deletep respool)
 
     (when (member 'respool groups)
       (setq respool t)			; boolean for later