Re: Spam processing slows down group exit

[Ted Zlatanov <tzz@lifelogs.com>]

On Thu, 01 Jan 2004, 4.uce.03.r.s@nurfuerspam.de wrote:

> I found that the group and topic parameters (spam/ham) are
> calculated[1] for *every article* rather than once for each group
> exit.  I have set up spam processing for some IMAP groups and all
> Gmane groups[2], but not for nnml (and other nntp groups).
[...]
> Couldn't each possible mark be checked _once_ per group exit instead
> once for every article?  (==> O(1) instead of O(n), AFAIKS.)

There were two problems here, one that I had forgotten to use the new
spam-list-articles function which encapsulated that check, and the
other that I had forgotten to optimize spam-list-articles as I should
have.

OK, that's three problems, if you count my forgetfulness :)

Fixed in CVS, take a look.  I didn't bother with a global cache,
because it would be much optimizing for a small gain, plus the
customization functions would need triggers to set the caches to nil,
plus if a user modified the ham-marks or spam-marks manually we're in
trouble anyhow.  Instead the caches of "yes" and "no" matches
(spam-list-articles can take a classification, so "yes" the mark
matches the 'spam or 'ham classification, or "no" it doesn't) are
rebuilt every time the function spam-list-articles is run.

> Why is `spam-ham-copy-or-move-routine' called in the first place?  I
> have not requested any spam processing in this group.

It's called from spam-summary-prepare-exit, can you check why it's
being invoked in your case in particular?  It should only be called
here (through the spam-ham-{copy,move}-routine proxies):

    (when (spam-group-ham-processor-copy-p gnus-newsgroup-name)
      (gnus-message 5 "Copying ham")
      (spam-ham-copy-routine
       (gnus-parameter-ham-process-destination gnus-newsgroup-name)))

    ;; now move all ham articles out of spam groups
    (when (spam-group-spam-contents-p gnus-newsgroup-name)
      (gnus-message 5 "Moving ham messages from spam group")
      (spam-ham-move-routine
       (gnus-parameter-ham-process-destination gnus-newsgroup-name))))

Thanks
Ted