Infloop in `mm-uu-dissect-text-parts' on PGP signed message

Infloop in `mm-uu-dissect-text-parts' on PGP signed message

[Reiner Steib]

Hi,

the following change to `mm-uu.el' ...

,----
| 2007-08-31  Daiki Ueno  <ueno@unixuser.org>
| 
| 	* mml2015.el [...]
| 
| 	* mm-uu.el (mm-uu-pgp-beginning-signature): Abolish.
| 	(mm-uu-pgp-signed-extract-1): Bind coding-system-for-read when calling
| 	mml2015-clear-verify-function; don't touch the armor headers or
| 	dash-escaped text here.
`----

... results in ...

,----[ *Messages* ]
| mm-uu-dissect: Variable binding depth exceeds max-specpdl-size
| mm-uu-dissect-text-parts: Variable binding depth exceeds max-specpdl-size
`----

... for me when displaying any message from "Carlos E. R." on
gmane.linux.suse.opensuse.user (e.g.
<http://article.gmane.org/gmane.linux.suse.opensuse.user/40894> =
<news://news.gmane.org/gmane.linux.suse.opensuse.user/40894> =
<news:alpine.LSU.0.9999.0710052343090.7514@nimrodel.valinor>).

Debugging `mm-uu-dissect-text-parts' leads to this backtrace:

,----
| Debugger entered: nil
|   eval((debug))
|   edebug-eval((debug))
|   edebug-eval-expression((debug))
|   call-interactively(edebug-eval-expression)
|   recursive-edit()
|   edebug-recursive-edit()
|   edebug-display()
|   edebug(error (error "Lisp nesting exceeds `max-lisp-eval-depth'"))
|   signal(error ("Lisp nesting exceeds `max-lisp-eval-depth'"))
|   edebug-signal(error ("Lisp nesting exceeds `max-lisp-eval-depth'"))
|   (if (string-match (mm-uu-beginning-regexp ...) beginning-regexp)
|     (setq entry (car alist)) (pop alist))
|   (while (not entry) (if (string-match ... beginning-regexp) (setq
|     entry ...) (pop alist)))
|   (let ((alist mm-uu-type-alist) (beginning-regexp ...)) (while (not
|     entry) (if ... ... ...)))
|   (while (re-search-forward mm-uu-beginning-regexp nil t) (setq
|     start-point (match-beginning 0) entry nil) (let (... ...) (while
|     ... ...)) (if (setq func ...) (funcall func)) (forward-line) (when
|     (and ... ... ...) (if ... ...) (push ... result) (goto-char ...)))
|   (save-excursion (goto-char (point-min)) (cond (noheader) (... ...)
|     (... t) (t ...)) (setq text-start (point)) (while
|     (re-search-forward mm-uu-beginning-regexp nil t) (setq start-point
|     ... entry nil) (let ... ...) (if ... ...) (forward-line) (when
|     ... ... ... ...)) (when result (if ... ...) (setq result ...))
|     result)
|   (let ((case-fold-search t) (mm-uu-text-plain-type ...) text-start
|     start-point end-point file-name result entry func) (save-excursion
|     (goto-char ...) (cond ... ... ... ...) (setq text-start ...)
|     (while ... ... ... ... ... ...) (when result ... ...) result))
|   mm-uu-dissect(t ("text/plain" (charset . gnus-decoded)))
|   (edebug-after (edebug-before 48) 52 (mm-uu-dissect t (edebug-after
|     ... 51 ...)))
| [...]
|   (edebug-after (edebug-before 0) 157 (let (...) (edebug-after ... 156 ...)))
|   (lambda nil (edebug-after (edebug-before 0) 157 (let ... ...)))()
|   edebug-enter(mm-uu-dissect-text-parts (("multipart/mixed"
|     (#("multipart/signed" 0 16 ...) ...)) nil) (lambda nil (edebug-after
|     (edebug-before 0) 157 (let ... ...))))
|   edebug-enter(mm-uu-dissect-text-parts (("multipart/mixed"
|     (#("multipart/signed" 0 16 ...) ...)) nil) (lambda nil
|     (edebug-after (edebug-before 0) 157 (let ... ...))))
|   mm-uu-dissect-text-parts(("multipart/mixed" (#("multipart/signed" 0
|     16 ...) ("multipart/mixed" ...))))
|   gnus-display-mime()
|   gnus-article-prepare-display()
|   gnus-article-prepare(40177 nil)
|   gnus-summary-display-article(40177 nil)
|   gnus-summary-select-article(nil force)
|   gnus-summary-show-article(nil)
|   call-interactively(gnus-summary-show-article)
`----

Reverting `mm-uu.el' to revision 7.44 makes the problem disappear.

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

Re: Infloop in `mm-uu-dissect-text-parts' on PGP signed message

[Daiki Ueno]

2007/10/7, Reiner Steib <reinersteib+gmane@imap.cc>:

> the following change to `mm-uu.el' ...
>
> ,----
> | 2007-08-31  Daiki Ueno  <ueno@unixuser.org>
> |
> |       * mml2015.el [...]
> |
> |       * mm-uu.el (mm-uu-pgp-beginning-signature): Abolish.
> |       (mm-uu-pgp-signed-extract-1): Bind coding-system-for-read when calling
> |       mml2015-clear-verify-function; don't touch the armor headers or
> |       dash-escaped text here.
> `----
>
> ... results in ...
>
> ,----[ *Messages* ]
> | mm-uu-dissect: Variable binding depth exceeds max-specpdl-size
> | mm-uu-dissect-text-parts: Variable binding depth exceeds max-specpdl-size
> `----
>
> ... for me when displaying any message from "Carlos E. R." on
> gmane.linux.suse.opensuse.user (e.g.
> <http://article.gmane.org/gmane.linux.suse.opensuse.user/40894> =
> <news://news.gmane.org/gmane.linux.suse.opensuse.user/40894> =
> <news:alpine.LSU.0.9999.0710052343090.7514@nimrodel.valinor>).

Confirmed and it should now be fixed.  Thanks.

Regards,
-- 
Daiki Ueno

Re: Infloop in `mm-uu-dissect-text-parts' on PGP signed message

[Reiner Steib]

On Sun, Oct 07 2007, Daiki Ueno wrote:

> Confirmed and it should now be fixed.  Thanks.

,----
| 2007-10-07  Daiki Ueno  <ueno@unixuser.org>
| 
| 	* mm-uu.el (mm-uu-pgp-signed-extract-1): Delete the first line
| 	beginning with "-----BEGIN PGP SIGNED MESSAGE-----" if extraction
| 	failed.
`----

It fixed the infloop, thanks.

But there "Hash: SHA1" in the mail body:

,----
| [[PGP Signed Part:Undecided]]
| Hash: SHA1
| 
| The Saturday 2007-10-06 at 19:29 +0200, Lars Norén wrote:
`----

Additionally, verifying the signature fails for me (I don't know if
it's Gnus' fault or not):

,----
| [[PGP Signed Part:Failed]
| Signature made Sun 07 Oct 2007 12:14:06 AM CEST using DSA key ID 6D8D47D5
| BAD signature from "Carlos Robinson (Carlos) <cerobinson@tiscali.es>"
| [GNUPG:] BADSIG B533181C6D8D47D5 Carlos Robinson (Carlos) <cerobinson@tiscali.es>
| ]
| Hash: SHA1
`----

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

Re: Infloop in `mm-uu-dissect-text-parts' on PGP signed message

[Daiki Ueno]

2007/10/8, Reiner Steib <reinersteib+gmane@imap.cc>:
> On Sun, Oct 07 2007, Daiki Ueno wrote:
>
> > Confirmed and it should now be fixed.  Thanks.
>
> ,----
> | 2007-10-07  Daiki Ueno  <ueno@unixuser.org>
> |
> |       * mm-uu.el (mm-uu-pgp-signed-extract-1): Delete the first line
> |       beginning with "-----BEGIN PGP SIGNED MESSAGE-----" if extraction
> |       failed.
> `----
>
> It fixed the infloop, thanks.
>
> But there "Hash: SHA1" in the mail body:

And the text between -----BEGIN PGP SIGNATURE----- and -----END PGP
SIGNATURE----- also remains, doesn't it?  That says that
(mm-uu-pgp-signed-test) failed.

I first thought that you were using (setq mm-verify-option 'never) so
(mm-uu-pgp-signed-test) failed.  However, it seems not.  I tried by
myself with the following settings:

(setq pgg-scheme 'gpg
      mm-verify-option 'always
      gnus-buttonized-mime-types '("multipart/signed"))

and I couldn't reproduce the original problem.

Can you show me the exact settings related to mm-uu-pgp-signed-test?

Regards,
-- 
Daiki Ueno

Re: Infloop in `mm-uu-dissect-text-parts' on PGP signed message

[Daiki Ueno]

2007/10/8, Daiki Ueno <ueno@unixuser.org>:
> I first thought that you were using (setq mm-verify-option 'never) so
> (mm-uu-pgp-signed-test) failed.  However, it seems not.

Ah, I finally figured out what happened here.  My guess was correct
(i.e mm-verify-option is 'never), and you clicked on the MIME button
after the article showed up, right?

This time it should be fixed.  Please try the latest CVS version.

Regards,
-- 
Daiki Ueno