From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/63963 Path: news.gmane.org!not-for-mail From: Daiki Ueno Newsgroups: gmane.emacs.devel,gmane.emacs.gnus.general Subject: Re: Patch: Show signature state in encrypted messages using pgg Date: Sun, 12 Nov 2006 09:28:23 +0900 Message-ID: <59350f81-0e9a-4619-b46c-6e8bd1562c6d@well-done.deisui.org> References: NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Trace: sea.gmane.org 1163291325 25602 80.91.229.2 (12 Nov 2006 00:28:45 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 12 Nov 2006 00:28:45 +0000 (UTC) Cc: ding , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Nov 12 01:28:43 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1Gj3DG-0004kQ-8L for ged-emacs-devel@m.gmane.org; Sun, 12 Nov 2006 01:28:42 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Gj3DF-0002j4-41 for ged-emacs-devel@m.gmane.org; Sat, 11 Nov 2006 19:28:41 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Gj3D5-0002iz-1G for emacs-devel@gnu.org; Sat, 11 Nov 2006 19:28:31 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Gj3D4-0002ij-Cc for emacs-devel@gnu.org; Sat, 11 Nov 2006 19:28:30 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Gj3D4-0002ig-8a for emacs-devel@gnu.org; Sat, 11 Nov 2006 19:28:30 -0500 Original-Received: from [210.231.96.69] (helo=localhost) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA:32) (Exim 4.52) id 1Gj3D3-0000jZ-LI for emacs-devel@gnu.org; Sat, 11 Nov 2006 19:28:30 -0500 Original-Received: from localhost ([127.0.0.1] helo=well-done.deisui.org) by localhost with esmtp (Exim 4.63) (envelope-from ) id 1Gj3Cx-0001ux-HD; Sun, 12 Nov 2006 09:28:23 +0900 Original-To: Sascha Wilde X-Attribution: DU In-Reply-To: (Sascha Wilde's message of "Sat, 11 Nov 2006 22:48:35 +0100") User-Agent: T-gnus/6.17.2 (based on No Gnus v0.2) EMIKO/1.14.1 (Choanoflagellata) FLIM/1.14.5 (Demachiyanagi) APEL/10.6 EasyPG/0.0.5 MULE XEmacs/21.4 (patch 14) (Reasonable Discussion) (i686-pc-linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:62087 gmane.emacs.gnus.general:63963 Archived-At: >>>>> In >>>>> Sascha Wilde wrote: > Daiki Ueno wrote: > >> > The attached patch extends the message a bit, so that it shows the > >> > signature verification result in addition. With it a encrypted but > >> > unsigned mail shows: > >> > [[[PGP Encrypted Part:OK, Signer: From unknown user]] > > > > Is there still any chance for such a feature enhancement to get into the > > release? Anyway, > No, I don't think so, but I think that: > 1. There is a chance to get it into gnus CVS If so, you should make a patch to the Gnus trunk, I think. > Yes, this might be a problem indeed -- but as far as I can see from a > quick glance over the source mm-uu-pgp-encrypted-extract-1 is only > used for "application/x-gnus-pgp-encrypted" which seems quite non > standard and which I haven't knowingly encountered in real live -- > which would explains why I haven't noticed the glitch in my patch... You are appearantly missing that Gnus set application/x-gnus-pgp-encrypted for traditional inline PGP messages. I agree these messages are "quite non standard". > Anyway how about something along the lines of > ;;; untested: > (progn > (mml2015-clean-buffer) > (funcall (mml2015-clear-decrypt-function)) > (eq t > (compare-strings "OK" nil nil > (mm-handle-multipart-ctl-parameter mm-security-handle > 'gnus-info) > nil 2))) > this should fix it. At least XEmacs 21.4 does not have compare-strings. BTW, why do you tend to spread your kludge here and there? Why not use some other parameters such as 'gnus-details instead? -- Daiki Ueno