* Bug: charset in Gnus Customize
@ 1999-01-27 21:23 Shenghuo ZHU
1999-01-28 10:24 ` Lars Magne Ingebrigtsen
0 siblings, 1 reply; 5+ messages in thread
From: Shenghuo ZHU @ 1999-01-27 21:23 UTC (permalink / raw)
Bug if charset in Gnus is set.
A patch is attached.
--
Shenghuo
Wed Jan 27 16:09:09 1999 Shenghuo ZHU <zsh@cs.rochester.edu>
* gnus-sum.el (gnus-summary-setup-default-charset): Charset is a
symbol.
--- gnus-sum.el 1999/01/27 21:03:57 1.1
+++ gnus-sum.el 1999/01/27 21:05:26
@@ -9184,7 +9184,9 @@
(setq alist nil
charset (cadr elem))))
charset)))
- gnus-default-charset))))
+ gnus-default-charset))
+ (if (stringp gnus-newsgroup-charset)
+ (setq gnus-newsgroup-charset (intern gnus-newsgroup-charset)))))
;;;
;;; Mime Commands
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Bug: charset in Gnus Customize
1999-01-27 21:23 Bug: charset in Gnus Customize Shenghuo ZHU
@ 1999-01-28 10:24 ` Lars Magne Ingebrigtsen
1999-01-28 17:29 ` Shenghuo ZHU
0 siblings, 1 reply; 5+ messages in thread
From: Lars Magne Ingebrigtsen @ 1999-01-28 10:24 UTC (permalink / raw)
Shenghuo ZHU <zsh@cs.rochester.edu> writes:
> Bug if charset in Gnus is set.
[...]
> + (if (stringp gnus-newsgroup-charset)
> + (setq gnus-newsgroup-charset (intern gnus-newsgroup-charset)))))
But the charset is never allowed to be a string, so I'm not sure when
this would apply...
--
(domestic pets only, the antidote for overdose, milk.)
larsi@gnus.org * Lars Magne Ingebrigtsen
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Bug: charset in Gnus Customize
1999-01-28 10:24 ` Lars Magne Ingebrigtsen
@ 1999-01-28 17:29 ` Shenghuo ZHU
1999-01-28 19:58 ` Lars Magne Ingebrigtsen
0 siblings, 1 reply; 5+ messages in thread
From: Shenghuo ZHU @ 1999-01-28 17:29 UTC (permalink / raw)
>>>>> "LMI" == Lars Magne Ingebrigtsen <larsi@gnus.org> writes:
LMI> Shenghuo ZHU <zsh@cs.rochester.edu> writes:
>> Bug if charset in Gnus is set.
LMI> [...]
>> + (if (stringp gnus-newsgroup-charset)
>> + (setq gnus-newsgroup-charset (intern gnus-newsgroup-charset)))))
LMI> But the charset is never allowed to be a string, so I'm not sure when
LMI> this would apply...
(gnus-group-find-parameter gnus-newsgroup-name 'charset) returns a
string if the parameter is set.
--
Shenghuo
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Bug: charset in Gnus Customize
1999-01-28 17:29 ` Shenghuo ZHU
@ 1999-01-28 19:58 ` Lars Magne Ingebrigtsen
1999-02-02 5:00 ` Shenghuo ZHU
0 siblings, 1 reply; 5+ messages in thread
From: Lars Magne Ingebrigtsen @ 1999-01-28 19:58 UTC (permalink / raw)
Shenghuo ZHU <zsh@cs.rochester.edu> writes:
> (gnus-group-find-parameter gnus-newsgroup-name 'charset) returns a
> string if the parameter is set.
Hm. Why is that parameter a string? The charset should always be a
symbol.
--
(domestic pets only, the antidote for overdose, milk.)
larsi@gnus.org * Lars Magne Ingebrigtsen
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Bug: charset in Gnus Customize
1999-01-28 19:58 ` Lars Magne Ingebrigtsen
@ 1999-02-02 5:00 ` Shenghuo ZHU
0 siblings, 0 replies; 5+ messages in thread
From: Shenghuo ZHU @ 1999-02-02 5:00 UTC (permalink / raw)
>>>>> "LMI" == Lars Magne Ingebrigtsen <larsi@gnus.org> writes:
LMI> Shenghuo ZHU <zsh@cs.rochester.edu> writes:
>> (gnus-group-find-parameter gnus-newsgroup-name 'charset) returns a
>> string if the parameter is set.
LMI> Hm. Why is that parameter a string? The charset should always be a
LMI> symbol.
With the following patch, the charset is a symbol in
gnus-group-parameters.
BTW, this patch also deletes an extra 'a' in gnus-group-parameters.
--
Shenghuo
Mon Feb 1 23:23:03 1999 Shenghuo ZHU <zsh@cs.rochester.edu>
* gnus-cus.el (gnus-group-parameters): Charset as symbol, and fix
a typo.
* gnus-sum.el (gnus-summary-setup-default-charset): Set nndraft's
charset to nil.
* gnus-agent.el (gnus-agent-queue-setup): Remove charset setting.
* gnus-start.el (gnus-start-draft-setup): Ditto.
--- gnus-cus.el 1999/02/02 04:15:41 1.1
+++ gnus-cus.el 1999/02/02 04:47:23
@@ -108,7 +108,7 @@
(const signature)
string ) "\
Banner to be removed from articles.")
-a
+
(auto-expire (const :tag "Automatic Expire" t) "\
All articles that are read will be marked as expirable.")
@@ -167,7 +167,7 @@
Always display this group, even when there are no unread articles
in it..")
- (charset (string :tag "Charset") "\
+ (charset (symbol :tag "Charset") "\
The default charset to use in the group."))
"Alist of valid group parameters.
--- gnus-sum.el 1999/02/02 04:17:22 1.1
+++ gnus-sum.el 1999/02/02 04:21:04
@@ -9174,17 +9174,21 @@
(let ((name (and gnus-newsgroup-name
(gnus-group-real-name gnus-newsgroup-name))))
(setq gnus-newsgroup-charset
- (or (and gnus-newsgroup-name
- (or (gnus-group-find-parameter gnus-newsgroup-name 'charset)
- (let ((alist gnus-group-charset-alist)
- elem (charset nil))
- (while (setq elem (pop alist))
- (when (and name
- (string-match (car elem) name))
- (setq alist nil
- charset (cadr elem))))
- charset)))
- gnus-default-charset))))
+ (if (and gnus-newsgroup-name
+ (string-match "^nndraft:" gnus-newsgroup-name))
+ nil
+ (or (and gnus-newsgroup-name
+ (or (gnus-group-find-parameter gnus-newsgroup-name
+ 'charset)
+ (let ((alist gnus-group-charset-alist)
+ elem (charset nil))
+ (while (setq elem (pop alist))
+ (when (and name
+ (string-match (car elem) name))
+ (setq alist nil
+ charset (cadr elem))))
+ charset)))
+ gnus-default-charset)))))
;;;
;;; Mime Commands
--- gnus-start.el 1999/02/02 04:21:55 1.1
+++ gnus-start.el 1999/02/02 04:23:22
@@ -720,7 +720,6 @@
(unless (gnus-gethash "nndraft:drafts" gnus-newsrc-hashtb)
(let ((gnus-level-default-subscribed 1))
(gnus-subscribe-group "nndraft:drafts" nil '(nndraft "")))
- (gnus-group-set-parameter "nndraft:drafts" 'charset nil)
(gnus-group-set-parameter
"nndraft:drafts" 'gnus-dummy '((gnus-draft-mode)))))
--- gnus-agent.el 1999/02/02 04:22:43 1.1
+++ gnus-agent.el 1999/02/02 04:22:55
@@ -330,7 +330,6 @@
(gnus-request-create-group "queue" '(nndraft ""))
(let ((gnus-level-default-subscribed 1))
(gnus-subscribe-group "nndraft:queue" nil '(nndraft "")))
- (gnus-group-set-parameter "nndraft:queue" 'charset nil)
(gnus-group-set-parameter
"nndraft:queue" 'gnus-dummy '((gnus-draft-mode)))))
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~1999-02-02 5:00 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
1999-01-27 21:23 Bug: charset in Gnus Customize Shenghuo ZHU
1999-01-28 10:24 ` Lars Magne Ingebrigtsen
1999-01-28 17:29 ` Shenghuo ZHU
1999-01-28 19:58 ` Lars Magne Ingebrigtsen
1999-02-02 5:00 ` Shenghuo ZHU
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).