Gnus development mailing list
 help / color / mirror / Atom feed
From: Shenghuo ZHU <zsh@cs.rochester.edu>
Subject: Re: Old boundary
Date: 18 Nov 1998 11:57:48 -0500	[thread overview]
Message-ID: <5b1zn1os4z.fsf@schnapps.cs.rochester.edu> (raw)
In-Reply-To: Vladimir Volovich's message of "18 Nov 1998 17:58:03 +0300"

>>>>> "VVV" == Vladimir Volovich <vvv@vvv.vsu.ru> writes:


VVV> "LMI" == Lars Magne Ingebrigtsen writes:
LMI> 3.  [ ] text/plain [ ] text/plain [*] multipart/mixed

VVV> When clicking on the multipart/mixed and then on any of text/plain, i
VVV> get an error (pgnus-0.50):

Fixed. 

Another fixed bug is that nothing is displayed when no part is
preferred.

A patch.

-- 
Shenghuo

:- cut -----
--- ChangeLog	1998/11/18 16:47:54	1.1
+++ ChangeLog	1998/11/18 16:54:51
@@ -1,3 +1,8 @@
+Wed Nov 18 11:52:19 1998  Shenghuo ZHU  <zsh@cs.rochester.edu>
+
+	* gnus-art.el (gnus-mime-display-alternative): Set end of
+	multipart and display even when nothing is preferred.
+
 Wed Nov 18 05:06:44 1998  Lars Magne Ingebrigtsen  <larsi@menja.ifi.uio.no>
 
 	* gnus.el: Pterodactyl Gnus v0.50 is released.

--- gnus-art.el	1998/11/18 16:48:51	1.1
+++ gnus-art.el	1998/11/18 16:50:23
@@ -2477,25 +2477,49 @@
 	 (ihandles handles)
 	 (point (point))
 	 handle buffer-read-only from props begend not-pref)
-    (when preferred
-      (save-restriction
-	(when ibegend
-	  (narrow-to-region (car ibegend) (cdr ibegend))
-	  (delete-region (point-min) (point-max))
-	  (mm-remove-parts handles))
-	(setq begend (list (point-marker)))
-	;; Do the toggle.
-	(unless (setq not-pref (cadr (member preferred ihandles)))
-	  (setq not-pref (car ihandles)))
+    (save-restriction
+      (when ibegend
+	(narrow-to-region (car ibegend) (cdr ibegend))
+	(delete-region (point-min) (point-max))
+	(mm-remove-parts handles))
+      (setq begend (list (point-marker)))
+      ;; Do the toggle.
+      (unless (setq not-pref (cadr (member preferred ihandles)))
+	(setq not-pref (car ihandles)))
+      (gnus-add-text-properties
+       (setq from (point))
+       (progn
+	 (insert (format "%d.  " id))
+	 (point))
+       `(gnus-callback
+	 (lambda (handles)
+	   (gnus-mime-display-alternative
+	    ',ihandles ',not-pref
+	    ',begend ,id))
+	 local-map ,gnus-mime-button-map
+	 ,gnus-mouse-face-prop ,gnus-article-mouse-face
+	 face ,gnus-article-button-face
+	 keymap ,gnus-mime-button-map
+	 gnus-part ,id
+	 gnus-data ,handle))
+      (widget-convert-button 'link from (point)
+			     :action 'gnus-widget-press-button
+			     :button-keymap gnus-widget-button-keymap)
+      ;; Do the handles
+      (while (setq handle (pop handles))
 	(gnus-add-text-properties
 	 (setq from (point))
 	 (progn
-	   (insert (format "%d.  " id))
+	   (insert (format "[%c] %-18s"
+			   (if (equal handle preferred) ?* ? )
+			   (if (stringp (car handle))
+			       (car handle)
+			     (car (mm-handle-type handle)))))
 	   (point))
 	 `(gnus-callback
 	   (lambda (handles)
 	     (gnus-mime-display-alternative
-	      ',ihandles ',not-pref
+	      ',ihandles ',handle
 	      ',begend ,id))
 	   local-map ,gnus-mime-button-map
 	   ,gnus-mouse-face-prop ,gnus-article-mouse-face
@@ -2506,41 +2530,16 @@
 	(widget-convert-button 'link from (point)
 			       :action 'gnus-widget-press-button
 			       :button-keymap gnus-widget-button-keymap)
-	;; Do the handles
-	(while (setq handle (pop handles))
-	  (gnus-add-text-properties
-	   (setq from (point))
-	   (progn
-	     (insert (format "[%c] %-18s"
-			     (if (equal handle preferred) ?* ? )
-			     (if (stringp (car handle))
-				 (car handle)
-			       (car (mm-handle-type handle)))))
-	     (point))
-	   `(gnus-callback
-	     (lambda (handles)
-	       (gnus-mime-display-alternative
-		',ihandles ',handle
-		',begend ,id))
-	     local-map ,gnus-mime-button-map
-	     ,gnus-mouse-face-prop ,gnus-article-mouse-face
-	     face ,gnus-article-button-face
-	     keymap ,gnus-mime-button-map
-	     gnus-part ,id
-	     gnus-data ,handle))
-	  (widget-convert-button 'link from (point)
-				 :action 'gnus-widget-press-button
-				 :button-keymap gnus-widget-button-keymap)
-	  (insert "  "))
-	(insert "\n\n")
-	(when preferred
-	  (if (stringp (car preferred))
-	      (gnus-display-mime preferred)
-	    (mm-display-part preferred)
-	    (goto-char (point-max))
-	    (setcdr begend (point-marker)))))
-      (when ibegend
-	(goto-char point)))))
+	(insert "  "))
+      (insert "\n\n")
+      (when preferred
+	(if (stringp (car preferred))
+	    (gnus-display-mime preferred)
+	  (mm-display-part preferred)
+	  (goto-char (point-max)))
+	(setcdr begend (point-marker))))
+    (when ibegend
+      (goto-char point))))
 
 (defun gnus-article-wash-status ()
   "Return a string which display status of article washing."


  reply	other threads:[~1998-11-18 16:57 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
1998-11-18 13:49 Lars Magne Ingebrigtsen
1998-11-18 14:58 ` Vladimir Volovich
1998-11-18 16:57   ` Shenghuo ZHU [this message]
1998-11-18 17:32     ` Karl Kleinpaste
1998-11-19  2:57       ` Lars Magne Ingebrigtsen
1998-11-19 14:25     ` Vladimir Volovich
1998-11-20  2:29       ` Lars Magne Ingebrigtsen
1998-11-20  7:48         ` Vladimir Volovich
1998-11-20 15:22           ` Lars Magne Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5b1zn1os4z.fsf@schnapps.cs.rochester.edu \
    --to=zsh@cs.rochester.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).