* bug during gnus-summary-move-article
@ 1998-09-12 18:52 Shenghuo ZHU
1998-09-13 2:53 ` Shenghuo ZHU
1998-09-13 4:00 ` Shenghuo ZHU
0 siblings, 2 replies; 3+ messages in thread
From: Shenghuo ZHU @ 1998-09-12 18:52 UTC (permalink / raw)
*Symptom: When gnus-summary-copy-article or gnus-summary-move-article
an article with MULTIPART/MIXED, the article in new folder will not be
decoded.
*Reason: The headers of Content-Transfer-Encoding, Content-Type,
Mime-Version are removed by message-remove-header in
message-encode-message-body. The backtrack is
* message-encode-message-body()
gnus-request-accept-article("nnml:test" nil t)
gnus-summary-move-article(nil nil nil copy)
gnus-summary-copy-article(nil)
* call-interactively(gnus-summary-copy-article)
*Rx: Apply this patch
--- gnus-sum.el.orig Sat Sep 12 03:15:36 1998
+++ gnus-sum.el Sat Sep 12 14:44:10 1998
@@ -6920,7 +6920,7 @@
gnus-newsgroup-name)) ; Server
(list 'gnus-request-accept-article
to-newsgroup (list 'quote select-method)
- (not articles)) ; Accept form
+ (not articles) t) ; Accept form
(not articles))) ; Only save nov last time
;; Copy the article.
((eq action 'copy)
@@ -6928,7 +6928,7 @@
(set-buffer copy-buf)
(when (gnus-request-article-this-buffer article gnus-newsgroup-name)
(gnus-request-accept-article
- to-newsgroup select-method (not articles)))))
+ to-newsgroup select-method (not articles) t))))
;; Crosspost the article.
((eq action 'crosspost)
(let ((xref (message-tokenize-header
*Note: Is there a similar bug in gnus-summary-import-article?
--
Shenghuo
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: bug during gnus-summary-move-article
1998-09-12 18:52 bug during gnus-summary-move-article Shenghuo ZHU
@ 1998-09-13 2:53 ` Shenghuo ZHU
1998-09-13 4:00 ` Shenghuo ZHU
1 sibling, 0 replies; 3+ messages in thread
From: Shenghuo ZHU @ 1998-09-13 2:53 UTC (permalink / raw)
This patch may bring "\201" bug when an article has charset feature.
Lars, could you explain why copying/moving needs decoding, removing
header, copying buffer, instead of just copying the undecoded article?
>>>>> "ZSH" == Shenghuo ZHU <zsh@cs.rochester.edu> writes:
ZSH> *Rx: Apply this patch
--
Shenghuo
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: bug during gnus-summary-move-article
1998-09-12 18:52 bug during gnus-summary-move-article Shenghuo ZHU
1998-09-13 2:53 ` Shenghuo ZHU
@ 1998-09-13 4:00 ` Shenghuo ZHU
1 sibling, 0 replies; 3+ messages in thread
From: Shenghuo ZHU @ 1998-09-13 4:00 UTC (permalink / raw)
The previous patch bring "\201" bug only when copy-article.
This patch should works for both move-article and copy-aricle.
Please check whether similar bugs exist in functions calling
gnus-request-article-this-buffer.
--
Shenghuo
----------------------------------------------------------
diff -ru pgnus-0.29/lisp/gnus-art.el pgnus-new/lisp/gnus-art.el
--- pgnus-0.29/lisp/gnus-art.el Sat Sep 12 03:15:35 1998
+++ pgnus-new/lisp/gnus-art.el Sat Sep 12 23:44:31 1998
@@ -2535,7 +2535,7 @@
(gnus-check-server (gnus-find-method-for-group gnus-newsgroup-name))
(gnus-request-group gnus-newsgroup-name t)))
-(defun gnus-request-article-this-buffer (article group)
+(defun gnus-request-article-this-buffer (article group &optional no-decode)
"Get an article and insert it into this buffer."
(let (do-update-line sparse-header)
(prog1
@@ -2668,8 +2668,9 @@
(insert-buffer-substring gnus-article-buffer))
(setq gnus-original-article (cons group article))))
- ;; Decode charsets.
- (run-hooks 'gnus-article-decode-hook)
+ (unless no-decode
+ ;; Decode charsets.
+ (run-hooks 'gnus-article-decode-hook))
;; Update sparse articles.
(when (and do-update-line
diff -ru pgnus-0.29/lisp/gnus-sum.el pgnus-new/lisp/gnus-sum.el
--- pgnus-0.29/lisp/gnus-sum.el Sat Sep 12 03:15:36 1998
+++ pgnus-new/lisp/gnus-sum.el Sat Sep 12 23:45:58 1998
@@ -6920,15 +6920,15 @@
gnus-newsgroup-name)) ; Server
(list 'gnus-request-accept-article
to-newsgroup (list 'quote select-method)
- (not articles)) ; Accept form
+ (not articles) t) ; Accept form
(not articles))) ; Only save nov last time
;; Copy the article.
((eq action 'copy)
(save-excursion
(set-buffer copy-buf)
- (when (gnus-request-article-this-buffer article gnus-newsgroup-name)
+ (when (gnus-request-article-this-buffer article gnus-newsgroup-name t)
(gnus-request-accept-article
- to-newsgroup select-method (not articles)))))
+ to-newsgroup select-method (not articles) t))))
;; Crosspost the article.
((eq action 'crosspost)
(let ((xref (message-tokenize-header
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~1998-09-13 4:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
1998-09-12 18:52 bug during gnus-summary-move-article Shenghuo ZHU
1998-09-13 2:53 ` Shenghuo ZHU
1998-09-13 4:00 ` Shenghuo ZHU
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).