Re: gnus-subscribe-topics doesn't seem to work (fixed, kind of)

[ShengHuo ZHU <zsh@cs.rochester.edu>]

Dmitry Yaitskov <dimas@home.com> writes:


[...]

> in my .gnus.el, I saw that gnus-subscribe-topics never got called. It
> turned out that gnus-group-find-new-groups (what is bound to F in the
> group buffer) eventually invoked gnus-ask-server-for-new-groups - and
> that method calls gnus-subscribe-options-newsgroup-method and not
> gnus-subscribe-newsgroup-method, to subscribe to new groups. I do not
> understand the logic behind this stuff, so cannot really say what
> should be the correct fix - but the way it is seems broken to me.

I bet that those groups you mentioned are options newsgroups.

> After I replaced the call to gnus-subscribe-options-newsgroup-method
> with the call to gnus-subscribe-newsgroup-method in
> gnus-group-find-new-groups, finally the gnus-subscribe-topics was
> called - and produced a lisp error. This was because it calls
> string-match with a list containing the match string rather than with
> the car of that list. The fix for this follows (but I'm not sure
> whether car-safe is available in FSF Emacs - I'm using XEmacs):
> 
> --------------------------- cut here ---------------------------
> Index: gnus-topic.el
> ===================================================================
> RCS file: /usr/local/cvsroot/gnus/lisp/gnus-topic.el,v
> retrieving revision 6.9
> diff -u -r6.9 gnus-topic.el
> --- gnus-topic.el       2001/02/21 20:28:20     6.9
> +++ gnus-topic.el       2001/03/15 23:22:09
> @@ -1660,8 +1660,8 @@
>    (catch 'end
>      (let (match gnus-group-change-level-function)
>        (dolist (topic (gnus-topic-list))
> -       (when (and (setq match (cdr (assq 'subscribe
> -                                         (gnus-topic-parameters topic))))
> +       (when (and (setq match (car-safe (cdr (assq 'subscribe
> +                                         (gnus-topic-parameters topic)))))
>                    (string-match match newsgroup))
>           ;; Just subscribe the group.
>           (gnus-subscribe-alphabetically newsgroup)
> --------------------------- cut here ---------------------------
> 
> With these two fixes, it all now seems to work.

This is NOT a fix. The topic parameters should be something like

        ((subscribe . "nnslashdot:"))

instead of

        ((subscribe "nnslashdot:"))

If you are not sure what it is, use `G c' instead of `G p'.

ShengHuo