From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/35363 Path: main.gmane.org!not-for-mail From: ShengHuo ZHU Newsgroups: gmane.emacs.gnus.general Subject: Re: gnus-subscribe-topics doesn't seem to work (fixed, kind of) Date: 15 Mar 2001 18:38:12 -0500 Message-ID: <5bpufir4bf.fsf@avocet.cs.rochester.edu> References: <87hf0uzrj4.fsf@home.com> <87ae6mvchq.fsf_-_@home.com> NNTP-Posting-Host: coloc-standby.netfonds.no Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: main.gmane.org 1035171120 2628 80.91.224.250 (21 Oct 2002 03:32:00 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Mon, 21 Oct 2002 03:32:00 +0000 (UTC) Return-Path: Original-Received: (qmail 18215 invoked by alias); 15 Mar 2001 23:38:13 -0000 Original-Received: (qmail 18210 invoked from network); 15 Mar 2001 23:38:13 -0000 Original-Received: from gate.cs.rochester.edu (192.5.53.207) by gnus.org with SMTP; 15 Mar 2001 23:38:13 -0000 Original-Received: from avocet.cs.rochester.edu (avocet.cs.rochester.edu [192.5.53.22]) by gate.cs.rochester.edu (8.9.1b+Sun/U) with ESMTP id SAA26009 for ; Thu, 15 Mar 2001 18:38:12 -0500 (EST) Original-Received: (from zsh@localhost) by avocet.cs.rochester.edu (8.9.1b+Sun/Q++) id SAA22099; Thu, 15 Mar 2001 18:38:12 -0500 (EST) Original-To: ding@gnus.org X-Attribution: ZSH X-Face: 'IF:e51ib'Qbl^(}l^&4-J`'P!@[4~O|&k#:@Gld#b/]oMq&`&FVY._3+b`mzp~Jeve~/#/ ERD!OTe<86UhyN=l`mrPY)M7_}`Ktt\K+58Z!hu7>qU,i.N7TotU[FYE(f1;}`g2xj!u*l`^&=Q!g{ *q|ddto|nkt"$r,K$[)"|6,elPH= GJ6Q In-Reply-To: <87ae6mvchq.fsf_-_@home.com> (Dmitry Yaitskov's message of "15 Mar 2001 18:28:01 -0500") User-Agent: Gnus/5.090001 (Oort Gnus v0.01) Emacs/20.7 Original-Lines: 57 Xref: main.gmane.org gmane.emacs.gnus.general:35363 X-Report-Spam: http://spam.gmane.org/gmane.emacs.gnus.general:35363 Dmitry Yaitskov writes: [...] > in my .gnus.el, I saw that gnus-subscribe-topics never got called. It > turned out that gnus-group-find-new-groups (what is bound to F in the > group buffer) eventually invoked gnus-ask-server-for-new-groups - and > that method calls gnus-subscribe-options-newsgroup-method and not > gnus-subscribe-newsgroup-method, to subscribe to new groups. I do not > understand the logic behind this stuff, so cannot really say what > should be the correct fix - but the way it is seems broken to me. I bet that those groups you mentioned are options newsgroups. > After I replaced the call to gnus-subscribe-options-newsgroup-method > with the call to gnus-subscribe-newsgroup-method in > gnus-group-find-new-groups, finally the gnus-subscribe-topics was > called - and produced a lisp error. This was because it calls > string-match with a list containing the match string rather than with > the car of that list. The fix for this follows (but I'm not sure > whether car-safe is available in FSF Emacs - I'm using XEmacs): > > --------------------------- cut here --------------------------- > Index: gnus-topic.el > =================================================================== > RCS file: /usr/local/cvsroot/gnus/lisp/gnus-topic.el,v > retrieving revision 6.9 > diff -u -r6.9 gnus-topic.el > --- gnus-topic.el 2001/02/21 20:28:20 6.9 > +++ gnus-topic.el 2001/03/15 23:22:09 > @@ -1660,8 +1660,8 @@ > (catch 'end > (let (match gnus-group-change-level-function) > (dolist (topic (gnus-topic-list)) > - (when (and (setq match (cdr (assq 'subscribe > - (gnus-topic-parameters topic)))) > + (when (and (setq match (car-safe (cdr (assq 'subscribe > + (gnus-topic-parameters topic))))) > (string-match match newsgroup)) > ;; Just subscribe the group. > (gnus-subscribe-alphabetically newsgroup) > --------------------------- cut here --------------------------- > > With these two fixes, it all now seems to work. This is NOT a fix. The topic parameters should be something like ((subscribe . "nnslashdot:")) instead of ((subscribe "nnslashdot:")) If you are not sure what it is, use `G c' instead of `G p'. ShengHuo