Re: two bugs in Gnus (*Subject* buffer threading; ESC-s searching)

[Shenghuo ZHU <zsh@cs.rochester.edu>]

[-- Attachment #1: Type: text/plain, Size: 1268 bytes --]

>>>>> "Oren" == Oren Patashnik <op@CS.Stanford.EDU> writes:

Oren> I just installed Redhat Linux 6.1, with Emacs 20.4.1, Gnus v5.7.  I've
Oren> noticed over the last few days two bugs that show up occasionally.

[...]


Oren> The second bug is a bit more annoying.  When I type ESC-s to
Oren> search for, for example, the string "bib", I get apparently
Oren> bizarre behavior.  It seems that when the string I'm searching
Oren> for is both in the header and also the first line of the body of
Oren> the article, ESC-s finds the first occurrence (in the header),
Oren> then a subsequent ESC-s finds the occurrence in the first line
Oren> of the body, *but* then subsequent ESC-s's keep finding that
Oren> first-body-line occurrence.  (To circumvent this bug I have to
Oren> switch to the *Article* buffer, move the point past that first
Oren> line, then switch back to the *Subject* buffer, then continue
Oren> with my ESC-s's.)  Here's an example article for which the bug
Oren> occurs:

[...]

Finally fixed. A kind of window-point and point bug.

The patch has been committed to the CVS of the current beta version of
Gnus.

-- 
Shenghuo

1999-11-02 17:28:33  Shenghuo ZHU  <zsh@cs.rochester.edu>

	* gnus-sum.el (gnus-summary-search-article): Fix loop search bug.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 97-120.diff --]
[-- Type: text/x-patch, Size: 892 bytes --]

Index: gnus-sum.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/gnus-sum.el,v
retrieving revision 5.69
diff -u -r5.69 gnus-sum.el
--- gnus-sum.el	1999/10/29 21:28:41	5.69
+++ gnus-sum.el	1999/11/02 22:27:49
@@ -6921,6 +6921,7 @@
   (require 'gnus-async)
   (require 'gnus-art)
   (let ((gnus-select-article-hook nil)	;Disable hook.
+	(gnus-article-prepare-hook nil)
 	(gnus-mark-article-hook nil)	;Inhibit marking as read.
 	(gnus-use-article-prefetch nil)
 	(gnus-xmas-force-redisplay nil)	;Inhibit XEmacs redisplay.
@@ -6947,6 +6948,9 @@
 	       (get-buffer-window (current-buffer))
 	       (point))
 	      (forward-line 1)
+	      (set-window-point
+	       (get-buffer-window (current-buffer))
+	       (point))
 	      (set-buffer sum)
 	      (setq point (point)))
 	  ;; We didn't find it, so we go to the next article.