Gnus development mailing list
 help / color / mirror / Atom feed
From: Shenghuo ZHU <zsh@cs.rochester.edu>
Cc: Lars Magne Ingebrigtsen <bugs@gnus.org>
Subject: Re: Bug: Buttonization
Date: 09 Sep 1999 16:42:06 -0400	[thread overview]
Message-ID: <5bu2p33jhd.fsf@giga.cs.rochester.edu> (raw)
In-Reply-To: Shenghuo ZHU's message of "09 Sep 1999 16:36:27 -0400"

[-- Attachment #1: Type: text/plain, Size: 230 bytes --]


Fixed by this patch.

Shenghuo

1999-09-09  Shenghuo ZHU  <zsh@cs.rochester.edu>

	* gnus-art.el (gnus-article-add-buttons): Don't delete markers out
	of restricted region.
	(gnus-mime-display-single): Set beg at correct point.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 96-zsh5.diff --]
[-- Type: text/x-patch, Size: 1584 bytes --]

--- ../../pgnus-sent/lisp/gnus-art.el	Thu Sep  2 15:23:33 1999
+++ gnus-art.el	Thu Sep  9 16:13:26 1999
@@ -3146,7 +3146,8 @@
 	  (cond
 	   (display
 	    (when move
-	      (forward-line -2))
+	      (forward-line -2)
+	      (setq beg (point)))
 	    (let ((mail-parse-charset gnus-newsgroup-charset)
 		  (mail-parse-ignored-charsets 
 		   (save-excursion (set-buffer gnus-summary-buffer)
@@ -3155,7 +3156,8 @@
 	    (goto-char (point-max)))
 	   ((and text not-attachment)
 	    (when move
-	      (forward-line -2))
+	      (forward-line -2)
+	      (setq beg (point)))
 	    (gnus-article-insert-newline)
 	    (mm-insert-inline handle (mm-get-part handle))
 	    (goto-char (point-max))))
@@ -4081,14 +4083,17 @@
 	  (alist gnus-button-alist)
 	  beg entry regexp)
       ;; Remove all old markers.
-      (let (marker entry)
+      (let (marker entry new-list)
 	(while (setq marker (pop gnus-button-marker-list))
-	  (goto-char marker)
-	  (when (setq entry (gnus-button-entry))
-	    (put-text-property (match-beginning (nth 1 entry))
-			       (match-end (nth 1 entry))
-			       'gnus-callback nil))
-	  (set-marker marker nil)))
+	  (if (or (< marker (point-min)) (>= marker (point-max)))
+	      (push marker new-list)
+	    (goto-char marker)
+	    (when (setq entry (gnus-button-entry))
+	      (put-text-property (match-beginning (nth 1 entry))
+				 (match-end (nth 1 entry))
+				 'gnus-callback nil))
+	    (set-marker marker nil)))
+	(setq gnus-button-marker-list new-list))
       ;; We skip the headers.
       (article-goto-body)
       (setq beg (point))

             reply	other threads:[~1999-09-09 20:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
1999-09-09 20:42 Shenghuo ZHU [this message]
  -- strict thread matches above, loose matches on Subject: below --
1999-09-09 20:37 Shenghuo ZHU

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5bu2p33jhd.fsf@giga.cs.rochester.edu \
    --to=zsh@cs.rochester.edu \
    --cc=bugs@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).