From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/32151 Path: main.gmane.org!not-for-mail From: Rod Whitby Newsgroups: gmane.emacs.gnus.general Subject: Re: expiry-target Date: 14 Aug 2000 08:59:49 +0930 Organization: Motorola Australia Software Centre Sender: owner-ding@hpc.uh.edu Message-ID: <64itt4eo42.fsf@a11375-rw.asc.corp.mot.com> References: NNTP-Posting-Host: coloc-standby.netfonds.no Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: main.gmane.org 1035168468 18088 80.91.224.250 (21 Oct 2002 02:47:48 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Mon, 21 Oct 2002 02:47:48 +0000 (UTC) Cc: Lars Magne Ingebrigtsen Return-Path: Original-Received: from spinoza.math.uh.edu (spinoza.math.uh.edu [129.7.128.18]) by mailhost.sclp.com (Postfix) with ESMTP id EC8D7D051E for ; Sun, 13 Aug 2000 19:36:11 -0400 (EDT) Original-Received: from sina.hpc.uh.edu (lists@Sina.HPC.UH.EDU [129.7.3.5]) by spinoza.math.uh.edu (8.9.1/8.9.1) with ESMTP id SAC11659; Sun, 13 Aug 2000 18:36:04 -0500 (CDT) Original-Received: by sina.hpc.uh.edu (TLB v0.09a (1.20 tibbs 1996/10/09 22:03:07)); Sun, 13 Aug 2000 18:33:58 -0500 (CDT) Original-Received: from mailhost.sclp.com (postfix@66-209.196.61.interliant.com [209.196.61.66] (may be forged)) by sina.hpc.uh.edu (8.9.3/8.9.3) with ESMTP id SAA10627 for ; Sun, 13 Aug 2000 18:33:46 -0500 (CDT) Original-Received: from motgate2.mot.com (motgate2.mot.com [136.182.1.10]) by mailhost.sclp.com (Postfix) with ESMTP id 0F167D051E; Sun, 13 Aug 2000 19:34:15 -0400 (EDT) Original-Received: [from pobox.mot.com (pobox.mot.com [129.188.137.100]) by motgate2.mot.com (motgate2 2.1) with ESMTP id QAA27417; Sun, 13 Aug 2000 16:34:05 -0700 (MST)] Original-Received: [from fraser.asc.corp.mot.com (fraser.asc.corp.mot.com [217.1.104.8]) by pobox.mot.com (MOT-pobox 2.0) with ESMTP id QAA19192; Sun, 13 Aug 2000 16:34:00 -0700 (MST)] Original-Received: from a11375-rw.asc.corp.mot.com.asc.corp.mot.com (a11375-rw [217.1.106.149]) by fraser.asc.corp.mot.com (8.8.7/8.8.7) with SMTP id JAA05190; Mon, 14 Aug 2000 09:03:55 +0930 (CST) Original-To: ding@gnus.org In-Reply-To: Harry Putnam's message of "13 Aug 2000 12:10:15 -0700" Original-Lines: 136 User-Agent: Gnus/5.0808 (Gnus v5.8.8) XEmacs/21.2 (Nike) Precedence: list X-Majordomo: 1.94.jlt7 Xref: main.gmane.org gmane.emacs.gnus.general:32151 X-Report-Spam: http://spam.gmane.org/gmane.emacs.gnus.general:32151 Harry Putnam writes: > I only have nnml groups but haven't been able to get this working. > > Can you supply an example of the necessary var settings and the code > that would be appropriate in group params. Maybe even replete with > some of the good Lars humor. > > I've requested examples both here and on gnu.emacs.gnus. As have a > number of other people. None have been forthcoming, making me think > there aren't many people, possibly none using this feature. > > A few posters responded with messages saying this feature doesn't work > for them. And I've twice now supplied the patches which makes it work. Are my messages getting through to the list, or are they going into a black hole somewhere ? Harry or Lars, can you please reply to me personally if you see this message on the list. I've CC'd Lars just in case there is something which is stopping my messages getting to the list. The functionality of setting nnmail-expiry-target to a string (i.e. a group to which the expired articles should be moved, instead of being deleted) just plain does not work. Therefore, there must be no-one but me using it (and no-one but Harry trying to use it) :-) Anyway, here's some patches (against a pretty recent snapshot, and I don't think anything around them has changed since) that do the following: 1/ [gnus-sum.el, gnus-summary-expire-articles] Fix the handling of expiry-target group parameters. 2/ [nnml.el, nnml-request-expire-articles] Fix the calls to nnml-request-article (the filename was being passed instead of the article number) and nnmail-expiry-target-group (nnml-current-directory is changed by nnml-request-accept-article, causing it to be incorrect for the next article to be expired). 3/ [nnmail.el, nnmail-expiry-target-group] Fix the call to gnus-request-accept-article so that body encoding is *not* done. Encoding is not done on incoming mail, so why should it be done on expired mail? This is my first patch submission to the ding mailing list, so please let me know if I should have submitted these in another format (in particular, how do you get the nice ChangeLog entries?), and also how I should proceed in getting these checked into CVS. For those interested, the reason why I found these problems is because I have just set up my nnml:INBOX to expire to a nnml:DELETED folder immediately, and then the nnml:DELETED folder really deletes the messages after a long time. Sort of like the Trash folder in Netscape, only better :-) Now I can set display to 'all in my nnml:INBOX group parameters and use the tick marks properly, while still seeing my other unfiled mail when I enter the folder normally. diff -c /gnu/XEmacs/site-packages/gnus/lisp/gnus-sum.el~ /gnu/XEmacs/site-packages/gnus/lisp/gnus-sum.el *** /gnu/XEmacs/site-packages/gnus/lisp/gnus-sum.el~ Tue Jul 25 05:56:17 2000 --- /gnu/XEmacs/site-packages/gnus/lisp/gnus-sum.el Tue Jul 25 05:56:17 2000 *************** *** 7682,7687 **** --- 7682,7690 ---- (expiry-wait (if now 'immediate (gnus-group-find-parameter gnus-newsgroup-name 'expiry-wait))) + (nnmail-expiry-target + (or (gnus-group-find-parameter gnus-newsgroup-name 'expiry-target) + nnmail-expiry-target)) es) (when expirable ;; There are expirable articles in this group, so we run them diff -c /gnu/XEmacs/site-packages/gnus/lisp/nnml.el~ /gnu/XEmacs/site-packages/gnus/lisp/nnml.el *** /gnu/XEmacs/site-packages/gnus/lisp/nnml.el~ Tue Jul 25 05:07:35 2000 --- /gnu/XEmacs/site-packages/gnus/lisp/nnml.el Tue Jul 25 05:07:35 2000 *************** *** 289,300 **** ;; Allow a special target group. (unless (eq nnmail-expiry-target 'delete) (with-temp-buffer ! (nnml-request-article article group server (current-buffer)) ! (nnmail-expiry-target-group ! nnmail-expiry-target group))) (nnheader-message 5 "Deleting article %s in %s" ! article group) (condition-case () (funcall nnmail-delete-file-function article) (file-error --- 289,301 ---- ;; Allow a special target group. (unless (eq nnmail-expiry-target 'delete) (with-temp-buffer ! (nnml-request-article number group server (current-buffer)) ! (let ((nnml-current-directory nil)) ! (nnmail-expiry-target-group ! nnmail-expiry-target group)))) (nnheader-message 5 "Deleting article %s in %s" ! number group) (condition-case () (funcall nnmail-delete-file-function article) (file-error diff -c /gnu/XEmacs/site-packages/gnus/lisp/nnmail.el~ /gnu/XEmacs/site-packages/gnus/lisp/nnmail.el *** /gnu/XEmacs/site-packages/gnus/lisp/nnmail.el~ Tue Jul 25 05:08:51 2000 --- /gnu/XEmacs/site-packages/gnus/lisp/nnmail.el Tue Jul 25 05:08:51 2000 *************** *** 1610,1616 **** (when (nnheader-functionp target) (setq target (funcall target group))) (unless (eq target 'delete) ! (gnus-request-accept-article target))) (defun nnmail-check-syntax () "Check (and modify) the syntax of the message in the current buffer." --- 1610,1616 ---- (when (nnheader-functionp target) (setq target (funcall target group))) (unless (eq target 'delete) ! (gnus-request-accept-article target nil nil t))) (defun nnmail-check-syntax () "Check (and modify) the syntax of the message in the current buffer." -- -- Rod Whitby, Snr Staff Engr, Electronic Design Automation -- -- Motorola Australia Software Centre - Adelaide, Australia -- -- Phone: +61 8 8168 3526, Fax: +61 8 8168 3501, -- -- Baby Photos: --