From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/62044 Path: news.gmane.org!not-for-mail From: Bill Wohler Newsgroups: gmane.mail.mh-e.devel,gmane.emacs.gnus.general Subject: Re: Sharing mail icons between MH-E and Gnus Date: Mon, 20 Feb 2006 14:53:10 -0800 Organization: Newt Software Message-ID: <6909.1140475990@olgas.newt.com> References: <28928.1129483226@olgas.newt.com> <30678.1129563148@olgas.newt.com> <16231.1140316818@olgas.newt.com> NNTP-Posting-Host: main.gmane.org X-Trace: sea.gmane.org 1140476058 28619 80.91.229.2 (20 Feb 2006 22:54:18 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 20 Feb 2006 22:54:18 +0000 (UTC) Original-X-From: mh-e-devel-admin@lists.sourceforge.net Mon Feb 20 23:54:11 2006 Return-path: Envelope-to: gmmd-mh-e-devel@m.gmane.org Original-Received: from lists-outbound.sourceforge.net ([66.35.250.225]) by ciao.gmane.org with esmtp (Exim 4.43) id 1FBJut-0007PF-FJ for gmmd-mh-e-devel@m.gmane.org; Mon, 20 Feb 2006 23:54:05 +0100 Original-Received: from sc8-sf-list1-b.sourceforge.net (sc8-sf-list1-b.sourceforge.net [10.3.1.7]) by sc8-sf-spam1.sourceforge.net (Postfix) with ESMTP id B21CD33E56; Mon, 20 Feb 2006 14:54:02 -0800 (PST) Original-Received: from sc8-sf-mx1-b.sourceforge.net ([10.3.1.91] helo=mail.sourceforge.net) by sc8-sf-list1.sourceforge.net with esmtp (Exim 4.30) id 1FBJuE-00050k-H4 for mh-e-devel@lists.sourceforge.net; Mon, 20 Feb 2006 14:53:22 -0800 Original-Received: from [70.85.162.231] (helo=tassie.newt.com) by mail.sourceforge.net with esmtp (Exim 4.44) id 1FBJuC-0000EU-EB for mh-e-devel@lists.sourceforge.net; Mon, 20 Feb 2006 14:53:22 -0800 Original-Received: from olgas.newt.com (c-67-161-47-42.hsd1.ca.comcast.net [67.161.47.42]) by tassie.newt.com (Postfix) with ESMTP id CB0811D0A9E; Mon, 20 Feb 2006 14:50:35 -0800 (PST) Original-Received: by olgas.newt.com (Postfix, from userid 1000) id E2C381700F; Mon, 20 Feb 2006 14:53:10 -0800 (PST) Original-Received: from olgas.newt.com (localhost [127.0.0.1]) by olgas.newt.com (Postfix) with ESMTP id DC60F16FA8; Mon, 20 Feb 2006 14:53:10 -0800 (PST) Original-To: mh-e-devel@lists.sourceforge.net, ding@gnus.org In-Reply-To: Reiner Steib's message of Mon, 20 Feb 2006 22:19:47 +0100. X-Mailer: MH-E 7.92+cvs; nmh 1.1; GNU Emacs 22.0.50.7 X-Image-URL: http://www.newt.com/wohler/images/bill-diving.png Mail-Followup-To: mh-e-devel@lists.sourceforge.net, ding@gnus.org X-Spam-Score: 1.0 (+) X-Spam-Report: Spam Filtering performed by sourceforge.net. See http://spamassassin.org/tag/ for more details. Report problems to http://sf.net/tracker/?func=add&group_id=1&atid=200001 1.0 FORGED_RCVD_HELO Received: contains a forged HELO Original-Sender: mh-e-devel-admin@lists.sourceforge.net Errors-To: mh-e-devel-admin@lists.sourceforge.net X-BeenThere: mh-e-devel@lists.sourceforge.net X-Mailman-Version: 2.0.9-sf.net Precedence: bulk List-Unsubscribe: , List-Id: Forum for the MH-E developers List-Post: List-Help: List-Subscribe: , List-Archive: X-Original-Date: Mon, 20 Feb 2006 14:53:10 -0800 Xref: news.gmane.org gmane.mail.mh-e.devel:11707 gmane.emacs.gnus.general:62044 Archived-At: Reiner Steib wrote: > I don't like that `mh-image-load-path' changes the variables > `load-path' or `image-load-path'. I'm not sure I agree. Taking this argument to an extreme conclusion, both load-path and image-load-path would always be empty. Leaving the path to our images on these paths makes it more clear to the user (or developer) where the images came from, if that needs to be discovered. It's also conceivable that using a temporary load-path/image-load-path might invalidate image caching schemes. > Assume you have unbundled versions > of Gnus and MH-E installed using Emacs 21. Which path should win, if > we both use the same variable? And what if the user adds his own images to image-load-path (if he defined a theme, if you will) and expects to see his images rather than yours? Since you didn't leave your path on the image-load-path, he would be confused since he wouldn't see where they came from. Hmmm, this argues that we would want prepend the default Emacs path (since a newer Gnus/MH-E package might have newer images than the one distributed with an old version of Emacs) and append to any user-defined paths (since the user is always right). Is that possible? At any rate, since we're coordinating now, those icons will probably be the same anyway, so I don't think that this will be much of a problem. > (defmacro gmm-defun-compat (name function arg-list &rest body) We've borrowed so much from Gnus, I'd be tickled pink if Gnus borrowed from MH-E ;-). > (defun gmm-image-load-path (library &optional image path) For the generalized function, we might want to make IMAGE non-optional so that we don't have MH-E and Gnus icons in the code. > ;; Return augmented `image-load-path' or `load-path'. > (cond ((and path (symbolp path)) > (nconc (list gmm-image-load-path) (symbol-value path))) > (t > (nconc (list gmm-image-load-path) load-path)))) Now it's my turn not to like the code ;-). This doesn't use image-load-path if it exists. It can add the image directory even if it already exists on path. I was going to argue against the path argument, but it would be consistent with image-search-load-path. I think it's a good idea, however, to return the modified list. I guess the big question is whether to modify image-load-path (load-path) or not. It would be good for a few others to weigh in. It would be good to solicit opinions from the folks on emacs-devel too. I'll do that. -- Bill Wohler http://www.newt.com/wohler/ GnuPG ID:610BD9AD Maintainer of comp.mail.mh FAQ and MH-E. Vote Libertarian! If you're passed on the right, you're in the wrong lane. ------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Do you grep through log files for problems? Stop! Download the new AJAX search engine that makes searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642