From mboxrd@z Thu Jan  1 00:00:00 1970
X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/28242
Path: main.gmane.org!not-for-mail
From: Bill Perry <wmperry@aventail.com>
Newsgroups: gmane.emacs.gnus.general
Subject: Bug in nntp-open-ssl-stream
Date: Tue, 14 Dec 1999 12:53:14 -0800
Sender: owner-ding@hpc.uh.edu
Message-ID: <71DE5436FE60D311B8F60050043207B544B05A@leo.in.aventail.com>
NNTP-Posting-Host: coloc-standby.netfonds.no
Mime-Version: 1.0
Content-Type: text/plain
X-Trace: main.gmane.org 1035165125 28867 80.91.224.250 (21 Oct 2002 01:52:05 GMT)
X-Complaints-To: usenet@main.gmane.org
NNTP-Posting-Date: Mon, 21 Oct 2002 01:52:05 +0000 (UTC)
Return-Path: <owner-ding@hpc.uh.edu>
Original-Received: from farabi.math.uh.edu (farabi.math.uh.edu [129.7.128.57])
	by sclp3.sclp.com (8.8.5/8.8.5) with ESMTP id PAA18350
	for <jason@mailhost.sclp.com>; Tue, 14 Dec 1999 15:52:27 -0500 (EST)
Original-Received: from sina.hpc.uh.edu (lists@Sina.HPC.UH.EDU [129.7.3.5])
	by farabi.math.uh.edu (8.9.3/8.9.1) with ESMTP id OAB01882;
	Tue, 14 Dec 1999 14:51:36 -0600 (CST)
Original-Received: by sina.hpc.uh.edu (TLB v0.09a (1.20 tibbs 1996/10/09 22:03:07)); Tue, 14 Dec 1999 14:51:45 -0600 (CST)
Original-Received: from sclp3.sclp.com (root@sclp3.sclp.com [204.252.123.139])
	by sina.hpc.uh.edu (8.9.3/8.9.3) with ESMTP id OAA10733
	for <ding@hpc.uh.edu>; Tue, 14 Dec 1999 14:51:36 -0600 (CST)
Original-Received: from newman.aventail.com (newman.aventail.com [216.207.80.1])
	by sclp3.sclp.com (8.8.5/8.8.5) with ESMTP id PAA18316
	for <ding@gnus.org>; Tue, 14 Dec 1999 15:51:14 -0500 (EST)
Original-Received: from leo.in.aventail.com (leo.in.aventail.com [192.168.1.136])
	by newman.aventail.com (8.9.3/8.9.3) with ESMTP id MAA17583
	for <ding@gnus.org>; Tue, 14 Dec 1999 12:51:12 -0800
Original-Received: by leo.in.aventail.com with Internet Mail Service (5.5.2448.0)
	id <Y54PWMVW>; Tue, 14 Dec 1999 12:53:14 -0800
Original-To: "'ding@gnus.org'" <ding@gnus.org>
X-Mailer: Internet Mail Service (5.5.2448.0)
Precedence: list
X-Majordomo: 1.94.jlt7
Xref: main.gmane.org gmane.emacs.gnus.general:28242
X-Report-Spam: http://spam.gmane.org/gmane.emacs.gnus.general:28242

There is a bug in nntp-open-ssl-stream in v5.8.3:

(defun nntp-open-ssl-stream (buffer)
  (let* ((ssl-program-arguments '("-connect" (concat host ":" service)))
	 (proc (open-ssl-stream "nntpd" buffer nntp-address
nntp-port-number)))
    (save-excursion
      (set-buffer buffer)
      (nntp-wait-for-string "^\r*20[01]")
      (beginning-of-line)
      (delete-region (point-min) (point))
      proc)))

This should NOT modify ssl-program-arguments, otherwise the latest version
of ssl.el (that uses OpenSSL by default) will fail to work, because the
's_client' parameter has been removed.

Also, the waiting for the string terminator should be removed, and we
should document that if people get garbage at the top of the buffer (the
-quiet switch I added ages ago to ssleay has been broken in openssl), they
should create a shell script like:

#!/bin/sh
exec 2> /dev/null
exec openssl "$@"

I was thinking of distributing an 'emacs.openssl' script or something like
that as part of ssl.el and making it use it by default.  What would be
ideal is if someone outside the united states would volunteer to
re-implement my SSL patches to Emacs from ages ago.

-Bill P.