From: Jake Colman <colman@ppllc.com>
To: Simon Josefsson <simon@josefsson.org>
Cc: "nathanw\@MIT.EDU" <nathanw@MIT.EDU>,
Ted Zlatanov <tzz@lifelogs.com>,
Michael Harnois <mdharnois@gmail.com>,
"ding\@gnus.org" <ding@gnus.org>
Subject: Re: the Exchange 2007 fix
Date: Tue, 01 Apr 2008 22:58:05 -0400 [thread overview]
Message-ID: <76zlsd55fm.fsf@dev-d01.ppllc.com> (raw)
In-Reply-To: <87zlsdurjm.fsf@mocca.josefsson.org> (Simon Josefsson's message of "Tue, 1 Apr 2008 18:41:17 -0400")
>>>>> "SJ" == Simon Josefsson <simon@josefsson.org> writes:
SJ> nathanw@MIT.EDU (Nathan J. Williams) writes:
>> Ted Zlatanov <tzz@lifelogs.com> writes:
>>
>>> On Mon, 24 Mar 2008 14:31:16 -0500 "Michael Harnois"
SJ> <mdharnois@gmail.com> wrote:
>>>
MH> It doesn't seem to be the only fix needed, but I think it's the Big
SJ> Kahuna.
MH> mharnois:lisp mdharnois$ diff -urN nnimap.el nnimap.el.orig
MH> --- nnimap.el 2008-03-24 14:16:40.000000000 -0500
MH> +++ nnimap.el.orig 2008-02-07 11:36:36.000000000 -0600
MH> @@ -555,7 +555,7 @@
MH> (imap-mailbox-select group examine))
MH> (let (minuid maxuid)
MH> (when (> (imap-mailbox-get 'exists) 0)
MH> - (imap-fetch "1:*" "UID" nil 'nouidfetch)
MH> + (imap-fetch "1,*" "UID" nil 'nouidfetch)
MH> (imap-message-map (lambda (uid Uid)
MH> (setq minuid (if minuid (min minuid uid) uid)
MH> maxuid (if maxuid (max maxuid uid) uid)))
>>>
>>> Since it was a tiny fix I comitted it. It seems to work fine with
>>> Exchange 2007 and Courier IMAP.
>>
>> Please see: http://comments.gmane.org/gmane.emacs.gnus.general/65855
>>
>> I think we can use "1,*:*" instead of "1:*" to get the min-max effect
>> without the effect of pulling down all the UIDs in the group; it's
>> what I've been using in my local copy of Gnus since December against
>> an Exchange 2007 server.
SJ> So maybe this patch would work better? However, it doesn't take care of
SJ> the imap.el problems you mentioned in that thread. Perhaps the
SJ> bug-workaround variable should be a imap.el variable rather than a
SJ> nnimap.el variable? Hm.
SJ> --- nnimap.el 01 Apr 2008 16:27:27 +0200 7.45
SJ> +++ nnimap.el 02 Apr 2008 00:38:11 +0200
SJ> @@ -568,7 +568,7 @@
SJ> (imap-mailbox-select group examine))
SJ> (let (minuid maxuid)
SJ> (when (> (imap-mailbox-get 'exists) 0)
SJ> - (imap-fetch (if nnimap-enable-minmax-bug-workaround "1:*" "1,*")
SJ> + (imap-fetch (if nnimap-enable-minmax-bug-workaround "1,*:*" "1,*")
SJ> "UID" nil 'nouidfetch)
SJ> (imap-message-map (lambda (uid Uid)
SJ> (setq minuid (if minuid (min minuid uid) uid)
I've applied this patch and it works - but I don't think I see any
performance improvement.
For example, when I enter a group with a very large number of read
messages and only 2 or 3 unread messages, I see the following message
for an extended period of time:
nnimap: Updating info for nnimap+exchange-d01:INBOX/Principia...
For the record, I am not using nnimap.el from cvs. Instead I patched my
own copy of nnimap.el from two weeks ago to use "1,*:*". I don't think
there is any other substantive change that I missed.
--
Jake Colman
Director of Software Development
Principia Partners LLC
101 West Elm Street
Suite 620
Conshohocken, PA 19428
+1 (610) 755-9786
www.principiapartners.com
next prev parent reply other threads:[~2008-04-02 2:58 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-24 19:31 Michael Harnois
2008-03-28 14:40 ` Ted Zlatanov
2008-04-01 22:30 ` Nathan J. Williams
2008-04-01 22:41 ` Simon Josefsson
2008-04-02 2:58 ` Jake Colman [this message]
2008-04-02 14:29 ` Simon Josefsson
2008-04-02 14:11 ` Ted Zlatanov
2008-04-02 14:50 ` Simon Josefsson
2008-04-03 13:11 ` Ted Zlatanov
2008-04-03 19:37 ` Reiner Steib
2008-04-03 20:50 ` Jake Colman
2008-04-08 21:14 ` Ted Zlatanov
2008-04-01 23:03 ` Michael D. Harnois
2008-04-02 2:59 ` Jake Colman
2008-04-02 14:31 ` Simon Josefsson
2008-04-02 14:48 ` Simon Josefsson
2008-04-02 22:13 ` Jake Colman
2008-04-03 13:07 ` Ted Zlatanov
2008-04-03 15:22 ` Jake Colman
2008-04-03 15:28 ` Simon Josefsson
2008-04-22 11:37 ` Steinar Bang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76zlsd55fm.fsf@dev-d01.ppllc.com \
--to=colman@ppllc.com \
--cc=ding@gnus.org \
--cc=mdharnois@gmail.com \
--cc=nathanw@MIT.EDU \
--cc=simon@josefsson.org \
--cc=tzz@lifelogs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).