From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/66649 Path: news.gmane.org!not-for-mail From: Jake Colman Newsgroups: gmane.emacs.gnus.general Subject: Re: the Exchange 2007 fix Date: Tue, 01 Apr 2008 22:58:05 -0400 Message-ID: <76zlsd55fm.fsf@dev-d01.ppllc.com> References: <86wsnmvrmx.fsf@lifelogs.com> <87zlsdurjm.fsf@mocca.josefsson.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1207105154 24564 80.91.229.12 (2 Apr 2008 02:59:14 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 2 Apr 2008 02:59:14 +0000 (UTC) Cc: "nathanw\@MIT.EDU" , Ted Zlatanov , Michael Harnois , "ding\@gnus.org" To: Simon Josefsson Original-X-From: ding-owner+M15133@lists.math.uh.edu Wed Apr 02 04:59:45 2008 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from util0.math.uh.edu ([129.7.128.18]) by lo.gmane.org with esmtp (Exim 4.50) id 1JgtCR-0004pU-8s for ding-account@gmane.org; Wed, 02 Apr 2008 04:59:43 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by util0.math.uh.edu with smtp (Exim 4.63) (envelope-from ) id 1JgtBZ-0008Aq-3F; Tue, 01 Apr 2008 21:58:49 -0500 Original-Received: from mx1.math.uh.edu ([129.7.128.32]) by util0.math.uh.edu with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1JgtBX-0008Ad-Rf for ding@lists.math.uh.edu; Tue, 01 Apr 2008 21:58:47 -0500 Original-Received: from quimby.gnus.org ([80.91.231.51]) by mx1.math.uh.edu with esmtp (Exim 4.67) (envelope-from ) id 1JgtBR-0001Sm-72 for ding@lists.math.uh.edu; Tue, 01 Apr 2008 21:58:47 -0500 Original-Received: from [69.7.239.34] (helo=dev-d01.ppllc.com) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1JgtBa-00050H-00 for ; Wed, 02 Apr 2008 04:58:50 +0200 Original-Received: from dev-d01.ppllc.com (localhost [127.0.0.1]) by dev-d01.ppllc.com (8.13.8+Sun/8.13.8) with ESMTP id m322w83l003233; Tue, 1 Apr 2008 22:58:08 -0400 (EDT) Original-Received: (from colman@localhost) by dev-d01.ppllc.com (8.13.8+Sun/8.13.8/Submit) id m322w6Vp003232; Tue, 1 Apr 2008 22:58:06 -0400 (EDT) X-Authentication-Warning: dev-d01.ppllc.com: colman set sender to colman@ppllc.com using -f X-Attribution: Jake X-URL: http://www.principiapartners.com In-Reply-To: <87zlsdurjm.fsf@mocca.josefsson.org> (Simon Josefsson's message of "Tue, 1 Apr 2008 18:41:17 -0400") User-Agent: Gnus/5.110007 (No Gnus v0.7) XEmacs/21.4.17 (usg-unix-v, no MULE) X-Spam-Score: -2.5 (--) List-ID: Precedence: bulk Xref: news.gmane.org gmane.emacs.gnus.general:66649 Archived-At: >>>>> "SJ" == Simon Josefsson writes: SJ> nathanw@MIT.EDU (Nathan J. Williams) writes: >> Ted Zlatanov writes: >> >>> On Mon, 24 Mar 2008 14:31:16 -0500 "Michael Harnois" SJ> wrote: >>> MH> It doesn't seem to be the only fix needed, but I think it's the Big SJ> Kahuna. MH> mharnois:lisp mdharnois$ diff -urN nnimap.el nnimap.el.orig MH> --- nnimap.el 2008-03-24 14:16:40.000000000 -0500 MH> +++ nnimap.el.orig 2008-02-07 11:36:36.000000000 -0600 MH> @@ -555,7 +555,7 @@ MH> (imap-mailbox-select group examine)) MH> (let (minuid maxuid) MH> (when (> (imap-mailbox-get 'exists) 0) MH> - (imap-fetch "1:*" "UID" nil 'nouidfetch) MH> + (imap-fetch "1,*" "UID" nil 'nouidfetch) MH> (imap-message-map (lambda (uid Uid) MH> (setq minuid (if minuid (min minuid uid) uid) MH> maxuid (if maxuid (max maxuid uid) uid))) >>> >>> Since it was a tiny fix I comitted it. It seems to work fine with >>> Exchange 2007 and Courier IMAP. >> >> Please see: http://comments.gmane.org/gmane.emacs.gnus.general/65855 >> >> I think we can use "1,*:*" instead of "1:*" to get the min-max effect >> without the effect of pulling down all the UIDs in the group; it's >> what I've been using in my local copy of Gnus since December against >> an Exchange 2007 server. SJ> So maybe this patch would work better? However, it doesn't take care of SJ> the imap.el problems you mentioned in that thread. Perhaps the SJ> bug-workaround variable should be a imap.el variable rather than a SJ> nnimap.el variable? Hm. SJ> --- nnimap.el 01 Apr 2008 16:27:27 +0200 7.45 SJ> +++ nnimap.el 02 Apr 2008 00:38:11 +0200 SJ> @@ -568,7 +568,7 @@ SJ> (imap-mailbox-select group examine)) SJ> (let (minuid maxuid) SJ> (when (> (imap-mailbox-get 'exists) 0) SJ> - (imap-fetch (if nnimap-enable-minmax-bug-workaround "1:*" "1,*") SJ> + (imap-fetch (if nnimap-enable-minmax-bug-workaround "1,*:*" "1,*") SJ> "UID" nil 'nouidfetch) SJ> (imap-message-map (lambda (uid Uid) SJ> (setq minuid (if minuid (min minuid uid) uid) I've applied this patch and it works - but I don't think I see any performance improvement. For example, when I enter a group with a very large number of read messages and only 2 or 3 unread messages, I see the following message for an extended period of time: nnimap: Updating info for nnimap+exchange-d01:INBOX/Principia... For the record, I am not using nnimap.el from cvs. Instead I patched my own copy of nnimap.el from two weeks ago to use "1,*:*". I don't think there is any other substantive change that I missed. -- Jake Colman Director of Software Development Principia Partners LLC 101 West Elm Street Suite 620 Conshohocken, PA 19428 +1 (610) 755-9786 www.principiapartners.com