Re: Fwd: [PATCH]: gnus: use correct GPG hash algorithm in 'micalg'

[Daiki Ueno <ueno@unixuser.org>]

[-- Attachment #1.1: Type: text/plain, Size: 834 bytes --]

>>>>> In <ilu64umn471.fsf@latte.josefsson.org> 
>>>>>	Simon Josefsson <jas@extundo.com> wrote:
> Daiki Ueno <ueno@unixuser.org> writes:

> > I'm not sure that the micalg= parameter is still mandatory, while the
> > hash algorithm used is embedded in OpenPGP packets.

> Sadly RFC 1847 require the presence of micalg, it seems.  A wart, but
> difficult to fix at this point.  We should populate it with correct
> information.

> > It can be obtained by using the builtin packet parser (pgg-parse),
> > without depending on --status-fd output of GnuPG.

> Very nice!  Would you mind proposing a patch for mml2016.el that uses
> this approach?

No, I made the patch attached below.

I'm sending this mail with DSA & RIPEMD160.  If the patch works as
expected, micalg=ripemd160 appears in the Content-Type: header.


[-- Attachment #1.2: micalg.diff --]
[-- Type: text/plain, Size: 2442 bytes --]

? micalg.diff
Index: lisp/mml2015.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/mml2015.el,v
retrieving revision 7.9
diff -u -r7.9 mml2015.el
--- lisp/mml2015.el	17 Jul 2005 14:10:38 -0000	7.9
+++ lisp/mml2015.el	5 Aug 2005 07:58:19 -0000
@@ -645,7 +645,8 @@
   (autoload 'pgg-decrypt-region "pgg")
   (autoload 'pgg-verify-region "pgg")
   (autoload 'pgg-sign-region "pgg")
-  (autoload 'pgg-encrypt-region "pgg"))
+  (autoload 'pgg-encrypt-region "pgg")
+  (autoload 'pgg-parse-armor "pgg-parse"))
 
 (defun mml2015-pgg-decrypt (handle ctl)
   (catch 'error
@@ -813,15 +814,23 @@
   (let ((pgg-errors-buffer mml2015-result-buffer)
 	(boundary (mml-compute-boundary cont))
 	(pgg-default-user-id (or (message-options-get 'mml-sender)
-				 pgg-default-user-id)))
+				 pgg-default-user-id))
+	entry)
     (unless (pgg-sign-region (point-min) (point-max))
       (pop-to-buffer mml2015-result-buffer)
       (error "Sign error"))
     (goto-char (point-min))
     (insert (format "Content-Type: multipart/signed; boundary=\"%s\";\n"
 		    boundary))
-      ;;; FIXME: what is the micalg?
-    (insert "\tmicalg=pgp-sha1; protocol=\"application/pgp-signature\"\n")
+    (if (setq entry (assq 2 (pgg-parse-armor
+			     (with-current-buffer pgg-output-buffer
+			       (buffer-string)))))
+	(setq entry (assq 'hash-algorithm (cdr entry))))
+    (insert (format "\tmicalg=%s; "
+		    (if (cdr entry)
+			(downcase (format "pgp-%s" (cdr entry)))
+		      "pgp-sha1")))
+    (insert "protocol=\"application/pgp-signature\"\n")
     (insert (format "\n--%s\n" boundary))
     (goto-char (point-max))
     (insert (format "\n--%s\n" boundary))
Index: lisp/pgg-parse.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/pgg-parse.el,v
retrieving revision 7.6
diff -u -r7.6 pgg-parse.el
--- lisp/pgg-parse.el	5 Jul 2005 22:34:49 -0000	7.6
+++ lisp/pgg-parse.el	5 Aug 2005 07:58:19 -0000
@@ -56,7 +56,8 @@
 	  (cons (sexp :tag "Number") (sexp :tag "Type"))))
 
 (defcustom pgg-parse-hash-algorithm-alist
-  '((1 . MD5) (2 . SHA1) (3 . RIPEMD160) (5 . MD2))
+  '((1 . MD5) (2 . SHA1) (3 . RIPEMD160) (5 . MD2) (8 . SHA256) (9 . SHA384)
+    (10 . SHA512))
   "Alist of the assigned number to the cryptographic hash algorithm."
   :group 'pgg-parse
   :type '(repeat

[-- Attachment #1.3: Type: text/plain, Size: 29 bytes --]


Regards,
-- 
Daiki Ueno

[-- Attachment #2: Type: application/pgp-signature, Size: 188 bytes --]