Re: Gnus 5.10.6 problems with PGP/MIME (test cases)

[Daiki Ueno <ueno@unixuser.org>]

>>>>> In <89375.1139412469@juniper.net> 
>>>>>	"Mark D. Baushke" <mdb@gnu.org> wrote:
> > > Currently, `pgg-gpg-encrypt-region' doesn't seem to support raw
> > > binary data because it uses `pgg-as-lbt', which converts LF to
> > > CRLF.  Should it be simply removed?
> > 
> > Just one suggestion: This change breaks API.  So it would be safe to
> > first make sure the caller of pgg-encrypt-region (i.e. Gnus' PGP/MIME
> > code) supplies input data which have CRLF line endings and then remove
> > pgg-as-lbt.

> Doing this means that you should add the --textmode switch as the line
> endings would now be CRLF rather than being the native line ending that
> GnuPG would be expecting.

I forgot this effect of --textmode.  Then, no API compatibility issue
should arise as long as pgg-text-mode is set properly.  The attached
patch should be sufficient for Gnus.

> If you need to force CRLF or use pgg-as-lbt on the region,

pgg-as-lbt is just redundant since there is no application which
requires implicit conversion of line-endings to CRLF _and_ to mark the
data as binary.

>>>>> In <b4mzml2fa3n.fsf@jpl.org> 
>>>>>	Katsumi Yamaoka <yamaoka@jpl.org> wrote:
> >>> I attach a patch which allows users to select text-mode or binary-mode
> >>> by setting pgg-text-mode.

> >>> +(defvar pgg-text-mode nil
> >>> +  "If t, inform the recipient that the input is text.")

> >> Even if it is useful, may we make it default to t?

> > Hmm, I feel that it is natural to let the default be the same as GnuPG.

> You're right.  However, Gnus users have been using it only with
> text for a long time.

Gnus users?  People who would become happy with enabling pgg-text-mode
by default are not Gnus users but (only a few) Gnus developers.  If a
Gnus developer properly set pgg-text-mode in his code, Gnus users need
not be aware of it.

So, I think it is not worth changing it.