Gnus development mailing list
 help / color / mirror / Atom feed
From: George McNinch <gmcninch@zoho.com>
To: ding@gnus.org
Cc: Eric Abrahamsen <eric@ericabrahamsen.net>, Andrew Cohen <cohen@bu.edu>
Subject: Re: status of nnselect and gnus-search
Date: Mon, 14 Aug 2017 21:48:55 -0400	[thread overview]
Message-ID: <82h8x91tyw.fsf@noether> (raw)
In-Reply-To: <87shgt66ax.fsf@ericabrahamsen.net>

[-- Attachment #1: Type: text/plain, Size: 1880 bytes --]

Hi Eric,

Thanks for the reply.

> I didn't see this on the list, but am replying to the list...

Yes - I seem to have done something wrong with the post. Hopefully I've
fixed it this time.

> My understanding is, Andy had a certain window of time where he was
> able to work on the nnselect stuff, and that window closed before we
> were able to get anything pushed. That's a bummer, because I think the
> changes are pretty solid -- there were a couple of potential features
> that didn't get implemented, but I haven't encountered any bugs,
> either.

>> Maybe someone can briefly explain how to resolve the
>> incompatibilities?  Or maybe there is an updated way to get these
>> features?

Well, after writing, I meanwhile got stubborn and did manage to get the
"origin/scratch/gnus-search" version merged after cloning an emacs
image. (The situation arose because I needed to install on a new
machine...)

There was one issue I encountered using gnus-search and notmuch as
search engine (certain kinds of searches failed with an error message
which essentially said "(if thread ....)" is not a string"). I'm
attaching a patch (inclusion of a comma that seems to have been missing)
which fixes this trouble for me.

(Actually, I'm pretty sure I found this typo/glitch in June, fixed it,
and then forgot that I had discovered it. Should have reported it then;
sorry!)

> Then that could sit for a while, and in the meantime I would keep
> scratch/gnus-search up to date with master. When it looked like it was
> mature enough, I'd merge to master as well.

> I think we've got Lars' blessing on all this, so we should be good to
> go. Andy, if you're there -- what do you think about just taking the
> plunge? I can be available to put out fires, if necessary.

Well, I like the work; thanks! - I'm looking forward to its
inclusion...!

See below for the patch.

best,
george


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: gnus-search-patch.patch --]
[-- Type: text/x-diff, Size: 658 bytes --]

diff -u --label /usr/local/share/emacs/26.0.50/lisp/gnus/gnus-search.el.gz --label /usr/local/share/emacs/26.0.50/lisp/gnus/gnus-search-new.el /tmp/jka-com7573izb /usr/local/share/emacs/26.0.50/lisp/gnus/gnus-search-new.el
--- /usr/local/share/emacs/26.0.50/lisp/gnus/gnus-search.el.gz
+++ /usr/local/share/emacs/26.0.50/lisp/gnus/gnus-search-new.el
@@ -1750,7 +1750,7 @@
     (with-slots (switches config-file) engine
       `(,(format "--config=%s" config-file)
 	"search"
-	(if thread
+	,(if thread
 	    "--output=threads"
 	  "--output=files")
 	"--duplicate=1" ; I have found this necessary, I don't know why.

Diff finished.  Mon Aug 14 21:31:31 2017

[-- Attachment #3: Type: text/plain, Size: 67 bytes --]


-- 
-o- George McNinch
-o- http://math.tufts.edu/faculty/gmcninch

  reply	other threads:[~2017-08-15  1:48 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-15  7:38 more little nnselect things Eric Abrahamsen
2017-05-16  1:45 ` Andrew Cohen
2017-05-16 12:22   ` Eric Abrahamsen
2017-05-17  1:09     ` Andrew Cohen
2017-05-17  4:56       ` Eric Abrahamsen
     [not found]       ` <82bmnhkg75.fsf_-_@noether>
2017-08-15  0:08         ` status of nnselect and gnus-search Eric Abrahamsen
2017-08-15  1:48           ` George McNinch [this message]
2017-08-15 15:56             ` Eric Abrahamsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=82h8x91tyw.fsf@noether \
    --to=gmcninch@zoho.com \
    --cc=cohen@bu.edu \
    --cc=ding@gnus.org \
    --cc=eric@ericabrahamsen.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).