Gnus development mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Katsumi Yamaoka <yamaoka@jpl.org>
Cc: tzz@lifelogs.com, ding@gnus.org, emacs-devel@gnu.org
Subject: Re: Revision 103117 on the Emacs trunk.
Date: Sat, 05 Feb 2011 13:47:18 +0200	[thread overview]
Message-ID: <838vxuaek9.fsf@gnu.org> (raw)
In-Reply-To: <b4mk4hex0zb.fsf@jpl.org>

> From: Katsumi Yamaoka <yamaoka@jpl.org>
> Cc: Ted Zlatanov <tzz@lifelogs.com>,  emacs-devel@gnu.org,  ding@gnus.org
> Date: Sat, 05 Feb 2011 18:52:08 +0900
> 
> Eli Zaretskii <eliz@gnu.org> wrote:
> > The doc/misc/ChangeLog entry for this revision says:
> 
> > 	* Makefile.in (webhack, nowebhack): Hacks to produce for-the-web
> > 	manuals.
> 
> > but there are no such targets in doc/misc/Makefile.in, and in fact the
> > merge commit includes no changes to doc/misc/Makefile.in at all.
> 
> > What happened?
> 
> Sorry, I forgot merging a change to it.  I'll try it...

Thanks.  However, your change is just this:

  === modified file 'doc/misc/Makefile.in'
  --- doc/misc/Makefile.in        2011-01-26 08:36:39 +0000
  +++ doc/misc/Makefile.in        2011-02-05 11:23:52 +0000
  @@ -209,6 +209,12 @@ mkinfodir = @cd ${srcdir}; test -d ${inf

   info: $(INFO_TARGETS)

  +webhack: clean
  +       echo '@set WEBHACKDEVEL' > overrides.texi
  +
  +nowebhack: clean
  +       echo '@clear WEBHACKDEVEL' > overrides.texi
  +
   dvi: $(DVI_TARGETS)

I think at least the prerequisites should be fixed, for those several
manuals which now depend on overrides.texi to build (unless we go the
way I suggest below).

Also, overrides.texi is in the repository, but these two new rules
will overwrite it, and the modified overrides.texi could then easily
be committed by mistake as part of the next "bzr ci", thus propagating
a file with "@set WEBHACKDEVEL" to everyone else.  That's bad, I
think.

Finally, I believe there are shells out there which will not overwrite
an existing file with the ">" redirection; you need to remove the file
first.

Bottom line, I think it will be much better to remove overrides.texi
altogether, and then modify the `webhack' target as follows:

  webhack:
  	$(MAKE) all MAKEINFO_OPTS="-DWEBHACKDEVEL --force -I$(emacsdir)"

Could you see if this will do what you want?



  reply	other threads:[~2011-02-05 11:47 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-05  9:35 Eli Zaretskii
2011-02-05  9:52 ` Katsumi Yamaoka
2011-02-05 11:47   ` Eli Zaretskii [this message]
2011-02-05 12:16     ` Katsumi Yamaoka
2011-02-07 18:29       ` Ted Zlatanov
2011-02-08  3:49         ` Eli Zaretskii
2011-02-08  8:00           ` Peter Münster
2011-02-08  8:28             ` Eli Zaretskii
2011-02-08  8:50               ` Andreas Schwab
2011-02-08  9:06               ` Peter Münster
2011-02-08  9:28                 ` Eli Zaretskii
2011-02-08 14:33           ` -DWEBHACKDEVEL for Gnus (was: Revision 103117 on the Emacs trunk.) Ted Zlatanov
2011-02-08 15:23             ` -DWEBHACKDEVEL for Gnus Peter Münster
2011-02-05 13:08     ` Revision 103117 on the Emacs trunk Andreas Schwab
2011-02-05 14:21       ` Gnus overrides.texi and WEBHACKDEVEL (was: Revision 103117 on the Emacs trunk.) Ted Zlatanov
2011-02-05 15:12         ` Gnus overrides.texi and WEBHACKDEVEL Eli Zaretskii
2011-02-05 15:18           ` Ted Zlatanov
2011-02-05 15:39             ` Eli Zaretskii
2011-02-05 16:01               ` Ted Zlatanov
2011-02-07 19:06                 ` Eli Zaretskii
2011-02-07 19:19                   ` Ted Zlatanov
2011-02-07 19:47                   ` Eli Zaretskii
2011-02-06  6:49               ` Stephen J. Turnbull
2011-02-06 10:25                 ` Eli Zaretskii
2011-02-06 14:40                   ` Stephen J. Turnbull
2011-02-06 17:22                     ` Eli Zaretskii
2011-02-06 17:52                       ` Stephen J. Turnbull
2011-02-06 18:50                         ` Eli Zaretskii
2011-02-06 19:20                           ` Stephen J. Turnbull
2011-02-06 21:21                             ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=838vxuaek9.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=ding@gnus.org \
    --cc=emacs-devel@gnu.org \
    --cc=tzz@lifelogs.com \
    --cc=yamaoka@jpl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).