From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/76392 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel,gmane.emacs.gnus.general Subject: Re: Revision 103117 on the Emacs trunk. Date: Sat, 05 Feb 2011 13:47:18 +0200 Message-ID: <838vxuaek9.fsf@gnu.org> References: <83ei7makon.fsf@gnu.org> <83ei7makon.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1296906453 2445 80.91.229.12 (5 Feb 2011 11:47:33 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 5 Feb 2011 11:47:33 +0000 (UTC) Cc: tzz@lifelogs.com, ding@gnus.org, emacs-devel@gnu.org To: Katsumi Yamaoka Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Feb 05 12:47:29 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Plgbw-00051y-Ne for ged-emacs-devel@m.gmane.org; Sat, 05 Feb 2011 12:47:28 +0100 Original-Received: from localhost ([127.0.0.1]:40476 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Plgbw-0006TN-7h for ged-emacs-devel@m.gmane.org; Sat, 05 Feb 2011 06:47:28 -0500 Original-Received: from [140.186.70.92] (port=40440 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Plgbl-0006Sy-AU for emacs-devel@gnu.org; Sat, 05 Feb 2011 06:47:24 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Plgbg-0001Sp-Oy for emacs-devel@gnu.org; Sat, 05 Feb 2011 06:47:17 -0500 Original-Received: from mtaout20.012.net.il ([80.179.55.166]:54164) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Plgbg-0001ST-Ec for emacs-devel@gnu.org; Sat, 05 Feb 2011 06:47:12 -0500 Original-Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0LG5004007E3VJ00@a-mtaout20.012.net.il> for emacs-devel@gnu.org; Sat, 05 Feb 2011 13:47:11 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([77.124.97.124]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LG5004H47ELSJ40@a-mtaout20.012.net.il>; Sat, 05 Feb 2011 13:47:11 +0200 (IST) In-reply-to: X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-Received-From: 80.179.55.166 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:135611 gmane.emacs.gnus.general:76392 Archived-At: > From: Katsumi Yamaoka > Cc: Ted Zlatanov , emacs-devel@gnu.org, ding@gnus.org > Date: Sat, 05 Feb 2011 18:52:08 +0900 > > Eli Zaretskii wrote: > > The doc/misc/ChangeLog entry for this revision says: > > > * Makefile.in (webhack, nowebhack): Hacks to produce for-the-web > > manuals. > > > but there are no such targets in doc/misc/Makefile.in, and in fact the > > merge commit includes no changes to doc/misc/Makefile.in at all. > > > What happened? > > Sorry, I forgot merging a change to it. I'll try it... Thanks. However, your change is just this: === modified file 'doc/misc/Makefile.in' --- doc/misc/Makefile.in 2011-01-26 08:36:39 +0000 +++ doc/misc/Makefile.in 2011-02-05 11:23:52 +0000 @@ -209,6 +209,12 @@ mkinfodir = @cd ${srcdir}; test -d ${inf info: $(INFO_TARGETS) +webhack: clean + echo '@set WEBHACKDEVEL' > overrides.texi + +nowebhack: clean + echo '@clear WEBHACKDEVEL' > overrides.texi + dvi: $(DVI_TARGETS) I think at least the prerequisites should be fixed, for those several manuals which now depend on overrides.texi to build (unless we go the way I suggest below). Also, overrides.texi is in the repository, but these two new rules will overwrite it, and the modified overrides.texi could then easily be committed by mistake as part of the next "bzr ci", thus propagating a file with "@set WEBHACKDEVEL" to everyone else. That's bad, I think. Finally, I believe there are shells out there which will not overwrite an existing file with the ">" redirection; you need to remove the file first. Bottom line, I think it will be much better to remove overrides.texi altogether, and then modify the `webhack' target as follows: webhack: $(MAKE) all MAKEINFO_OPTS="-DWEBHACKDEVEL --force -I$(emacsdir)" Could you see if this will do what you want?