From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/50706 Path: main.gmane.org!not-for-mail From: kai.grossjohann@uni-duisburg.de (Kai =?iso-8859-1?q?Gro=DFjohann?=) Newsgroups: gmane.emacs.gnus.general Subject: Re: Threading wrong if showing undownloaded articles Date: Sun, 09 Mar 2003 12:19:02 +0100 Organization: University of Duisburg, Germany Sender: owner-ding@hpc.uh.edu Message-ID: <841y1gdbyx.fsf@lucy.is.informatik.uni-duisburg.de> References: <84d6ldkc9w.fsf@lucy.is.informatik.uni-duisburg.de> <84bs0wy2mx.fsf@lucy.is.informatik.uni-duisburg.de> <84llzp3hqq.fsf@lucy.is.informatik.uni-duisburg.de> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: main.gmane.org 1047208765 5091 80.91.224.249 (9 Mar 2003 11:19:25 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Sun, 9 Mar 2003 11:19:25 +0000 (UTC) Original-X-From: owner-ding@hpc.uh.edu Sun Mar 09 12:19:23 2003 Return-path: Original-Received: from malifon.math.uh.edu ([129.7.128.13]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 18rypv-0001Jn-00 for ; Sun, 09 Mar 2003 12:19:23 +0100 Original-Received: from sina.hpc.uh.edu ([129.7.128.10] ident=lists) by malifon.math.uh.edu with esmtp (Exim 3.20 #1) id 18ryq4-0007wv-00; Sun, 09 Mar 2003 05:19:32 -0600 Original-Received: by sina.hpc.uh.edu (TLB v0.09a (1.20 tibbs 1996/10/09 22:03:07)); Sun, 09 Mar 2003 05:20:32 -0600 (CST) Original-Received: from sclp3.sclp.com (sclp3.sclp.com [66.230.238.2]) by sina.hpc.uh.edu (8.9.3/8.9.3) with SMTP id FAA13644 for ; Sun, 9 Mar 2003 05:20:19 -0600 (CST) Original-Received: (qmail 38916 invoked by alias); 9 Mar 2003 11:19:14 -0000 Original-Received: (qmail 38911 invoked from network); 9 Mar 2003 11:19:14 -0000 Original-Received: from quimby.gnus.org (80.91.224.244) by 66.230.238.6 with SMTP; 9 Mar 2003 11:19:14 -0000 Original-Received: from news by quimby.gnus.org with local (Exim 3.12 #1 (Debian)) id 18rzAu-0004V4-00 for ; Sun, 09 Mar 2003 12:41:04 +0100 Original-To: ding@gnus.org Original-Path: not-for-mail Original-Newsgroups: gnus.ding Original-Lines: 57 Original-NNTP-Posting-Host: p50877fe5.dip.t-dialin.net Original-X-Trace: quimby.gnus.org 1047210064 16952 80.135.127.229 (9 Mar 2003 11:41:04 GMT) Original-X-Complaints-To: usenet@quimby.gnus.org Original-NNTP-Posting-Date: 9 Mar 2003 11:41:04 GMT User-Agent: Gnus/5.090016 (Oort Gnus v0.16) Emacs/21.3.50 (gnu/linux) Cancel-Lock: sha1:BgX/9ZoHVgUfKGjua+eFJy4qJEo= Precedence: list X-Majordomo: 1.94.jlt7 Xref: main.gmane.org gmane.emacs.gnus.general:50706 X-Report-Spam: http://spam.gmane.org/gmane.emacs.gnus.general:50706 Kevin Greiner writes: > It sure looks it. Let's try making a small change to > gnus-agent-fetch-selected-article :). > > Replace the entire call to gnus-summary-update-article-line with > (gnus-summary-update-line gnus-current-article) Oh, boy, I made a Freudian error and made a change in gnus-sum.el instead. Then I looked again and saw that you said to make the change in gnus-agent-fetch-selected-article... Both changes work. Are you going to check in the fix to gnus-agent-fetch-selected-article? Here is a diff showing what I tried. The gnus-sum change has been commented out; the gnus-agent change is active. cvs server: Diffing lisp Index: lisp/gnus-agent.el =================================================================== RCS file: /usr/local/cvsroot/gnus/lisp/gnus-agent.el,v retrieving revision 6.156 diff -u -r6.156 gnus-agent.el --- lisp/gnus-agent.el 7 Mar 2003 04:06:25 -0000 6.156 +++ lisp/gnus-agent.el 9 Mar 2003 11:37:29 -0000 @@ -1013,9 +1013,7 @@ (list gnus-current-article)) (setq gnus-newsgroup-undownloaded (delq gnus-current-article gnus-newsgroup-undownloaded)) - (gnus-summary-update-article-line - gnus-current-article - (gnus-summary-article-header gnus-current-article)))))) + (gnus-summary-update-line gnus-current-article))))) ;;; ;;; Internal functions Index: lisp/gnus-sum.el =================================================================== RCS file: /usr/local/cvsroot/gnus/lisp/gnus-sum.el,v retrieving revision 6.317 diff -u -r6.317 gnus-sum.el --- lisp/gnus-sum.el 3 Mar 2003 05:39:24 -0000 6.317 +++ lisp/gnus-sum.el 9 Mar 2003 11:37:51 -0000 @@ -8506,6 +8506,7 @@ header) (gnus-summary-update-article-line (cdr gnus-article-current) header) + ; (gnus-summary-update-line gnus-current-article) (when (gnus-summary-goto-subject (cdr gnus-article-current) nil t) (gnus-summary-update-secondary-mark (cdr gnus-article-current)))))) ((not arg) -- A preposition is not a good thing to end a sentence with.