New summary part commands?

New summary part commands?

[Kai Großjohann]

I've added a MIME/Multipart submenu in the summary buffers, but I'm
afraid a number of commands there are less useful than they could
be.  In particular, the *-part commands require a prefix arg, I
think.  Users using the menu bar will probably surprised by this.

Idea: Change the commands to read the part number from the minibuffer
if no prefix arg is provided.

Idea: For each command, make a (dynamic) submenu that lists the parts.

What do you think?  Other ideas?
-- 
A turnip curses Elvis

Re: New summary part commands?

[Reiner Steib]

On Mon, Feb 17 2003, Kai Großjohann wrote:

> I've added a MIME/Multipart submenu in the summary buffers, but I'm
> afraid a number of commands there are less useful than they could
> be.  In particular, the *-part commands require a prefix arg, I
> think.  Users using the menu bar will probably surprised by this.
>
> Idea: Change the commands to read the part number from the minibuffer
> if no prefix arg is provided.
>
> Idea: For each command, make a (dynamic) submenu that lists the parts.
>
> What do you think?

Both ideas are nice.  I guess I'd prefer the later, if both are
feasible.

> Other ideas?

Is it possible to use the menus without prefix if the cursor is on a
specific part in the article buffer?  E.g. now, I can use `o' or `|'
on a part without giving the number of the part explicitly, if the
cursor is on the corresponding button.

BTW, for `gnus-summary-repair-multipart' I think we should add a
`y-or-no-p' because it may *destroy* an article (on writable back
ends), e.g. if the original article wasn't b0rked.

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo--- PGP key available via WWW   http://rsteib.home.pages.de/

Re: New summary part commands?

[Kai Großjohann]

Reiner Steib <4.uce.03.r.s@nurfuerspam.de> writes:

> On Mon, Feb 17 2003, Kai Großjohann wrote:
>
>> I've added a MIME/Multipart submenu in the summary buffers, but I'm
>> afraid a number of commands there are less useful than they could
>> be.  In particular, the *-part commands require a prefix arg, I
>> think.  Users using the menu bar will probably surprised by this.
>>
>> Idea: Change the commands to read the part number from the minibuffer
>> if no prefix arg is provided.
>>
>> Idea: For each command, make a (dynamic) submenu that lists the parts.
>>
>> What do you think?
>
> Both ideas are nice.  I guess I'd prefer the later, if both are
> feasible.

Since you're so active -- would you like to do it? ;-)

>> Other ideas?
>
> Is it possible to use the menus without prefix if the cursor is on a
> specific part in the article buffer?  E.g. now, I can use `o' or `|'
> on a part without giving the number of the part explicitly, if the
> cursor is on the corresponding button.

I have no idea, but it ought to work -- invoking the menu should be
the same as the corresponding key.

> BTW, for `gnus-summary-repair-multipart' I think we should add a
> `y-or-no-p' because it may *destroy* an article (on writable back
> ends), e.g. if the original article wasn't b0rked.

Really?  I was shocked, so I quickly scanned the code, but it appears
to only modify the buffer, not the file on disk.
-- 
A turnip curses Elvis

Should gnus-summary-repair-multipart modify files on disk? (was: New summary part commands?)

[Reiner Steib]

On Wed, Feb 19 2003, Kai Großjohann wrote:

> Reiner Steib <4.uce.03.r.s@nurfuerspam.de> writes:
>> BTW, for `gnus-summary-repair-multipart' I think we should add a
>> `y-or-no-p' because it may *destroy* an article (on writable back
>> ends), e.g. if the original article wasn't b0rked.
>
> Really?  I was shocked, so I quickly scanned the code, 

,----[ C-h f gnus-with-article RET ]
| gnus-with-article is a Lisp macro in `gnus-sum'.
| (gnus-with-article ARTICLE &rest FORMS)
| 
| Select ARTICLE and perform FORMS in the original article buffer.
| Then replace the article with the result.
`----

Note the last sentence.

> but it appears to only modify the buffer, not the file on disk.

It *does* modify the article disk if you use nnfolder (Article
<news:3D2BFC8C.BeroList-2.5.9@wpxx02.toxi.uni-wuerzburg.de> from
Gmane) copied to nnfolder:Test and `K m'-ed:

--8<---------------cut here---------------start------------->8---
$ diff -U1 multi?.mbox
--- multi1.mbox Wed Feb 19 21:06:34 2003
+++ multi2.mbox Wed Feb 19 21:06:47 2003
[...]
@@ -12,4 +12,2 @@
[...]
-Mime-Version: 1.0
-Content-Type: multipart/signed; micalg=pgp-sha1;
[...]
@@ -40,4 +38,8 @@
[...]
+Mime-Version: 1.0
+Content-Type: multipart/mixed; boundary="mP3DRpeJDSE+ciuQ"
[...]
--8<---------------cut here---------------end--------------->8---

In this case, the repairing was successful.  But after reading
<news:m3bs1jppi0.fsf@quimbies.gnus.org>, I did some tests and at least
once, the `repaired' article was corrupt.  Maybe I'm able to reproduce
it later.  I didn't think that it's a bug, because the user isn't
supposed to `repair' intact articles. ;-)

So the question is: Should gnus-summary-repair-multipart modify files
on disk or only modify the buffer?

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo--- PGP key available via WWW   http://rsteib.home.pages.de/

Re: New summary part commands?

[Reiner Steib]

On Wed, Feb 19 2003, Kai Großjohann wrote:

> Reiner Steib <4.uce.03.r.s@nurfuerspam.de> writes:
>> On Mon, Feb 17 2003, Kai Großjohann wrote:

(1)
>>> Idea: Change the commands to read the part number from the minibuffer
>>> if no prefix arg is provided.
(2)
>>> Idea: For each command, make a (dynamic) submenu that lists the parts.
>>>
>>> What do you think?
>>
>> Both ideas are nice.  I guess I'd prefer the later, if both are
>> feasible.
>
> Since you're so active -- would you like to do it? ;-)

If you show me how to do it for `gnus-article-save-part', I'll try to
do it for the other commands. ;-) [I have a vague idea how to
implement (1), but no idea about (2).]

>> Is it possible to use the menus without prefix if the cursor is on a
>> specific part in the article buffer?  E.g. now, I can use `o' or `|'
>> on a part without giving the number of the part explicitly, if the
>> cursor is on the corresponding button.
>
> I have no idea, but it ought to work -- invoking the menu should be
> the same as the corresponding key.

I tried `<menu-bar> <commands> <MIME> <Multipart> <Pipe part> xless'
with the cursor on `[2. application/postscript; tst.ps]'.  xless
showed the mail text (1st part) instead.

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo--- PGP key available via WWW   http://rsteib.home.pages.de/

Re: New summary part commands?

[Kai Großjohann]

Reiner Steib <4.uce.03.r.s@nurfuerspam.de> writes:

> If you show me how to do it for `gnus-article-save-part', I'll try to
> do it for the other commands. ;-) [I have a vague idea how to
> implement (1), but no idea about (2).]

It seems that Emacs 21 has augmented menu capabilities.  See the ELisp
ref, node (elisp)Extended Menu Items.  There, look for filter-fn.

Not sure how to make it portable, though.
-- 
A preposition is not a good thing to end a sentence with.

Re: Should gnus-summary-repair-multipart modify files on disk?

[Kai Großjohann]

Reiner Steib <4.uce.03.r.s@nurfuerspam.de> writes:

> On Wed, Feb 19 2003, Kai Großjohann wrote:
>
>> Reiner Steib <4.uce.03.r.s@nurfuerspam.de> writes:
>>> BTW, for `gnus-summary-repair-multipart' I think we should add a
>>> `y-or-no-p' because it may *destroy* an article (on writable back
>>> ends), e.g. if the original article wasn't b0rked.
>>
>> Really?  I was shocked, so I quickly scanned the code, 
>
> ,----[ C-h f gnus-with-article RET ]
> | gnus-with-article is a Lisp macro in `gnus-sum'.
> | (gnus-with-article ARTICLE &rest FORMS)
> | 
> | Select ARTICLE and perform FORMS in the original article buffer.
> | Then replace the article with the result.
> `----
>
> Note the last sentence.

Thanks for setting me straight.
-- 
A preposition is not a good thing to end a sentence with.