From: Kai.Grossjohann@CS.Uni-Dortmund.DE (Kai Großjohann)
Subject: Re: gnus-agent typo?
Date: Tue, 22 Oct 2002 10:37:27 +0200 [thread overview]
Message-ID: <84hefe3m48.fsf@crybaby.cs.uni-dortmund.de> (raw)
In-Reply-To: <m3u1jf7afb.fsf@multivac.cwru.edu>
prj@po.cwru.edu (Paul Jarc) writes:
> Kai.Grossjohann@CS.Uni-Dortmund.DE (Kai Großjohann) wrote:
>> What do you think about the following patch for gnus-agent.el? I
>> guess that unseen was meant instead of seen.
>>
>> @@ -1102,7 +1108,7 @@
>> gnus-agent-cache)
>> ;; Add article with marks to list of article headers we want to fetch.
>> (dolist (arts (gnus-info-marks (gnus-get-info group)))
>> - (unless (memq (car arts) '(seen recent))
>> + (unless (memq (car arts) '(unseen recent))
>> (setq articles (gnus-range-add articles (cdr arts)))))
>> (setq articles (sort (gnus-uncompress-sequence articles) '<))
>> ;; Remove known articles.
>
> Gnus has no unseen mark, AFAIK. Gnus has a seen mark, and displays
> "." in the *Summary* buffer for articles that *lack* the seen mark.
> So I think it ought to be:
> (unless (eq (car arts) 'recent)
> And then the 'seen articles should be removed from the range
> afterwards.
How about this? Is this the right logic?
(when (or (eq (car arts) 'seen)
(not (eq (car arts) 'recent)))
(setq articles (gnus-range-add articles (cdr arts))))
I switched from unless to when because I don't like no double
negatives...
kai
--
~/.signature is: umop ap!sdn (Frank Nobis)
next prev parent reply other threads:[~2002-10-22 8:37 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-18 18:05 Kai Großjohann
2002-10-21 21:23 ` Paul Jarc
2002-10-22 8:37 ` Kai Großjohann [this message]
2002-10-22 18:02 ` Paul Jarc
2002-10-23 8:07 ` Kai Großjohann
2002-10-23 15:20 ` Paul Jarc
2002-10-23 15:40 ` Kai Großjohann
2002-10-23 15:58 ` Paul Jarc
2002-10-24 7:08 ` Kai Großjohann
2002-10-24 10:26 ` Simon Josefsson
2002-10-24 10:35 ` Kai Großjohann
2002-10-24 15:24 ` Simon Josefsson
2002-10-24 16:58 ` Kai Großjohann
2002-10-24 19:20 ` Kai Großjohann
2002-10-24 23:30 ` Simon Josefsson
2002-10-25 8:51 ` Kai Großjohann
2002-10-25 10:35 ` Simon Josefsson
2002-10-25 10:48 ` Kai Großjohann
2002-10-26 16:56 ` Clemens Fischer
2002-10-24 15:12 ` Paul Jarc
2002-10-24 17:03 ` Kai Großjohann
2002-10-24 17:34 ` Paul Jarc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84hefe3m48.fsf@crybaby.cs.uni-dortmund.de \
--to=kai.grossjohann@cs.uni-dortmund.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).