From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/47351 Path: main.gmane.org!not-for-mail From: Kai.Grossjohann@CS.Uni-Dortmund.DE (Kai =?iso-8859-1?q?Gro=DFjohann?=) Newsgroups: gmane.emacs.gnus.general Subject: Re: gnus-agent typo? Date: Tue, 22 Oct 2002 10:37:27 +0200 Organization: University of Dortmund, Germany Sender: owner-ding@hpc.uh.edu Message-ID: <84hefe3m48.fsf@crybaby.cs.uni-dortmund.de> References: <84n0pbipvq.fsf@crybaby.cs.uni-dortmund.de> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Trace: main.gmane.org 1035275845 20397 80.91.224.249 (22 Oct 2002 08:37:25 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Tue, 22 Oct 2002 08:37:25 +0000 (UTC) Return-path: Original-Received: from malifon.math.uh.edu ([129.7.128.13]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 183uXT-0005IX-00 for ; Tue, 22 Oct 2002 10:37:23 +0200 Original-Received: from sina.hpc.uh.edu ([129.7.128.10] ident=lists) by malifon.math.uh.edu with esmtp (Exim 3.20 #1) id 183uXp-0000Z9-00; Tue, 22 Oct 2002 03:37:46 -0500 Original-Received: by sina.hpc.uh.edu (TLB v0.09a (1.20 tibbs 1996/10/09 22:03:07)); Tue, 22 Oct 2002 03:38:30 -0500 (CDT) Original-Received: from sclp3.sclp.com (qmailr@sclp3.sclp.com [209.196.61.66]) by sina.hpc.uh.edu (8.9.3/8.9.3) with SMTP id DAA20649 for ; Tue, 22 Oct 2002 03:38:18 -0500 (CDT) Original-Received: (qmail 25195 invoked by alias); 22 Oct 2002 08:37:29 -0000 Original-Received: (qmail 25189 invoked from network); 22 Oct 2002 08:37:29 -0000 Original-Received: from quimby.gnus.org (80.91.224.244) by gnus.org with SMTP; 22 Oct 2002 08:37:29 -0000 Original-Received: from news by quimby.gnus.org with local (Exim 3.12 #1 (Debian)) id 183uXi-0002tg-00 for ; Tue, 22 Oct 2002 10:37:38 +0200 Original-To: ding@gnus.org Original-Path: not-for-mail Original-Newsgroups: gnus.ding Original-Lines: 35 Original-NNTP-Posting-Host: crybaby.uni-duisburg.de Original-X-Trace: quimby.gnus.org 1035275858 10523 134.91.30.116 (22 Oct 2002 08:37:38 GMT) Original-X-Complaints-To: usenet@quimby.gnus.org Original-NNTP-Posting-Date: 22 Oct 2002 08:37:38 GMT User-Agent: Gnus/5.090008 (Oort Gnus v0.08) Emacs/21.3.50 (i686-pc-linux-gnu) Cancel-Lock: sha1:j9ePCjvxhntzmR9aXiD0LmuhUeM= Precedence: list X-Majordomo: 1.94.jlt7 Xref: main.gmane.org gmane.emacs.gnus.general:47351 X-Report-Spam: http://spam.gmane.org/gmane.emacs.gnus.general:47351 prj@po.cwru.edu (Paul Jarc) writes: > Kai.Grossjohann@CS.Uni-Dortmund.DE (Kai Großjohann) wrote: >> What do you think about the following patch for gnus-agent.el? I >> guess that unseen was meant instead of seen. >> >> @@ -1102,7 +1108,7 @@ >> gnus-agent-cache) >> ;; Add article with marks to list of article headers we want to fetch. >> (dolist (arts (gnus-info-marks (gnus-get-info group))) >> - (unless (memq (car arts) '(seen recent)) >> + (unless (memq (car arts) '(unseen recent)) >> (setq articles (gnus-range-add articles (cdr arts))))) >> (setq articles (sort (gnus-uncompress-sequence articles) '<)) >> ;; Remove known articles. > > Gnus has no unseen mark, AFAIK. Gnus has a seen mark, and displays > "." in the *Summary* buffer for articles that *lack* the seen mark. > So I think it ought to be: > (unless (eq (car arts) 'recent) > And then the 'seen articles should be removed from the range > afterwards. How about this? Is this the right logic? (when (or (eq (car arts) 'seen) (not (eq (car arts) 'recent))) (setq articles (gnus-range-add articles (cdr arts)))) I switched from unless to when because I don't like no double negatives... kai -- ~/.signature is: umop ap!sdn (Frank Nobis)